| Message ID | 20240201201248.2334798-2-dlechner@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bed41a344426a407ba5e103b2877a2e560e72229 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [v2] wifi: wilc1000: remove setting msg.spi | expand |
David Lechner <dlechner@baylibre.com> wrote: > Calling spi_sync() unconditionally sets the spi field of struct > spi_message. Therefore setting msg.spi = spi before calling spi_sync() > has no effect and can be removed. > > (spi_message_add_tail() does not access this field.) > > Signed-off-by: David Lechner <dlechner@baylibre.com> Patch applied to wireless-next.git, thanks. bed41a344426 wifi: wilc1000: remove setting msg.spi
diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/wireless/microchip/wilc1000/spi.c index 77b4cdff73c3..7eb0f8a421a3 100644 --- a/drivers/net/wireless/microchip/wilc1000/spi.c +++ b/drivers/net/wireless/microchip/wilc1000/spi.c @@ -300,7 +300,6 @@ static int wilc_spi_tx(struct wilc *wilc, u8 *b, u32 len) memset(&msg, 0, sizeof(msg)); spi_message_init(&msg); - msg.spi = spi; spi_message_add_tail(&tr, &msg); ret = spi_sync(spi, &msg); @@ -343,7 +342,6 @@ static int wilc_spi_rx(struct wilc *wilc, u8 *rb, u32 rlen) memset(&msg, 0, sizeof(msg)); spi_message_init(&msg); - msg.spi = spi; spi_message_add_tail(&tr, &msg); ret = spi_sync(spi, &msg); @@ -381,8 +379,6 @@ static int wilc_spi_tx_rx(struct wilc *wilc, u8 *wb, u8 *rb, u32 rlen) memset(&msg, 0, sizeof(msg)); spi_message_init(&msg); - msg.spi = spi; - spi_message_add_tail(&tr, &msg); ret = spi_sync(spi, &msg); if (ret < 0)
Calling spi_sync() unconditionally sets the spi field of struct spi_message. Therefore setting msg.spi = spi before calling spi_sync() has no effect and can be removed. (spi_message_add_tail() does not access this field.) Signed-off-by: David Lechner <dlechner@baylibre.com> --- v2 changes: * fixed incomplete commit message Link to v1: https://patchwork.kernel.org/project/linux-wireless/patch/20240123212135.2607178-1-dlechner@baylibre.com/ drivers/net/wireless/microchip/wilc1000/spi.c | 4 ---- 1 file changed, 4 deletions(-)