diff mbox series

[RESEND] virtio_crypto: remove duplicate check if queue is broken

Message ID 20240201061716.16336-1-lirongqing@baidu.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show
Series [RESEND] virtio_crypto: remove duplicate check if queue is broken | expand

Commit Message

Li RongQing Feb. 1, 2024, 6:17 a.m. UTC
virtqueue_enable_cb() will call virtqueue_poll() which will check if
queue is broken at beginning, so remove the virtqueue_is_broken() call

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 drivers/crypto/virtio/virtio_crypto_core.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Herbert Xu Feb. 9, 2024, 5:01 a.m. UTC | #1
Li RongQing <lirongqing@baidu.com> wrote:
> virtqueue_enable_cb() will call virtqueue_poll() which will check if
> queue is broken at beginning, so remove the virtqueue_is_broken() call
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> drivers/crypto/virtio/virtio_crypto_core.c | 2 --
> 1 file changed, 2 deletions(-)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/crypto/virtio/virtio_crypto_core.c
index b909c6a..6a67d70 100644
--- a/drivers/crypto/virtio/virtio_crypto_core.c
+++ b/drivers/crypto/virtio/virtio_crypto_core.c
@@ -42,8 +42,6 @@  static void virtcrypto_ctrlq_callback(struct virtqueue *vq)
 			virtio_crypto_ctrlq_callback(vc_ctrl_req);
 			spin_lock_irqsave(&vcrypto->ctrl_lock, flags);
 		}
-		if (unlikely(virtqueue_is_broken(vq)))
-			break;
 	} while (!virtqueue_enable_cb(vq));
 	spin_unlock_irqrestore(&vcrypto->ctrl_lock, flags);
 }