| Message ID | 20240222125634.275047-1-vinod.govindapillai@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | LNL display | expand |
+Gustavo as he was looking at upstreaming these patches. Were the issues with mdclk handling pointed out at latest attempt fixed? From the changelog it doesn't seem so. https://lore.kernel.org/all/20230908224303.GX2706891@mdroper-desk1.amr.corp.intel.com/ and also worth taking a look at previous versions: https://lore.kernel.org/all/?q=s%3A%22Introduce+MDCLK_CDCLK+ratio+to+DBuf%22 Lucas De Marchi On Thu, Feb 22, 2024 at 02:56:28PM +0200, Vinod Govindapillai wrote: >Rest of the cdclk patches as well as the patches to enable the display in LNL > >Balasubramani Vivekanandan (2): > drm/i915/xe2lpd: Load DMC > drm/xe/lnl: Enable the display support > >Ravi Kumar Vodapalli (1): > drm/i915/lnl: Add programming for CDCLK change > >Stanislav Lisovskiy (3): > drm/i915/lnl: Introduce MDCLK_CDCLK ratio to DBuf > drm/i915/xe2lpd: Write DBuf after CDCLK change in post plane > drm/i915/xe2lpd: Update mbus on post plane updates > > drivers/gpu/drm/i915/display/intel_cdclk.c | 74 ++++++++++++++++++- > drivers/gpu/drm/i915/display/intel_display.c | 5 +- > drivers/gpu/drm/i915/display/intel_dmc.c | 9 ++- > drivers/gpu/drm/i915/display/skl_watermark.c | 35 +++++++-- > drivers/gpu/drm/i915/display/skl_watermark.h | 1 + > .../gpu/drm/i915/display/skl_watermark_regs.h | 2 + > drivers/gpu/drm/xe/xe_pci.c | 1 + > 7 files changed, 118 insertions(+), 9 deletions(-) > >-- >2.34.1 >
Hi, Well.. sorry.. I didn't know Gustavo is already working on this! @Gustavo, pls ignore this series if you are arealdy working on this. Please let me know On Thu, 2024-02-22 at 08:02 -0600, Lucas De Marchi wrote: > +Gustavo as he was looking at upstreaming these patches. > > Were the issues with mdclk handling pointed out at latest attempt fixed? > From the changelog it doesn't seem so. > > https://lore.kernel.org/all/20230908224303.GX2706891@mdroper-desk1.amr.corp.intel.com/ Yeah.. i did not notice these comments! Lets wait for Gustavo's reply BR vinod > > and also worth taking a look at previous versions: > https://lore.kernel.org/all/?q=s%3A%22Introduce+MDCLK_CDCLK+ratio+to+DBuf%22 > > Lucas De Marchi > > On Thu, Feb 22, 2024 at 02:56:28PM +0200, Vinod Govindapillai wrote: > > Rest of the cdclk patches as well as the patches to enable the display in LNL > > > > Balasubramani Vivekanandan (2): > > drm/i915/xe2lpd: Load DMC > > drm/xe/lnl: Enable the display support > > > > Ravi Kumar Vodapalli (1): > > drm/i915/lnl: Add programming for CDCLK change > > > > Stanislav Lisovskiy (3): > > drm/i915/lnl: Introduce MDCLK_CDCLK ratio to DBuf > > drm/i915/xe2lpd: Write DBuf after CDCLK change in post plane > > drm/i915/xe2lpd: Update mbus on post plane updates > > > > drivers/gpu/drm/i915/display/intel_cdclk.c | 74 ++++++++++++++++++- > > drivers/gpu/drm/i915/display/intel_display.c | 5 +- > > drivers/gpu/drm/i915/display/intel_dmc.c | 9 ++- > > drivers/gpu/drm/i915/display/skl_watermark.c | 35 +++++++-- > > drivers/gpu/drm/i915/display/skl_watermark.h | 1 + > > .../gpu/drm/i915/display/skl_watermark_regs.h | 2 + > > drivers/gpu/drm/xe/xe_pci.c | 1 + > > 7 files changed, 118 insertions(+), 9 deletions(-) > > > > -- > > 2.34.1 > >
Hi, guys. Quoting Govindapillai, Vinod (2024-02-22 11:39:32-03:00) >Hi, > >Well.. sorry.. I didn't know Gustavo is already working on this! >@Gustavo, pls ignore this series if you are arealdy working on this. Please let me know Yeah. I have a couple of local fixes to apply to those commits, but I'm not finished yet. If you are okay with that, I can finish what I've already started and send a fresh new series (considering that this series has no modifications to what we already have). -- Gustavo Sousa > >On Thu, 2024-02-22 at 08:02 -0600, Lucas De Marchi wrote: >> +Gustavo as he was looking at upstreaming these patches. >> >> Were the issues with mdclk handling pointed out at latest attempt fixed? >> From the changelog it doesn't seem so. >> >> https://lore.kernel.org/all/20230908224303.GX2706891@mdroper-desk1.amr.corp.intel.com/ > >Yeah.. i did not notice these comments! Lets wait for Gustavo's reply > >BR >vinod > >> >> and also worth taking a look at previous versions: >> https://lore.kernel.org/all/?q=s%3A%22Introduce+MDCLK_CDCLK+ratio+to+DBuf%22 >> >> Lucas De Marchi >> >> On Thu, Feb 22, 2024 at 02:56:28PM +0200, Vinod Govindapillai wrote: >> > Rest of the cdclk patches as well as the patches to enable the display in LNL >> > >> > Balasubramani Vivekanandan (2): >> > drm/i915/xe2lpd: Load DMC >> > drm/xe/lnl: Enable the display support >> > >> > Ravi Kumar Vodapalli (1): >> > drm/i915/lnl: Add programming for CDCLK change >> > >> > Stanislav Lisovskiy (3): >> > drm/i915/lnl: Introduce MDCLK_CDCLK ratio to DBuf >> > drm/i915/xe2lpd: Write DBuf after CDCLK change in post plane >> > drm/i915/xe2lpd: Update mbus on post plane updates >> > >> > drivers/gpu/drm/i915/display/intel_cdclk.c | 74 ++++++++++++++++++- >> > drivers/gpu/drm/i915/display/intel_display.c | 5 +- >> > drivers/gpu/drm/i915/display/intel_dmc.c | 9 ++- >> > drivers/gpu/drm/i915/display/skl_watermark.c | 35 +++++++-- >> > drivers/gpu/drm/i915/display/skl_watermark.h | 1 + >> > .../gpu/drm/i915/display/skl_watermark_regs.h | 2 + >> > drivers/gpu/drm/xe/xe_pci.c | 1 + >> > 7 files changed, 118 insertions(+), 9 deletions(-) >> > >> > -- >> > 2.34.1 >> > >
Hi, guys. (This is a re-send, because I *think* my MUA badly formed the address to the mailing list.) Quoting Govindapillai, Vinod (2024-02-22 11:39:32-03:00) >Hi, > >Well.. sorry.. I didn't know Gustavo is already working on this! >@Gustavo, pls ignore this series if you are arealdy working on this. Please let me know Yeah. I have a couple of local fixes to apply to those commits, but I'm not finished yet. If you are okay with that, I can finish what I've already started and send a fresh new series (considering that this series has no modifications to what we already have). -- Gustavo Sousa > >On Thu, 2024-02-22 at 08:02 -0600, Lucas De Marchi wrote: >> +Gustavo as he was looking at upstreaming these patches. >> >> Were the issues with mdclk handling pointed out at latest attempt fixed? >> From the changelog it doesn't seem so. >> >> https://lore.kernel.org/all/20230908224303.GX2706891@mdroper-desk1.amr.corp.intel.com/ > >Yeah.. i did not notice these comments! Lets wait for Gustavo's reply > >BR >vinod > >> >> and also worth taking a look at previous versions: >> https://lore.kernel.org/all/?q=s%3A%22Introduce+MDCLK_CDCLK+ratio+to+DBuf%22 >> >> Lucas De Marchi >> >> On Thu, Feb 22, 2024 at 02:56:28PM +0200, Vinod Govindapillai wrote: >> > Rest of the cdclk patches as well as the patches to enable the display in LNL >> > >> > Balasubramani Vivekanandan (2): >> > drm/i915/xe2lpd: Load DMC >> > drm/xe/lnl: Enable the display support >> > >> > Ravi Kumar Vodapalli (1): >> > drm/i915/lnl: Add programming for CDCLK change >> > >> > Stanislav Lisovskiy (3): >> > drm/i915/lnl: Introduce MDCLK_CDCLK ratio to DBuf >> > drm/i915/xe2lpd: Write DBuf after CDCLK change in post plane >> > drm/i915/xe2lpd: Update mbus on post plane updates >> > >> > drivers/gpu/drm/i915/display/intel_cdclk.c | 74 ++++++++++++++++++- >> > drivers/gpu/drm/i915/display/intel_display.c | 5 +- >> > drivers/gpu/drm/i915/display/intel_dmc.c | 9 ++- >> > drivers/gpu/drm/i915/display/skl_watermark.c | 35 +++++++-- >> > drivers/gpu/drm/i915/display/skl_watermark.h | 1 + >> > .../gpu/drm/i915/display/skl_watermark_regs.h | 2 + >> > drivers/gpu/drm/xe/xe_pci.c | 1 + >> > 7 files changed, 118 insertions(+), 9 deletions(-) >> > >> > -- >> > 2.34.1 >> > >
Hi. On Thu, 2024-02-22 at 13:04 -0300, Gustavo Sousa wrote: > Hi, guys. > > (This is a re-send, because I *think* my MUA badly formed the address to > the mailing list.) > > Quoting Govindapillai, Vinod (2024-02-22 11:39:32-03:00) > > Hi, > > > > Well.. sorry.. I didn't know Gustavo is already working on this! > > @Gustavo, pls ignore this series if you are arealdy working on this. Please let me know > > Yeah. I have a couple of local fixes to apply to those commits, but I'm > not finished yet. If you are okay with that, I can finish what I've > already started and send a fresh new series (considering that this > series has no modifications to what we already have). Yes! Please do so! Vinod > > -- > Gustavo Sousa > > > > > On Thu, 2024-02-22 at 08:02 -0600, Lucas De Marchi wrote: > > > +Gustavo as he was looking at upstreaming these patches. > > > > > > Were the issues with mdclk handling pointed out at latest attempt fixed? > > > From the changelog it doesn't seem so. > > > > > > https://lore.kernel.org/all/20230908224303.GX2706891@mdroper-desk1.amr.corp.intel.com/ > > > > Yeah.. i did not notice these comments! Lets wait for Gustavo's reply > > > > BR > > vinod > > > > > > > > and also worth taking a look at previous versions: > > > https://lore.kernel.org/all/?q=s%3A%22Introduce+MDCLK_CDCLK+ratio+to+DBuf%22 > > > > > > Lucas De Marchi > > > > > > On Thu, Feb 22, 2024 at 02:56:28PM +0200, Vinod Govindapillai wrote: > > > > Rest of the cdclk patches as well as the patches to enable the display in LNL > > > > > > > > Balasubramani Vivekanandan (2): > > > > drm/i915/xe2lpd: Load DMC > > > > drm/xe/lnl: Enable the display support > > > > > > > > Ravi Kumar Vodapalli (1): > > > > drm/i915/lnl: Add programming for CDCLK change > > > > > > > > Stanislav Lisovskiy (3): > > > > drm/i915/lnl: Introduce MDCLK_CDCLK ratio to DBuf > > > > drm/i915/xe2lpd: Write DBuf after CDCLK change in post plane > > > > drm/i915/xe2lpd: Update mbus on post plane updates > > > > > > > > drivers/gpu/drm/i915/display/intel_cdclk.c | 74 ++++++++++++++++++- > > > > drivers/gpu/drm/i915/display/intel_display.c | 5 +- > > > > drivers/gpu/drm/i915/display/intel_dmc.c | 9 ++- > > > > drivers/gpu/drm/i915/display/skl_watermark.c | 35 +++++++-- > > > > drivers/gpu/drm/i915/display/skl_watermark.h | 1 + > > > > .../gpu/drm/i915/display/skl_watermark_regs.h | 2 + > > > > drivers/gpu/drm/xe/xe_pci.c | 1 + > > > > 7 files changed, 118 insertions(+), 9 deletions(-) > > > > > > > > -- > > > > 2.34.1 > > > > > >
Quoting Govindapillai, Vinod (2024-02-22 14:18:53-03:00) >Hi. > > > >On Thu, 2024-02-22 at 13:04 -0300, Gustavo Sousa wrote: >> Hi, guys. >> >> (This is a re-send, because I *think* my MUA badly formed the address to >> the mailing list.) >> >> Quoting Govindapillai, Vinod (2024-02-22 11:39:32-03:00) >> > Hi, >> > >> > Well.. sorry.. I didn't know Gustavo is already working on this! >> > @Gustavo, pls ignore this series if you are arealdy working on this. Please let me know >> >> Yeah. I have a couple of local fixes to apply to those commits, but I'm >> not finished yet. If you are okay with that, I can finish what I've >> already started and send a fresh new series (considering that this >> series has no modifications to what we already have). > >Yes! Please do so! It turns out that I ended up rewriting our logic and, as such, created new patches as a result. Series is available at https://patchwork.freedesktop.org/series/130689/ -- Gustavo Sousa > > >Vinod >> >> -- >> Gustavo Sousa >> >> > >> > On Thu, 2024-02-22 at 08:02 -0600, Lucas De Marchi wrote: >> > > +Gustavo as he was looking at upstreaming these patches. >> > > >> > > Were the issues with mdclk handling pointed out at latest attempt fixed? >> > > From the changelog it doesn't seem so. >> > > >> > > https://lore.kernel.org/all/20230908224303.GX2706891@mdroper-desk1.amr.corp.intel.com/ >> > >> > Yeah.. i did not notice these comments! Lets wait for Gustavo's reply >> > >> > BR >> > vinod >> > >> > > >> > > and also worth taking a look at previous versions: >> > > https://lore.kernel.org/all/?q=s%3A%22Introduce+MDCLK_CDCLK+ratio+to+DBuf%22 >> > > >> > > Lucas De Marchi >> > > >> > > On Thu, Feb 22, 2024 at 02:56:28PM +0200, Vinod Govindapillai wrote: >> > > > Rest of the cdclk patches as well as the patches to enable the display in LNL >> > > > >> > > > Balasubramani Vivekanandan (2): >> > > > drm/i915/xe2lpd: Load DMC >> > > > drm/xe/lnl: Enable the display support >> > > > >> > > > Ravi Kumar Vodapalli (1): >> > > > drm/i915/lnl: Add programming for CDCLK change >> > > > >> > > > Stanislav Lisovskiy (3): >> > > > drm/i915/lnl: Introduce MDCLK_CDCLK ratio to DBuf >> > > > drm/i915/xe2lpd: Write DBuf after CDCLK change in post plane >> > > > drm/i915/xe2lpd: Update mbus on post plane updates >> > > > >> > > > drivers/gpu/drm/i915/display/intel_cdclk.c | 74 ++++++++++++++++++- >> > > > drivers/gpu/drm/i915/display/intel_display.c | 5 +- >> > > > drivers/gpu/drm/i915/display/intel_dmc.c | 9 ++- >> > > > drivers/gpu/drm/i915/display/skl_watermark.c | 35 +++++++-- >> > > > drivers/gpu/drm/i915/display/skl_watermark.h | 1 + >> > > > .../gpu/drm/i915/display/skl_watermark_regs.h | 2 + >> > > > drivers/gpu/drm/xe/xe_pci.c | 1 + >> > > > 7 files changed, 118 insertions(+), 9 deletions(-) >> > > > >> > > > -- >> > > > 2.34.1 >> > > > >> > >