| Message ID | 20240223004258.3104051-1-seanjc@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: selftests: Add SEV and SEV-ES smoke tests | expand |
Hello, On 2/22/24 18:42, Sean Christopherson wrote: > Add basic SEV and SEV-ES smoke tests. Unlike the intra-host migration tests, > this one actually runs a small chunk of code in the guest. > > Unless anyone strongly objects to the quick and dirty approach I've taken for > SEV-ES, I'll get all of this queued for 6.9 soon-ish. > > As for _why_ I added the quick-and-dirty SEV-ES testcase, I have a series to > cleanup __svm_sev_es_vcpu_run(), and found out that apparently I have a version > of OVMF that doesn't quite have to the right <something> for SEV-ES, and so I > could even get a "real" VM to reach KVM_RUN. I assumed (correctly, yay!) that > hacking together a selftest would be faster than figuring out what firmware > magic I am missing. Tested-by: Carlos Bilbao <carlos.bilbao@amd.com> > > v9: > - Drop is_kvm_sev_supported() and rely purely on KVM capabilities. > - Check X86_FEATURE_SEV to ensure SEV is actually enabled. > - Collect tags. [Carlos, Itaru] > > v8: > - https://lore.kernel.org/all/cc9a1951-e76c-470d-a4d1-8ad67bae5794@amd.com > - Undo the kvm.h uAPI breakage. > - Take advantage of "struct vm_shape", introduced by the guest_memfd > selftests, to simply tracking the SEV/SEV-ES subtypes. > - Rename the test to "sev_smoke_test" instead of "sev_all_boot_test", > as the "all" is rather nonsensical, and the test isn't booting anything > in the traditional sense of the word. > - Drop vm->protected and instead add an arch hook to query if the VM has > protected memory. > - Assert that the target memory region supports protected memory when > allocating protected memory. > - Allocate protected_phy_pages for memory regions if and only if the VM > supports protected memory. > - Rename kvm_host.h to kvm_util_arch.h, and move it to selftests/kvm where > it belongs. > - Fix up some SoB goofs. > - Convert the intrahost SEV/SEV-ES migration tests to use common ioctl() > wrappers. > > Ackerley Tng (1): > KVM: selftests: Add a macro to iterate over a sparsebit range > > Michael Roth (2): > KVM: selftests: Make sparsebit structs const where appropriate > KVM: selftests: Add support for protected vm_vaddr_* allocations > > Peter Gonda (5): > KVM: selftests: Add support for allocating/managing protected guest > memory > KVM: selftests: Explicitly ucall pool from shared memory > KVM: selftests: Allow tagging protected memory in guest page tables > KVM: selftests: Add library for creating and interacting with SEV > guests > KVM: selftests: Add a basic SEV smoke test > > Sean Christopherson (3): > KVM: selftests: Extend VM creation's @shape to allow control of VM > subtype > KVM: selftests: Use the SEV library APIs in the intra-host migration > test > KVM: selftests: Add a basic SEV-ES smoke test > > tools/testing/selftests/kvm/Makefile | 2 + > .../kvm/include/aarch64/kvm_util_arch.h | 7 ++ > .../selftests/kvm/include/kvm_util_base.h | 50 +++++++- > .../kvm/include/riscv/kvm_util_arch.h | 7 ++ > .../kvm/include/s390x/kvm_util_arch.h | 7 ++ > .../testing/selftests/kvm/include/sparsebit.h | 56 ++++++--- > .../kvm/include/x86_64/kvm_util_arch.h | 23 ++++ > .../selftests/kvm/include/x86_64/processor.h | 8 ++ > .../selftests/kvm/include/x86_64/sev.h | 107 ++++++++++++++++ > tools/testing/selftests/kvm/lib/kvm_util.c | 67 ++++++++-- > tools/testing/selftests/kvm/lib/sparsebit.c | 48 ++++---- > .../testing/selftests/kvm/lib/ucall_common.c | 3 +- > .../selftests/kvm/lib/x86_64/processor.c | 32 ++++- > tools/testing/selftests/kvm/lib/x86_64/sev.c | 114 ++++++++++++++++++ > .../selftests/kvm/x86_64/sev_migrate_tests.c | 67 ++++------ > .../selftests/kvm/x86_64/sev_smoke_test.c | 88 ++++++++++++++ > 16 files changed, 583 insertions(+), 103 deletions(-) > create mode 100644 tools/testing/selftests/kvm/include/aarch64/kvm_util_arch.h > create mode 100644 tools/testing/selftests/kvm/include/riscv/kvm_util_arch.h > create mode 100644 tools/testing/selftests/kvm/include/s390x/kvm_util_arch.h > create mode 100644 tools/testing/selftests/kvm/include/x86_64/kvm_util_arch.h > create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev.h > create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev.c > create mode 100644 tools/testing/selftests/kvm/x86_64/sev_smoke_test.c > > > base-commit: 60eedcfceda9db46f1b333e5e1aa9359793f04fb Thanks, Carlos
On Thu, 22 Feb 2024 16:42:47 -0800, Sean Christopherson wrote: > Add basic SEV and SEV-ES smoke tests. Unlike the intra-host migration tests, > this one actually runs a small chunk of code in the guest. > > Unless anyone strongly objects to the quick and dirty approach I've taken for > SEV-ES, I'll get all of this queued for 6.9 soon-ish. > > As for _why_ I added the quick-and-dirty SEV-ES testcase, I have a series to > cleanup __svm_sev_es_vcpu_run(), and found out that apparently I have a version > of OVMF that doesn't quite have to the right <something> for SEV-ES, and so I > could even get a "real" VM to reach KVM_RUN. I assumed (correctly, yay!) that > hacking together a selftest would be faster than figuring out what firmware > magic I am missing. > > [...] Applied to kvm-x86 selftests, thanks! [01/11] KVM: selftests: Extend VM creation's @shape to allow control of VM subtype https://github.com/kvm-x86/linux/commit/309d1ad7b6ff [02/11] KVM: selftests: Make sparsebit structs const where appropriate https://github.com/kvm-x86/linux/commit/6077c3ce4021 [03/11] KVM: selftests: Add a macro to iterate over a sparsebit range https://github.com/kvm-x86/linux/commit/8811565ff68e [04/11] KVM: selftests: Add support for allocating/managing protected guest memory https://github.com/kvm-x86/linux/commit/29e749e8faff [05/11] KVM: selftests: Add support for protected vm_vaddr_* allocations https://github.com/kvm-x86/linux/commit/1e3af7cf984a [06/11] KVM: selftests: Explicitly ucall pool from shared memory https://github.com/kvm-x86/linux/commit/5ef7196273b6 [07/11] KVM: selftests: Allow tagging protected memory in guest page tables https://github.com/kvm-x86/linux/commit/a8446cd81de8 [08/11] KVM: selftests: Add library for creating and interacting with SEV guests https://github.com/kvm-x86/linux/commit/f3ff1e9b2f9c [09/11] KVM: selftests: Use the SEV library APIs in the intra-host migration test https://github.com/kvm-x86/linux/commit/0837ddb51f9b [10/11] KVM: selftests: Add a basic SEV smoke test https://github.com/kvm-x86/linux/commit/5101f1e27683 [11/11] KVM: selftests: Add a basic SEV-ES smoke test https://github.com/kvm-x86/linux/commit/f3750b0c7f6e -- https://github.com/kvm-x86/linux/tree/next
On Mon, Feb 26, 2024, Sean Christopherson wrote: > On Thu, 22 Feb 2024 16:42:47 -0800, Sean Christopherson wrote: > > Add basic SEV and SEV-ES smoke tests. Unlike the intra-host migration tests, > > this one actually runs a small chunk of code in the guest. > > > > Unless anyone strongly objects to the quick and dirty approach I've taken for > > SEV-ES, I'll get all of this queued for 6.9 soon-ish. > > > > As for _why_ I added the quick-and-dirty SEV-ES testcase, I have a series to > > cleanup __svm_sev_es_vcpu_run(), and found out that apparently I have a version > > of OVMF that doesn't quite have to the right <something> for SEV-ES, and so I > > could even get a "real" VM to reach KVM_RUN. I assumed (correctly, yay!) that > > hacking together a selftest would be faster than figuring out what firmware > > magic I am missing. > > > > [...] > > Applied to kvm-x86 selftests, thanks! > > [01/11] KVM: selftests: Extend VM creation's @shape to allow control of VM subtype > https://github.com/kvm-x86/linux/commit/309d1ad7b6ff > [02/11] KVM: selftests: Make sparsebit structs const where appropriate > https://github.com/kvm-x86/linux/commit/6077c3ce4021 > [03/11] KVM: selftests: Add a macro to iterate over a sparsebit range > https://github.com/kvm-x86/linux/commit/8811565ff68e > [04/11] KVM: selftests: Add support for allocating/managing protected guest memory > https://github.com/kvm-x86/linux/commit/29e749e8faff > [05/11] KVM: selftests: Add support for protected vm_vaddr_* allocations > https://github.com/kvm-x86/linux/commit/1e3af7cf984a > [06/11] KVM: selftests: Explicitly ucall pool from shared memory > https://github.com/kvm-x86/linux/commit/5ef7196273b6 > [07/11] KVM: selftests: Allow tagging protected memory in guest page tables > https://github.com/kvm-x86/linux/commit/a8446cd81de8 > [08/11] KVM: selftests: Add library for creating and interacting with SEV guests > https://github.com/kvm-x86/linux/commit/f3ff1e9b2f9c > [09/11] KVM: selftests: Use the SEV library APIs in the intra-host migration test > https://github.com/kvm-x86/linux/commit/0837ddb51f9b > [10/11] KVM: selftests: Add a basic SEV smoke test > https://github.com/kvm-x86/linux/commit/5101f1e27683 > [11/11] KVM: selftests: Add a basic SEV-ES smoke test > https://github.com/kvm-x86/linux/commit/f3750b0c7f6e FYI, the hashes changed due to a force push to squash a bug in a different series. [1/11] KVM: selftests: Extend VM creation's @shape to allow control of VM subtype https://github.com/kvm-x86/linux/commit/126190379c57 [2/11] KVM: selftests: Make sparsebit structs const where appropriate https://github.com/kvm-x86/linux/commit/35f50c91c43e [3/11] KVM: selftests: Add a macro to iterate over a sparsebit range https://github.com/kvm-x86/linux/commit/57e19f057758 [4/11] KVM: selftests: Add support for allocating/managing protected guest memory https://github.com/kvm-x86/linux/commit/cd8eb2913205 [5/11] KVM: selftests: Add support for protected vm_vaddr_* allocations https://github.com/kvm-x86/linux/commit/d210eebb51a2 [6/11] KVM: selftests: Explicitly ucall pool from shared memory https://github.com/kvm-x86/linux/commit/31e00dae72fd [7/11] KVM: selftests: Allow tagging protected memory in guest page tables https://github.com/kvm-x86/linux/commit/bf47e87c65be [8/11] KVM: selftests: Add library for creating and interacting with SEV guests https://github.com/kvm-x86/linux/commit/bdceeebcddb8 [9/11] KVM: selftests: Use the SEV library APIs in the intra-host migration test https://github.com/kvm-x86/linux/commit/8b174eb9d289 [10/11] KVM: selftests: Add a basic SEV smoke test https://github.com/kvm-x86/linux/commit/faa0d7027de3 [11/11] KVM: selftests: Add a basic SEV-ES smoke test https://github.com/kvm-x86/linux/commit/974ba6f0e595
On Wed, Feb 28, 2024, Sean Christopherson wrote: > FYI, the hashes changed due to a force push to squash a bug in a different > series. > > [1/11] KVM: selftests: Extend VM creation's @shape to allow control of VM subtype > https://github.com/kvm-x86/linux/commit/126190379c57 > [2/11] KVM: selftests: Make sparsebit structs const where appropriate > https://github.com/kvm-x86/linux/commit/35f50c91c43e > [3/11] KVM: selftests: Add a macro to iterate over a sparsebit range > https://github.com/kvm-x86/linux/commit/57e19f057758 > [4/11] KVM: selftests: Add support for allocating/managing protected guest memory > https://github.com/kvm-x86/linux/commit/cd8eb2913205 > [5/11] KVM: selftests: Add support for protected vm_vaddr_* allocations > https://github.com/kvm-x86/linux/commit/d210eebb51a2 > [6/11] KVM: selftests: Explicitly ucall pool from shared memory > https://github.com/kvm-x86/linux/commit/31e00dae72fd > [7/11] KVM: selftests: Allow tagging protected memory in guest page tables > https://github.com/kvm-x86/linux/commit/bf47e87c65be > [8/11] KVM: selftests: Add library for creating and interacting with SEV guests > https://github.com/kvm-x86/linux/commit/bdceeebcddb8 > [9/11] KVM: selftests: Use the SEV library APIs in the intra-host migration test > https://github.com/kvm-x86/linux/commit/8b174eb9d289 > [10/11] KVM: selftests: Add a basic SEV smoke test > https://github.com/kvm-x86/linux/commit/faa0d7027de3 > [11/11] KVM: selftests: Add a basic SEV-ES smoke test > https://github.com/kvm-x86/linux/commit/974ba6f0e595 That didn't last long. I forgot that I needed to change the include guards in kvm_util_arch.h. New-new hashes: [1/11] KVM: selftests: Extend VM creation's @shape to allow control of VM subtype https://github.com/kvm-x86/linux/commit/126190379c57 [2/11] KVM: selftests: Make sparsebit structs const where appropriate https://github.com/kvm-x86/linux/commit/35f50c91c43e [3/11] KVM: selftests: Add a macro to iterate over a sparsebit range https://github.com/kvm-x86/linux/commit/57e19f057758 [4/11] KVM: selftests: Add support for allocating/managing protected guest memory https://github.com/kvm-x86/linux/commit/cd8eb2913205 [5/11] KVM: selftests: Add support for protected vm_vaddr_* allocations https://github.com/kvm-x86/linux/commit/d210eebb51a2 [6/11] KVM: selftests: Explicitly ucall pool from shared memory https://github.com/kvm-x86/linux/commit/31e00dae72fd [7/11] KVM: selftests: Allow tagging protected memory in guest page tables https://github.com/kvm-x86/linux/commit/be1bd4c5394f [8/11] KVM: selftests: Add library for creating and interacting with SEV guests https://github.com/kvm-x86/linux/commit/ae20eef5323c [9/11] KVM: selftests: Use the SEV library APIs in the intra-host migration test https://github.com/kvm-x86/linux/commit/69f8e15ab61f [10/11] KVM: selftests: Add a basic SEV smoke test https://github.com/kvm-x86/linux/commit/be250ff437fa [11/11] KVM: selftests: Add a basic SEV-ES smoke test https://github.com/kvm-x86/linux/commit/40e09b3ccfac
Add basic SEV and SEV-ES smoke tests. Unlike the intra-host migration tests, this one actually runs a small chunk of code in the guest. Unless anyone strongly objects to the quick and dirty approach I've taken for SEV-ES, I'll get all of this queued for 6.9 soon-ish. As for _why_ I added the quick-and-dirty SEV-ES testcase, I have a series to cleanup __svm_sev_es_vcpu_run(), and found out that apparently I have a version of OVMF that doesn't quite have to the right <something> for SEV-ES, and so I could even get a "real" VM to reach KVM_RUN. I assumed (correctly, yay!) that hacking together a selftest would be faster than figuring out what firmware magic I am missing. v9: - Drop is_kvm_sev_supported() and rely purely on KVM capabilities. - Check X86_FEATURE_SEV to ensure SEV is actually enabled. - Collect tags. [Carlos, Itaru] v8: - https://lore.kernel.org/all/cc9a1951-e76c-470d-a4d1-8ad67bae5794@amd.com - Undo the kvm.h uAPI breakage. - Take advantage of "struct vm_shape", introduced by the guest_memfd selftests, to simply tracking the SEV/SEV-ES subtypes. - Rename the test to "sev_smoke_test" instead of "sev_all_boot_test", as the "all" is rather nonsensical, and the test isn't booting anything in the traditional sense of the word. - Drop vm->protected and instead add an arch hook to query if the VM has protected memory. - Assert that the target memory region supports protected memory when allocating protected memory. - Allocate protected_phy_pages for memory regions if and only if the VM supports protected memory. - Rename kvm_host.h to kvm_util_arch.h, and move it to selftests/kvm where it belongs. - Fix up some SoB goofs. - Convert the intrahost SEV/SEV-ES migration tests to use common ioctl() wrappers. Ackerley Tng (1): KVM: selftests: Add a macro to iterate over a sparsebit range Michael Roth (2): KVM: selftests: Make sparsebit structs const where appropriate KVM: selftests: Add support for protected vm_vaddr_* allocations Peter Gonda (5): KVM: selftests: Add support for allocating/managing protected guest memory KVM: selftests: Explicitly ucall pool from shared memory KVM: selftests: Allow tagging protected memory in guest page tables KVM: selftests: Add library for creating and interacting with SEV guests KVM: selftests: Add a basic SEV smoke test Sean Christopherson (3): KVM: selftests: Extend VM creation's @shape to allow control of VM subtype KVM: selftests: Use the SEV library APIs in the intra-host migration test KVM: selftests: Add a basic SEV-ES smoke test tools/testing/selftests/kvm/Makefile | 2 + .../kvm/include/aarch64/kvm_util_arch.h | 7 ++ .../selftests/kvm/include/kvm_util_base.h | 50 +++++++- .../kvm/include/riscv/kvm_util_arch.h | 7 ++ .../kvm/include/s390x/kvm_util_arch.h | 7 ++ .../testing/selftests/kvm/include/sparsebit.h | 56 ++++++--- .../kvm/include/x86_64/kvm_util_arch.h | 23 ++++ .../selftests/kvm/include/x86_64/processor.h | 8 ++ .../selftests/kvm/include/x86_64/sev.h | 107 ++++++++++++++++ tools/testing/selftests/kvm/lib/kvm_util.c | 67 ++++++++-- tools/testing/selftests/kvm/lib/sparsebit.c | 48 ++++---- .../testing/selftests/kvm/lib/ucall_common.c | 3 +- .../selftests/kvm/lib/x86_64/processor.c | 32 ++++- tools/testing/selftests/kvm/lib/x86_64/sev.c | 114 ++++++++++++++++++ .../selftests/kvm/x86_64/sev_migrate_tests.c | 67 ++++------ .../selftests/kvm/x86_64/sev_smoke_test.c | 88 ++++++++++++++ 16 files changed, 583 insertions(+), 103 deletions(-) create mode 100644 tools/testing/selftests/kvm/include/aarch64/kvm_util_arch.h create mode 100644 tools/testing/selftests/kvm/include/riscv/kvm_util_arch.h create mode 100644 tools/testing/selftests/kvm/include/s390x/kvm_util_arch.h create mode 100644 tools/testing/selftests/kvm/include/x86_64/kvm_util_arch.h create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev.h create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev.c create mode 100644 tools/testing/selftests/kvm/x86_64/sev_smoke_test.c base-commit: 60eedcfceda9db46f1b333e5e1aa9359793f04fb