| Message ID | 20240307122840.3682287-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | [v1,1/1] PCI: dwc: Remove unused of_gpio.h | expand |
On Thu, Mar 07, 2024 at 02:28:40PM +0200, Andy Shevchenko wrote: > of_gpio.h is deprecated and subject to remove. > The driver doesn't use it, simply remove the unused header. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/pci/controller/dwc/pci-dra7xx.c | 1 - > drivers/pci/controller/dwc/pci-meson.c | 1 - > drivers/pci/controller/dwc/pcie-qcom.c | 1 - > drivers/pci/controller/dwc/pcie-tegra194.c | 2 -- What about the rest? drivers/pci/controller/dwc/pcie-kirin.c drivers/pci/controller/dwc/pci-imx6.c There is also one non-dwc driver: drivers/pci/controller/pci-aardvark.c It is better to remove it from all PCI drivers in a single patch. - Mani > 4 files changed, 5 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c > index 0e406677060d..f6d2ba42958b 100644 > --- a/drivers/pci/controller/dwc/pci-dra7xx.c > +++ b/drivers/pci/controller/dwc/pci-dra7xx.c > @@ -17,7 +17,6 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/of.h> > -#include <linux/of_gpio.h> > #include <linux/of_pci.h> > #include <linux/pci.h> > #include <linux/phy/phy.h> > diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c > index 6477c83262c2..db9482a113e9 100644 > --- a/drivers/pci/controller/dwc/pci-meson.c > +++ b/drivers/pci/controller/dwc/pci-meson.c > @@ -9,7 +9,6 @@ > #include <linux/clk.h> > #include <linux/delay.h> > #include <linux/gpio/consumer.h> > -#include <linux/of_gpio.h> > #include <linux/pci.h> > #include <linux/platform_device.h> > #include <linux/reset.h> > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 2ce2a3bd932b..0084a3390040 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -20,7 +20,6 @@ > #include <linux/kernel.h> > #include <linux/init.h> > #include <linux/of.h> > -#include <linux/of_gpio.h> > #include <linux/pci.h> > #include <linux/pm_runtime.h> > #include <linux/platform_device.h> > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index 1f7b662cb8e1..633d8dc50339 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -13,7 +13,6 @@ > #include <linux/clk.h> > #include <linux/debugfs.h> > #include <linux/delay.h> > -#include <linux/gpio.h> > #include <linux/gpio/consumer.h> > #include <linux/interconnect.h> > #include <linux/interrupt.h> > @@ -21,7 +20,6 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/of.h> > -#include <linux/of_gpio.h> > #include <linux/of_pci.h> > #include <linux/pci.h> > #include <linux/phy/phy.h> > -- > 2.43.0.rc1.1.gbec44491f096 >
On Fri, Mar 08, 2024 at 03:25:47PM +0530, Manivannan Sadhasivam wrote: > On Thu, Mar 07, 2024 at 02:28:40PM +0200, Andy Shevchenko wrote: > > of_gpio.h is deprecated and subject to remove. > > The driver doesn't use it, simply remove the unused header. > What about the rest? > > drivers/pci/controller/dwc/pcie-kirin.c > drivers/pci/controller/dwc/pci-imx6.c Have you chance to look at them? > There is also one non-dwc driver: > > drivers/pci/controller/pci-aardvark.c Keyword: non-dwc. This patch is for DesignWare controllers that confirmed not using the header. > It is better to remove it from all PCI drivers in a single patch. I disagree on this. These are different drivers and even inside DesignWare not all of them can be converted with a simple change like this one. That said, please consider applying this one as is.
On Fri, Mar 08, 2024 at 02:09:25PM +0200, Andy Shevchenko wrote: > On Fri, Mar 08, 2024 at 03:25:47PM +0530, Manivannan Sadhasivam wrote: > > On Thu, Mar 07, 2024 at 02:28:40PM +0200, Andy Shevchenko wrote: > > > of_gpio.h is deprecated and subject to remove. > > > The driver doesn't use it, simply remove the unused header. > > > What about the rest? > > > > drivers/pci/controller/dwc/pcie-kirin.c > > drivers/pci/controller/dwc/pci-imx6.c > > Have you chance to look at them? > Ok. I failed to spot the usage of of_get_named_gpio() in both drivers. But you already submitted a patch to convert kirin last year [1], and that didn't get any love from the maintainers. Could you please respin? Perhaps convert imx6 also? [1] https://lore.kernel.org/all/20230213180735.42117-1-andriy.shevchenko@linux.intel.com/ > > There is also one non-dwc driver: > > > > drivers/pci/controller/pci-aardvark.c > > Keyword: non-dwc. > This patch is for DesignWare controllers that confirmed not using the header. > > > It is better to remove it from all PCI drivers in a single patch. > > I disagree on this. These are different drivers and even inside DesignWare not > all of them can be converted with a simple change like this one. > Since this is just a header removal I thought you can just send a single patch for these drivers since there is nothing special that warrants a separate patch for aardvark (both are inside the drivers/pci/ hierarchy). But anyway, I wouldn't press for it. > That said, please consider applying this one as is. > I can give my R-o-b tag, but Lorenzo or Krzysztof will apply this. Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani
On Fri, Mar 08, 2024 at 10:40:29PM +0530, Manivannan Sadhasivam wrote: > On Fri, Mar 08, 2024 at 02:09:25PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 08, 2024 at 03:25:47PM +0530, Manivannan Sadhasivam wrote: > > > On Thu, Mar 07, 2024 at 02:28:40PM +0200, Andy Shevchenko wrote: > > > > of_gpio.h is deprecated and subject to remove. > > > > The driver doesn't use it, simply remove the unused header. > > > > > What about the rest? > > > > > > drivers/pci/controller/dwc/pcie-kirin.c > > > drivers/pci/controller/dwc/pci-imx6.c > > > > Have you chance to look at them? > > Ok. I failed to spot the usage of of_get_named_gpio() in both drivers. But you > already submitted a patch to convert kirin last year [1], and that didn't get > any love from the maintainers. Could you please respin? Sure. > Perhaps convert imx6 also? I'll look at it, if it's easy enough, why not, otherwise let it rotten for a while. > [1] https://lore.kernel.org/all/20230213180735.42117-1-andriy.shevchenko@linux.intel.com/ > > > > There is also one non-dwc driver: > > > > > > drivers/pci/controller/pci-aardvark.c > > > > Keyword: non-dwc. > > This patch is for DesignWare controllers that confirmed not using the header. > > > > > It is better to remove it from all PCI drivers in a single patch. > > > > I disagree on this. These are different drivers and even inside DesignWare not > > all of them can be converted with a simple change like this one. > > > > Since this is just a header removal I thought you can just send a single patch > for these drivers since there is nothing special that warrants a separate patch > for aardvark (both are inside the drivers/pci/ hierarchy). I'll look at aadvark as well, I dunno if it's simple removal enough there. > But anyway, I wouldn't press for it. > > > That said, please consider applying this one as is. > > I can give my R-o-b tag, but Lorenzo or Krzysztof will apply this. > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thank you!
diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 0e406677060d..f6d2ba42958b 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -17,7 +17,6 @@ #include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_gpio.h> #include <linux/of_pci.h> #include <linux/pci.h> #include <linux/phy/phy.h> diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c index 6477c83262c2..db9482a113e9 100644 --- a/drivers/pci/controller/dwc/pci-meson.c +++ b/drivers/pci/controller/dwc/pci-meson.c @@ -9,7 +9,6 @@ #include <linux/clk.h> #include <linux/delay.h> #include <linux/gpio/consumer.h> -#include <linux/of_gpio.h> #include <linux/pci.h> #include <linux/platform_device.h> #include <linux/reset.h> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 2ce2a3bd932b..0084a3390040 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -20,7 +20,6 @@ #include <linux/kernel.h> #include <linux/init.h> #include <linux/of.h> -#include <linux/of_gpio.h> #include <linux/pci.h> #include <linux/pm_runtime.h> #include <linux/platform_device.h> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index 1f7b662cb8e1..633d8dc50339 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -13,7 +13,6 @@ #include <linux/clk.h> #include <linux/debugfs.h> #include <linux/delay.h> -#include <linux/gpio.h> #include <linux/gpio/consumer.h> #include <linux/interconnect.h> #include <linux/interrupt.h> @@ -21,7 +20,6 @@ #include <linux/kernel.h> #include <linux/module.h> #include <linux/of.h> -#include <linux/of_gpio.h> #include <linux/of_pci.h> #include <linux/pci.h> #include <linux/phy/phy.h>
of_gpio.h is deprecated and subject to remove. The driver doesn't use it, simply remove the unused header. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pci/controller/dwc/pci-dra7xx.c | 1 - drivers/pci/controller/dwc/pci-meson.c | 1 - drivers/pci/controller/dwc/pcie-qcom.c | 1 - drivers/pci/controller/dwc/pcie-tegra194.c | 2 -- 4 files changed, 5 deletions(-)