diff mbox series

[v8,1/8] cpufreq: amd-pstate: Document *_limit_* fields in struct amd_cpudata

Message ID 0988fb808bf358c98f6ae8ad8f65cb0c7e1129b3.1710754409.git.perry.yuan@amd.com (mailing list archive)
State Changes Requested, archived
Headers show
Series AMD Pstate Fixes And Enhancements | expand

Commit Message

Yuan, Perry March 18, 2024, 9:48 a.m. UTC
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>

Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
---
 include/linux/amd-pstate.h | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Rafael J. Wysocki March 18, 2024, 12:34 p.m. UTC | #1
On Mon, Mar 18, 2024 at 10:48 AM Perry Yuan <perry.yuan@amd.com> wrote:
>
> From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>

No changelog.

> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

Sender sign-off missing (when sending a somebody else's patch, you
need to add your S-o-b tag to it).

> ---
>  include/linux/amd-pstate.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index d21838835abd..212f377d615b 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -49,6 +49,10 @@ struct amd_aperf_mperf {
>   * @lowest_perf: the absolute lowest performance level of the processor
>   * @prefcore_ranking: the preferred core ranking, the higher value indicates a higher
>   *               priority.
> + * @min_limit_perf: Cached value of the perf corresponding to policy->min
> + * @max_limit_perf: Cached value of the perf corresponding to policy->max
> + * @min_limit_freq: Cached value of policy->min
> + * @max_limit_freq: Cached value of policy->max
>   * @max_freq: the frequency that mapped to highest_perf
>   * @min_freq: the frequency that mapped to lowest_perf
>   * @nominal_freq: the frequency that mapped to nominal_perf
> --
> 2.34.1
>
>
Yuan, Perry March 19, 2024, 8:03 a.m. UTC | #2
[AMD Official Use Only - General]

Hi Rafael,

> -----Original Message-----
> From: Rafael J. Wysocki <rafael@kernel.org>
> Sent: Monday, March 18, 2024 8:35 PM
> To: Yuan, Perry <Perry.Yuan@amd.com>
> Cc: rafael.j.wysocki@intel.com; Limonciello, Mario
> <Mario.Limonciello@amd.com>; viresh.kumar@linaro.org; Huang, Ray
> <Ray.Huang@amd.com>; Shenoy, Gautham Ranjal
> <gautham.shenoy@amd.com>; Petkov, Borislav <Borislav.Petkov@amd.com>;
> Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Shimmer
> <Shimmer.Huang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>; Meng,
> Li (Jassmine) <Li.Meng@amd.com>; linux-pm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v8 1/8] cpufreq: amd-pstate: Document *_limit_* fields in
> struct amd_cpudata
>
> On Mon, Mar 18, 2024 at 10:48 AM Perry Yuan <perry.yuan@amd.com>
> wrote:
> >
> > From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
>
> No changelog.
>
> > Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
>
> Sender sign-off missing (when sending a somebody else's patch, you need to
> add your S-o-b tag to it).


Got it,  will fix this and other two patches flags missing in V9.
Thank you for the feedback.

Perry.


>
> > ---
> >  include/linux/amd-pstate.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> > index d21838835abd..212f377d615b 100644
> > --- a/include/linux/amd-pstate.h
> > +++ b/include/linux/amd-pstate.h
> > @@ -49,6 +49,10 @@ struct amd_aperf_mperf {
> >   * @lowest_perf: the absolute lowest performance level of the processor
> >   * @prefcore_ranking: the preferred core ranking, the higher value indicates
> a higher
> >   *               priority.
> > + * @min_limit_perf: Cached value of the perf corresponding to
> > + policy->min
> > + * @max_limit_perf: Cached value of the perf corresponding to
> > + policy->max
> > + * @min_limit_freq: Cached value of policy->min
> > + * @max_limit_freq: Cached value of policy->max
> >   * @max_freq: the frequency that mapped to highest_perf
> >   * @min_freq: the frequency that mapped to lowest_perf
> >   * @nominal_freq: the frequency that mapped to nominal_perf
> > --
> > 2.34.1
> >
> >
diff mbox series

Patch

diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
index d21838835abd..212f377d615b 100644
--- a/include/linux/amd-pstate.h
+++ b/include/linux/amd-pstate.h
@@ -49,6 +49,10 @@  struct amd_aperf_mperf {
  * @lowest_perf: the absolute lowest performance level of the processor
  * @prefcore_ranking: the preferred core ranking, the higher value indicates a higher
  * 		  priority.
+ * @min_limit_perf: Cached value of the perf corresponding to policy->min
+ * @max_limit_perf: Cached value of the perf corresponding to policy->max
+ * @min_limit_freq: Cached value of policy->min
+ * @max_limit_freq: Cached value of policy->max
  * @max_freq: the frequency that mapped to highest_perf
  * @min_freq: the frequency that mapped to lowest_perf
  * @nominal_freq: the frequency that mapped to nominal_perf