| Message ID | 20240402183240.49193-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] arm64: dts: marvell: eDPU: drop redundant address/size-cells | expand |
On Tue, Apr 02, 2024 at 08:32:38PM +0200, Krzysztof Kozlowski wrote: > The ethernet-switch node does not have children with unit addresses, so > address/size-cells are not really correct, as reported by dtc W=1 > warning: > > armada-3720-eDPU.dts:26.19-60.4: Warning (avoid_unnecessary_addr_size): /soc/internal-regs@d0000000/mdio@32004/switch@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > This probably also fixes dtbs_check warning, but I could not find it, so > not sure about that. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Krzysztof Kozlowski <krzk@kernel.org> writes: > The ethernet-switch node does not have children with unit addresses, so > address/size-cells are not really correct, as reported by dtc W=1 > warning: > > armada-3720-eDPU.dts:26.19-60.4: Warning (avoid_unnecessary_addr_size): /soc/internal-regs@d0000000/mdio@32004/switch@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > This probably also fixes dtbs_check warning, but I could not find it, so > not sure about that. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Applied on mvebu/dt64 as well as the 2 other pacthes. Thanks, Gregory > --- > arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts > index d6d37a1f6f38..91c2f8b4edfa 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts > @@ -25,8 +25,6 @@ &mdio { > /* Actual device is MV88E6361 */ > switch: switch@0 { > compatible = "marvell,mv88e6190"; > - #address-cells = <1>; > - #size-cells = <0>; > reg = <0>; > status = "disabled"; > > -- > 2.34.1
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts index d6d37a1f6f38..91c2f8b4edfa 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts @@ -25,8 +25,6 @@ &mdio { /* Actual device is MV88E6361 */ switch: switch@0 { compatible = "marvell,mv88e6190"; - #address-cells = <1>; - #size-cells = <0>; reg = <0>; status = "disabled";
The ethernet-switch node does not have children with unit addresses, so address/size-cells are not really correct, as reported by dtc W=1 warning: armada-3720-eDPU.dts:26.19-60.4: Warning (avoid_unnecessary_addr_size): /soc/internal-regs@d0000000/mdio@32004/switch@0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property This probably also fixes dtbs_check warning, but I could not find it, so not sure about that. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 2 -- 1 file changed, 2 deletions(-)