| Message ID | 20240312020000.12992-8-salil.mehta@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add architecture agnostic code to support vCPU Hotplug | expand |
Hi Salil, On 12-03-2024 07:29, Salil Mehta wrote: > Add common function to help unregister the GDB register space. This shall be > done in context to the CPU unrealization. > > Signed-off-by: Salil Mehta<salil.mehta@huawei.com> > Tested-by: Vishnu Pajjuri<vishnu@os.amperecomputing.com> > Reviewed-by: Gavin Shan<gshan@redhat.com> > Tested-by: Xianglai Li<lixianglai@loongson.cn> > Tested-by: Miguel Luis<miguel.luis@oracle.com> > Reviewed-by: Shaoqin Huang<shahuang@redhat.com> > --- > gdbstub/gdbstub.c | 12 ++++++++++++ > include/exec/gdbstub.h | 6 ++++++ > 2 files changed, 18 insertions(+) > > diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c > index 17efcae0d0..a8449dc309 100644 > --- a/gdbstub/gdbstub.c > +++ b/gdbstub/gdbstub.c > @@ -615,6 +615,18 @@ void gdb_register_coprocessor(CPUState *cpu, > } > } > > +void gdb_unregister_coprocessor_all(CPUState *cpu) > +{ > + /* > + * Safe to nuke everything. GDBRegisterState::xml is static const char so > + * it won't be freed > + */ > + g_array_free(cpu->gdb_regs, true); > + > + cpu->gdb_regs = NULL; > + cpu->gdb_num_g_regs = 0; Likewise, you may need to set gdb_num_regs to zero as well. > +} > + > static void gdb_process_breakpoint_remove_all(GDBProcess *p) > { > CPUState *cpu = gdb_get_first_cpu_in_process(p); > diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h > index eb14b91139..249d4d4bc8 100644 > --- a/include/exec/gdbstub.h > +++ b/include/exec/gdbstub.h > @@ -49,6 +49,12 @@ void gdb_register_coprocessor(CPUState *cpu, > gdb_get_reg_cb get_reg, gdb_set_reg_cb set_reg, > const GDBFeature *feature, int g_pos); > > +/** > + * gdb_unregister_coprocessor_all() - unregisters supplemental set of registers > + * @cpu - the CPU associated with registers > + */ > +void gdb_unregister_coprocessor_all(CPUState *cpu); > + > /** > * gdbserver_start: start the gdb server > * @port_or_device: connection spec for gdb Otherwise, Looks good to me. Feel free to add Reviewed-by: "Vishnu Pajjuri" <vishnu@os.amperecomputing.com> _Regards_, -Vishnu
Hi Vishnu, Sorry for the delay in reply. Still catching up. > From: Vishnu Pajjuri <vishnu@amperemail.onmicrosoft.com> > Sent: Thursday, April 4, 2024 3:02 PM > To: Salil Mehta <salil.mehta@huawei.com>; qemu-devel@nongnu.org; qemu-arm@nongnu.org > > Hi Salil, > On 12-03-2024 07:29, Salil Mehta wrote: >> Add common function to help unregister the GDB register space. This shall be >> done in context to the CPU unrealization. >> >> Signed-off-by: Salil Mehta mailto:salil.mehta@huawei.com >> Tested-by: Vishnu Pajjuri mailto:vishnu@os.amperecomputing.com >> Reviewed-by: Gavin Shan mailto:gshan@redhat.com >> Tested-by: Xianglai Li mailto:lixianglai@loongson.cn >> Tested-by: Miguel Luis mailto:miguel.luis@oracle.com >> Reviewed-by: Shaoqin Huang mailto:shahuang@redhat.com >> --- >> gdbstub/gdbstub.c> | 12 ++++++++++++ >> include/exec/gdbstub.h | 6 ++++++ >> 2 files changed, 18 insertions(+) >> >> diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c >> index 17efcae0d0..a8449dc309 100644 >> --- a/gdbstub/gdbstub.c >> +++ b/gdbstub/gdbstub.c >> @@ -615,6 +615,18 @@ void gdb_register_coprocessor(CPUState *cpu, >> } >> } >> >> +void gdb_unregister_coprocessor_all(CPUState *cpu) >> +{ >> + /* >> + * Safe to nuke everything. GDBRegisterState::xml is static const char so >> + * it won't be freed >> + */ >> + g_array_free(cpu->gdb_regs, true); >> + >> + cpu->gdb_regs = NULL; >> + cpu->gdb_num_g_regs = 0; > Likewise, you may need to set gdb_num_regs to zero as well. Sure, thanks. >> +} >> + >> static void gdb_process_breakpoint_remove_all(GDBProcess *p) >> { >> CPUState *cpu = gdb_get_first_cpu_in_process(p); >> diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h >> index eb14b91139..249d4d4bc8 100644 >> --- a/include/exec/gdbstub.h >> +++ b/include/exec/gdbstub.h >> @@ -49,6 +49,12 @@ void gdb_register_coprocessor(CPUState *cpu, >> > > > > > gdb_get_reg_cb get_reg, gdb_set_reg_cb set_reg, >> > > > > > const GDBFeature *feature, int g_pos); >> >> +/** >> + * gdb_unregister_coprocessor_all() - unregisters supplemental set of registers >> + * @cpu - the CPU associated with registers >> + */ >> +void gdb_unregister_coprocessor_all(CPUState *cpu); >> + >> /** >> * gdbserver_start: start the gdb server >> * @port_or_device: connection spec for gdb >> Otherwise, Looks good to me. Feel free to add >> Reviewed-by: "Vishnu Pajjuri" mailto:vishnu@os.amperecomputing.com Thanks Salil. >> Regards, >> -Vishnu
diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 17efcae0d0..a8449dc309 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -615,6 +615,18 @@ void gdb_register_coprocessor(CPUState *cpu, } } +void gdb_unregister_coprocessor_all(CPUState *cpu) +{ + /* + * Safe to nuke everything. GDBRegisterState::xml is static const char so + * it won't be freed + */ + g_array_free(cpu->gdb_regs, true); + + cpu->gdb_regs = NULL; + cpu->gdb_num_g_regs = 0; +} + static void gdb_process_breakpoint_remove_all(GDBProcess *p) { CPUState *cpu = gdb_get_first_cpu_in_process(p); diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h index eb14b91139..249d4d4bc8 100644 --- a/include/exec/gdbstub.h +++ b/include/exec/gdbstub.h @@ -49,6 +49,12 @@ void gdb_register_coprocessor(CPUState *cpu, gdb_get_reg_cb get_reg, gdb_set_reg_cb set_reg, const GDBFeature *feature, int g_pos); +/** + * gdb_unregister_coprocessor_all() - unregisters supplemental set of registers + * @cpu - the CPU associated with registers + */ +void gdb_unregister_coprocessor_all(CPUState *cpu); + /** * gdbserver_start: start the gdb server * @port_or_device: connection spec for gdb