| Message ID | 20240411133832.2896463-18-avromanov@salutedevices.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Support more Amlogic SoC families in crypto driver | expand |
On Thu, Apr 11, 2024 at 04:38:26PM +0300, Alexey Romanov wrote: > GXL crypto IP isn't connected to clk and seconnd interrput line, > so we must remove them from dt-bindings. How does the device work without a clock? Cheers, Conor. > > Fixes: 7f7d115dfb51 ("dt-bindings: crypto: Add DT bindings > documentation for amlogic-crypto") > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > --- > .../bindings/crypto/amlogic,gxl-crypto.yaml | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > index 948e11ebe4ee..d3af7b4d5f39 100644 > --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > @@ -20,20 +20,11 @@ properties: > interrupts: > items: > - description: Interrupt for flow 0 > - - description: Interrupt for flow 1 > - > - clocks: > - maxItems: 1 > - > - clock-names: > - const: blkmv > > required: > - compatible > - reg > - interrupts > - - clocks > - - clock-names > > additionalProperties: false > > @@ -46,7 +37,5 @@ examples: > crypto: crypto-engine@c883e000 { > compatible = "amlogic,gxl-crypto"; > reg = <0xc883e000 0x36>; > - interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>, <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>; > - clocks = <&clkc CLKID_BLKMV>; > - clock-names = "blkmv"; > + interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>; > }; > -- > 2.34.1 >
On Mon, Apr 15, 2024 at 05:43:15PM +0100, Conor Dooley wrote: > On Thu, Apr 11, 2024 at 04:38:26PM +0300, Alexey Romanov wrote: > > GXL crypto IP isn't connected to clk and seconnd interrput line, > > so we must remove them from dt-bindings. > > How does the device work without a clock? It's clocked by a common clock, the vendor didn't provide more information. It doesn't have any special clock domains. > > Cheers, > Conor. > > > > > Fixes: 7f7d115dfb51 ("dt-bindings: crypto: Add DT bindings > > documentation for amlogic-crypto") > > > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > > --- > > .../bindings/crypto/amlogic,gxl-crypto.yaml | 13 +------------ > > 1 file changed, 1 insertion(+), 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > > index 948e11ebe4ee..d3af7b4d5f39 100644 > > --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > > +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > > @@ -20,20 +20,11 @@ properties: > > interrupts: > > items: > > - description: Interrupt for flow 0 > > - - description: Interrupt for flow 1 > > - > > - clocks: > > - maxItems: 1 > > - > > - clock-names: > > - const: blkmv > > > > required: > > - compatible > > - reg > > - interrupts > > - - clocks > > - - clock-names > > > > additionalProperties: false > > > > @@ -46,7 +37,5 @@ examples: > > crypto: crypto-engine@c883e000 { > > compatible = "amlogic,gxl-crypto"; > > reg = <0xc883e000 0x36>; > > - interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>, <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>; > > - clocks = <&clkc CLKID_BLKMV>; > > - clock-names = "blkmv"; > > + interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>; > > }; > > -- > > 2.34.1 > >
On Mon, May 06, 2024 at 01:48:01PM +0000, Alexey Romanov wrote: > On Mon, Apr 15, 2024 at 05:43:15PM +0100, Conor Dooley wrote: > > On Thu, Apr 11, 2024 at 04:38:26PM +0300, Alexey Romanov wrote: > > > GXL crypto IP isn't connected to clk and seconnd interrput line, > > > so we must remove them from dt-bindings. > > > > How does the device work without a clock? > > It's clocked by a common clock, the vendor didn't provide more > information. It doesn't have any special clock domains. So the hardware block does have a clock, which, even if it is a clock shared with other hardware blocks, makes your patch incorrect. Is the "blkmv" clock the shared clock? Cheers, Conor. > > > Fixes: 7f7d115dfb51 ("dt-bindings: crypto: Add DT bindings > > > documentation for amlogic-crypto") > > > > > > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> > > > --- > > > .../bindings/crypto/amlogic,gxl-crypto.yaml | 13 +------------ > > > 1 file changed, 1 insertion(+), 12 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > > > index 948e11ebe4ee..d3af7b4d5f39 100644 > > > --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > > > +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml > > > @@ -20,20 +20,11 @@ properties: > > > interrupts: > > > items: > > > - description: Interrupt for flow 0 > > > - - description: Interrupt for flow 1 > > > - > > > - clocks: > > > - maxItems: 1 > > > - > > > - clock-names: > > > - const: blkmv > > > > > > required: > > > - compatible > > > - reg > > > - interrupts > > > - - clocks > > > - - clock-names > > > > > > additionalProperties: false > > > > > > @@ -46,7 +37,5 @@ examples: > > > crypto: crypto-engine@c883e000 { > > > compatible = "amlogic,gxl-crypto"; > > > reg = <0xc883e000 0x36>; > > > - interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>, <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>; > > > - clocks = <&clkc CLKID_BLKMV>; > > > - clock-names = "blkmv"; > > > + interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>; > > > }; > > > -- > > > 2.34.1 > > > > > > > > -- > Thank you, > Alexey
diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml index 948e11ebe4ee..d3af7b4d5f39 100644 --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml @@ -20,20 +20,11 @@ properties: interrupts: items: - description: Interrupt for flow 0 - - description: Interrupt for flow 1 - - clocks: - maxItems: 1 - - clock-names: - const: blkmv required: - compatible - reg - interrupts - - clocks - - clock-names additionalProperties: false @@ -46,7 +37,5 @@ examples: crypto: crypto-engine@c883e000 { compatible = "amlogic,gxl-crypto"; reg = <0xc883e000 0x36>; - interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>, <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>; - clocks = <&clkc CLKID_BLKMV>; - clock-names = "blkmv"; + interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>; };
GXL crypto IP isn't connected to clk and seconnd interrput line, so we must remove them from dt-bindings. Fixes: 7f7d115dfb51 ("dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto") Signed-off-by: Alexey Romanov <avromanov@salutedevices.com> --- .../bindings/crypto/amlogic,gxl-crypto.yaml | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-)