diff mbox series

dt-bindings: net: nxp,dwmac-imx: allow nvmem cells property

Message ID 20240415103621.1644735-1-peng.fan@oss.nxp.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: net: nxp,dwmac-imx: allow nvmem cells property | expand

Commit Message

Peng Fan (OSS) April 15, 2024, 10:36 a.m. UTC
From: Peng Fan <peng.fan@nxp.com>

Allow nvmem-cells and nvmem-cell-names to get mac_address from onchip
fuse.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Frank Li April 15, 2024, 2:36 p.m. UTC | #1
On Mon, Apr 15, 2024 at 06:36:21PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Allow nvmem-cells and nvmem-cell-names to get mac_address from onchip
> fuse.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
>  Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> index 4c01cae7c93a..87bc4416eadf 100644
> --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> @@ -66,6 +66,10 @@ properties:
>        Should be phandle/offset pair. The phandle to the syscon node which
>        encompases the GPR register, and the offset of the GPR register.
>  
> +  nvmem-cells: true
> +
> +  nvmem-cell-names: true
> +
>    snps,rmii_refclk_ext:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> -- 
> 2.37.1
>
Conor Dooley April 15, 2024, 3:47 p.m. UTC | #2
On Mon, Apr 15, 2024 at 06:36:21PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Allow nvmem-cells and nvmem-cell-names to get mac_address from onchip
> fuse.

Is this valid for all 3 devices in this binding?

> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> index 4c01cae7c93a..87bc4416eadf 100644
> --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> @@ -66,6 +66,10 @@ properties:
>        Should be phandle/offset pair. The phandle to the syscon node which
>        encompases the GPR register, and the offset of the GPR register.
>  
> +  nvmem-cells: true
> +
> +  nvmem-cell-names: true
> +
>    snps,rmii_refclk_ext:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> -- 
> 2.37.1
>
Peng Fan April 16, 2024, 1:52 p.m. UTC | #3
> Subject: Re: [PATCH] dt-bindings: net: nxp,dwmac-imx: allow nvmem cells
> property
> 
> On Mon, Apr 15, 2024 at 06:36:21PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Allow nvmem-cells and nvmem-cell-names to get mac_address from onchip
> > fuse.
> 
> Is this valid for all 3 devices in this binding?

Yes. It is valid for all the three devices.

Thanks,
Peng.
> 
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> > b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> > index 4c01cae7c93a..87bc4416eadf 100644
> > --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> > +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> > @@ -66,6 +66,10 @@ properties:
> >        Should be phandle/offset pair. The phandle to the syscon node which
> >        encompases the GPR register, and the offset of the GPR register.
> >
> > +  nvmem-cells: true
> > +
> > +  nvmem-cell-names: true
> > +
> >    snps,rmii_refclk_ext:
> >      $ref: /schemas/types.yaml#/definitions/flag
> >      description:
> > --
> > 2.37.1
> >
Conor Dooley April 16, 2024, 2:35 p.m. UTC | #4
On Tue, Apr 16, 2024 at 01:52:18PM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] dt-bindings: net: nxp,dwmac-imx: allow nvmem cells
> > property
> > 
> > On Mon, Apr 15, 2024 at 06:36:21PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Allow nvmem-cells and nvmem-cell-names to get mac_address from onchip
> > > fuse.
> > 
> > Is this valid for all 3 devices in this binding?
> 
> Yes. It is valid for all the three devices.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Ty,
Conor.
patchwork-bot+netdevbpf@kernel.org April 17, 2024, 12:20 a.m. UTC | #5
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 15 Apr 2024 18:36:21 +0800 you wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Allow nvmem-cells and nvmem-cell-names to get mac_address from onchip
> fuse.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> 
> [...]

Here is the summary with links:
  - dt-bindings: net: nxp,dwmac-imx: allow nvmem cells property
    https://git.kernel.org/netdev/net-next/c/427f6acbc881

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
index 4c01cae7c93a..87bc4416eadf 100644
--- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
+++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
@@ -66,6 +66,10 @@  properties:
       Should be phandle/offset pair. The phandle to the syscon node which
       encompases the GPR register, and the offset of the GPR register.
 
+  nvmem-cells: true
+
+  nvmem-cell-names: true
+
   snps,rmii_refclk_ext:
     $ref: /schemas/types.yaml#/definitions/flag
     description: