diff mbox series

[v5] drm/i915: limit eDP MSO pipe only for display version 20 and below

Message ID 20240404091646.165309-1-luciano.coelho@intel.com (mailing list archive)
State New, archived
Headers show
Series [v5] drm/i915: limit eDP MSO pipe only for display version 20 and below | expand

Commit Message

Luca Coelho April 4, 2024, 9:16 a.m. UTC
The pipes that can be used for eDP MSO are limited to pipe A (and
sometimes also pipe B) only for display version 20 and below.

Modify the function that returns the pipe mask for eDP MSO so that
these limitations only apply to version 20 and below, enabling all
pipes otherwise.

Bspec: 68923
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: James Ausmus <james.ausmus@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---

In v5:
   * fixed Ville's name's wrong charset, which prevented patchwork
     from picking this up.

In v4:
   * actually go back to unrestricting only for > 20.  I sent the
     wrong patch version in v3.

In v3:
   * go back to unrestricing only for > 20, since the change for
     versions 14 to 20 should be tested separately;
   * simplify the if blocks [Ville].

In v2:
   * allow pipes A and B from ver 14 to 20 [Gustavo]

 drivers/gpu/drm/i915/display/intel_ddi.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Luca Coelho April 17, 2024, 7:19 a.m. UTC | #1
Hi,

The skip in igt@kms_cursor_legacy@basic-flip-before-cursor-atomic on
fi-rkl-11600 is not related to my patch.  There doesn't seem to be any
displays connected to that machine at the moment and all runs are
failing, for example the latest run with CI_DRM_14591.

Same thing with the other "new" skips.

Can you please mark my run as not really failing?

--
Cheers,
Luca.


On Tue, 2024-04-16 at 09:54 +0000, Patchwork wrote:
> Patch Details
> Series:drm/i915: limit eDP MSO pipe only for display version 20 and
> below (rev4)
> URL:https://patchwork.freedesktop.org/series/129123/
> State:failure
> Details:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/index.html
> CI Bug Log - changes from CI_DRM_14583 -> Patchwork_129123v4SummaryFAILURE
> Serious unknown changes coming with Patchwork_129123v4 absolutely
> need to be
> verified manually.
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_129123v4, please notify your bug team (I915-
> ci-infra@lists.freedesktop.org) to allow them
> to document this new failure mode, which will reduce false positives
> in CI.
> External URL: https://intel-gfx-ci.01.org/tree/drm-
> tip/Patchwork_129123v4/index.html
> Participating hosts (37 -> 33)Additional (4): bat-dg1-7 bat-kbl-2 fi-cfl-8109u bat-arls-2 
> Missing (8): fi-kbl-7567u fi-apl-guc fi-snb-2520m fi-glk-j4005 bat-
> atsm-1 fi-elk-e7500 bat-dg2-11 bat-mtlp-6 
> Possible new issuesHere are the unknown changes that may have been introduced in
> Patchwork_129123v4:
> IGT changesPossible regressions * igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:fi-rkl-11600:
>    PASS -> SKIP +5 other tests skip
>  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:fi-rkl-11600:
>    NOTRUN -> SKIP +11 other tests skip
> Warnings * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:fi-rkl-
>    11600: SKIP (i915#4103) -> SKIP +1 other test skip
>  * igt@kms_dsc@dsc-basic:fi-rkl-11600: SKIP (i915#3555 / i915#3840) ->
>    SKIP
> Known issuesHere are the changes found in Patchwork_129123v4 that come from known
> issues:
> IGT changesIssues hit * igt@debugfs_test@basic-hwmon:bat-arls-2: NOTRUN -> SKIP (i915#9318)
>  * igt@fbdev@eof:fi-rkl-11600: PASS -> SKIP (i915#2582) +3 other tests
>    skip
>  * igt@fbdev@info:fi-rkl-11600: PASS -> SKIP (i915#1849 /
>    i915#2582)bat-kbl-2: NOTRUN -> SKIP (i915#1849)
>  * igt@gem_huc_copy@huc-copy:fi-cfl-8109u: NOTRUN -> SKIP (i915#2190)
>  * igt@gem_lmem_swapping@parallel-random-engines:bat-kbl-2: NOTRUN ->
>    SKIP +39 other tests skip
>  * igt@gem_lmem_swapping@verify-random:fi-cfl-8109u: NOTRUN -> SKIP
>    (i915#4613) +3 other tests skipbat-arls-2: NOTRUN -> SKIP
>    (i915#10213) +3 other tests skip
>  * igt@gem_mmap@basic:bat-dg1-7: NOTRUN -> SKIP (i915#4083)bat-arls-2:
>    NOTRUN -> SKIP (i915#4083)
>  * igt@gem_mmap_gtt@basic:bat-arls-2: NOTRUN -> SKIP (i915#10196 /
>    i915#4077) +2 other tests skip
>  * igt@gem_render_tiled_blits@basic:bat-arls-2: NOTRUN -> SKIP
>    (i915#10197 / i915#10211 / i915#4079)
>  * igt@gem_tiled_fence_blits@basic:bat-dg1-7: NOTRUN -> SKIP
>    (i915#4077) +2 other tests skip
>  * igt@gem_tiled_pread_basic:bat-dg1-7: NOTRUN -> SKIP (i915#4079) +1
>    other test skipbat-arls-2: NOTRUN -> SKIP (i915#10206 / i915#4079)
>  * igt@i915_pm_rps@basic-api:bat-dg1-7: NOTRUN -> SKIP (i915#6621)bat-
>    arls-2: NOTRUN -> SKIP (i915#10209)
>  * igt@i915_selftest@live@hangcheck:bat-adls-6: NOTRUN -> DMESG-WARN
>    (i915#5591)
>  * igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:bat-dg1-7:
>    NOTRUN -> SKIP (i915#4212) +7 other tests skip
>  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:bat-arls-2: NOTRUN
>    -> SKIP (i915#10200) +9 other tests skip
>  * igt@kms_addfb_basic@basic-y-tiled-legacy:bat-dg1-7: NOTRUN -> SKIP
>    (i915#4215)
>  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:bat-arls-
>    2: NOTRUN -> SKIP (i915#10202) +1 other test skipbat-dg1-7: NOTRUN -
>    > SKIP (i915#4103 / i915#4213) +1 other test skip
>  * igt@kms_dsc@dsc-basic:bat-arls-2: NOTRUN -> SKIP (i915#9886)bat-dg1-
>    7: NOTRUN -> SKIP (i915#3555 / i915#3840)
>  * igt@kms_force_connector_basic@force-load-detect:bat-arls-2: NOTRUN -
>    > SKIP (i915#10207)bat-dg1-7: NOTRUN -> SKIP
>  * igt@kms_frontbuffer_tracking@basic:fi-rkl-11600: PASS -> SKIP
>    (i915#1849 / i915#5354)
>  * igt@kms_hdmi_inject@inject-audio:bat-dg1-7: NOTRUN -> SKIP
>    (i915#433)
>  * igt@kms_pm_backlight@basic-brightness:bat-dg1-7: NOTRUN -> SKIP
>    (i915#5354)fi-cfl-8109u: NOTRUN -> SKIP +11 other tests skip
>  * igt@kms_psr@psr-primary-mmap-gtt@edp-1:bat-arls-2: NOTRUN -> SKIP
>    (i915#10196 / i915#4077 / i915#9688)
>  * igt@kms_psr@psr-primary-page-flip:bat-dg1-7: NOTRUN -> SKIP
>    (i915#1072 / i915#9732) +3 other tests skip
>  * igt@kms_setmode@basic-clone-single-crtc:bat-arls-2: NOTRUN -> SKIP
>    (i915#10208 / i915#8809)bat-dg1-7: NOTRUN -> SKIP (i915#3555)
>  * igt@prime_vgem@basic-fence-flip:bat-dg1-7: NOTRUN -> SKIP
>    (i915#3708) +3 other tests skipfi-rkl-11600: PASS -> SKIP
>    (i915#3708)
>  * igt@prime_vgem@basic-fence-mmap:bat-dg1-7: NOTRUN -> SKIP (i915#3708
>    / i915#4077) +1 other test skipbat-arls-2: NOTRUN -> SKIP
>    (i915#10196 / i915#3708 / i915#4077) +1 other test skip
>  * igt@prime_vgem@basic-fence-read:bat-arls-2: NOTRUN -> SKIP
>    (i915#10212 / i915#3708)
>  * igt@prime_vgem@basic-read:bat-arls-2: NOTRUN -> SKIP (i915#10214 /
>    i915#3708)
>  * igt@prime_vgem@basic-write:bat-arls-2: NOTRUN -> SKIP (i915#10216 /
>    i915#3708)
> Possible fixes * igt@i915_selftest@live@active:bat-jsl-1: DMESG-FAIL (i915#10606) ->
>    PASS
>  * igt@i915_selftest@live@gt_engines:bat-adls-6: TIMEOUT (i915#10026) -
>    > PASS
> Build changes * Linux: CI_DRM_14583 -> Patchwork_129123v4
> CI-20190529: 20190529
> CI_DRM_14583: 5f7597e990bea547bd1261170497e7476fb781bb @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7806: 849cd963ce7e8222dcf17cc872d355181fd2c2a2 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_129123v4: 5f7597e990bea547bd1261170497e7476fb781bb @
> git://anongit.freedesktop.org/gfx-ci/linux
> Linux commitse67fc4d1ee3a drm/i915: limit eDP MSO pipe only for display version 20
> and below
Illipilli, TejasreeX April 17, 2024, 12:06 p.m. UTC | #2
Hi,

https://patchwork.freedesktop.org/series/129123/ - Re-reported.

Thanks,
Tejasree

From: I915-ci-infra <i915-ci-infra-bounces@lists.freedesktop.org> On Behalf Of Luca Coelho
Sent: Wednesday, April 17, 2024 12:49 PM
To: I915-ci-infra@lists.freedesktop.org
Cc: Coelho, Luciano <luciano.coelho@intel.com>; intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915: limit eDP MSO pipe only for display version 20 and below (rev4)

Hi,

The skip in igt@kms_cursor_legacy@basic-flip-before-cursor-atomic on fi-rkl-11600 is not related to my patch.  There doesn't seem to be any displays connected to that machine at the moment and all runs are failing, for example the latest run with CI_DRM_14591.

Same thing with the other "new" skips.

Can you please mark my run as not really failing?

--
Cheers,
Luca.


On Tue, 2024-04-16 at 09:54 +0000, Patchwork wrote:
Patch Details
Series:
drm/i915: limit eDP MSO pipe only for display version 20 and below (rev4)
URL:
https://patchwork.freedesktop.org/series/129123/
State:
failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/index.html
CI Bug Log - changes from CI_DRM_14583 -> Patchwork_129123v4
Summary

FAILURE

Serious unknown changes coming with Patchwork_129123v4 absolutely need to be
verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_129123v4, please notify your bug team (I915-ci-infra@lists.freedesktop.org<mailto:I915-ci-infra@lists.freedesktop.org>) to allow them
to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/index.html

Participating hosts (37 -> 33)

Additional (4): bat-dg1-7 bat-kbl-2 fi-cfl-8109u bat-arls-2
Missing (8): fi-kbl-7567u fi-apl-guc fi-snb-2520m fi-glk-j4005 bat-atsm-1 fi-elk-e7500 bat-dg2-11 bat-mtlp-6

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_129123v4:

IGT changes
Possible regressions

  *   igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:

     *   fi-rkl-11600: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14583/fi-rkl-11600/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-rkl-11600/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html> +5 other tests skip

  *   igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:

     *   fi-rkl-11600: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-rkl-11600/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html> +11 other tests skip

Warnings

  *   igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:

     *   fi-rkl-11600: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14583/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html> (i915#4103<https://gitlab.freedesktop.org/drm/intel/issues/4103>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html> +1 other test skip

  *   igt@kms_dsc@dsc-basic:

     *   fi-rkl-11600: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14583/fi-rkl-11600/igt@kms_dsc@dsc-basic.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#3840<https://gitlab.freedesktop.org/drm/intel/issues/3840>) -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-rkl-11600/igt@kms_dsc@dsc-basic.html>

Known issues

Here are the changes found in Patchwork_129123v4 that come from known issues:

IGT changes
Issues hit

  *   igt@debugfs_test@basic-hwmon:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@debugfs_test@basic-hwmon.html> (i915#9318<https://gitlab.freedesktop.org/drm/intel/issues/9318>)

  *   igt@fbdev@eof:

     *   fi-rkl-11600: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14583/fi-rkl-11600/igt@fbdev@eof.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-rkl-11600/igt@fbdev@eof.html> (i915#2582<https://gitlab.freedesktop.org/drm/intel/issues/2582>) +3 other tests skip

  *   igt@fbdev@info:

     *   fi-rkl-11600: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14583/fi-rkl-11600/igt@fbdev@info.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-rkl-11600/igt@fbdev@info.html> (i915#1849<https://gitlab.freedesktop.org/drm/intel/issues/1849> / i915#2582<https://gitlab.freedesktop.org/drm/intel/issues/2582>)
     *   bat-kbl-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-kbl-2/igt@fbdev@info.html> (i915#1849<https://gitlab.freedesktop.org/drm/intel/issues/1849>)

  *   igt@gem_huc_copy@huc-copy:

     *   fi-cfl-8109u: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-cfl-8109u/igt@gem_huc_copy@huc-copy.html> (i915#2190<https://gitlab.freedesktop.org/drm/intel/issues/2190>)

  *   igt@gem_lmem_swapping@parallel-random-engines:

     *   bat-kbl-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-kbl-2/igt@gem_lmem_swapping@parallel-random-engines.html> +39 other tests skip

  *   igt@gem_lmem_swapping@verify-random:

     *   fi-cfl-8109u: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-cfl-8109u/igt@gem_lmem_swapping@verify-random.html> (i915#4613<https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 other tests skip
     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@gem_lmem_swapping@verify-random.html> (i915#10213<https://gitlab.freedesktop.org/drm/intel/issues/10213>) +3 other tests skip

  *   igt@gem_mmap@basic:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@gem_mmap@basic.html> (i915#4083<https://gitlab.freedesktop.org/drm/intel/issues/4083>)
     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@gem_mmap@basic.html> (i915#4083<https://gitlab.freedesktop.org/drm/intel/issues/4083>)

  *   igt@gem_mmap_gtt@basic:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@gem_mmap_gtt@basic.html> (i915#10196<https://gitlab.freedesktop.org/drm/intel/issues/10196> / i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077>) +2 other tests skip

  *   igt@gem_render_tiled_blits@basic:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@gem_render_tiled_blits@basic.html> (i915#10197<https://gitlab.freedesktop.org/drm/intel/issues/10197> / i915#10211<https://gitlab.freedesktop.org/drm/intel/issues/10211> / i915#4079<https://gitlab.freedesktop.org/drm/intel/issues/4079>)

  *   igt@gem_tiled_fence_blits@basic:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@gem_tiled_fence_blits@basic.html> (i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077>) +2 other tests skip

  *   igt@gem_tiled_pread_basic:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@gem_tiled_pread_basic.html> (i915#4079<https://gitlab.freedesktop.org/drm/intel/issues/4079>) +1 other test skip
     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@gem_tiled_pread_basic.html> (i915#10206<https://gitlab.freedesktop.org/drm/intel/issues/10206> / i915#4079<https://gitlab.freedesktop.org/drm/intel/issues/4079>)

  *   igt@i915_pm_rps@basic-api:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@i915_pm_rps@basic-api.html> (i915#6621<https://gitlab.freedesktop.org/drm/intel/issues/6621>)
     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@i915_pm_rps@basic-api.html> (i915#10209<https://gitlab.freedesktop.org/drm/intel/issues/10209>)

  *   igt@i915_selftest@live@hangcheck:

     *   bat-adls-6: NOTRUN -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-adls-6/igt@i915_selftest@live@hangcheck.html> (i915#5591<https://gitlab.freedesktop.org/drm/intel/issues/5591>)

  *   igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html> (i915#4212<https://gitlab.freedesktop.org/drm/intel/issues/4212>) +7 other tests skip

  *   igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html> (i915#10200<https://gitlab.freedesktop.org/drm/intel/issues/10200>) +9 other tests skip

  *   igt@kms_addfb_basic@basic-y-tiled-legacy:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@kms_addfb_basic@basic-y-tiled-legacy.html> (i915#4215<https://gitlab.freedesktop.org/drm/intel/issues/4215>)

  *   igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html> (i915#10202<https://gitlab.freedesktop.org/drm/intel/issues/10202>) +1 other test skip
     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html> (i915#4103<https://gitlab.freedesktop.org/drm/intel/issues/4103> / i915#4213<https://gitlab.freedesktop.org/drm/intel/issues/4213>) +1 other test skip

  *   igt@kms_dsc@dsc-basic:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@kms_dsc@dsc-basic.html> (i915#9886<https://gitlab.freedesktop.org/drm/intel/issues/9886>)
     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@kms_dsc@dsc-basic.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555> / i915#3840<https://gitlab.freedesktop.org/drm/intel/issues/3840>)

  *   igt@kms_force_connector_basic@force-load-detect:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@kms_force_connector_basic@force-load-detect.html> (i915#10207<https://gitlab.freedesktop.org/drm/intel/issues/10207>)
     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@kms_force_connector_basic@force-load-detect.html>

  *   igt@kms_frontbuffer_tracking@basic:

     *   fi-rkl-11600: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14583/fi-rkl-11600/igt@kms_frontbuffer_tracking@basic.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-rkl-11600/igt@kms_frontbuffer_tracking@basic.html> (i915#1849<https://gitlab.freedesktop.org/drm/intel/issues/1849> / i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354>)

  *   igt@kms_hdmi_inject@inject-audio:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@kms_hdmi_inject@inject-audio.html> (i915#433<https://gitlab.freedesktop.org/drm/intel/issues/433>)

  *   igt@kms_pm_backlight@basic-brightness:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@kms_pm_backlight@basic-brightness.html> (i915#5354<https://gitlab.freedesktop.org/drm/intel/issues/5354>)
     *   fi-cfl-8109u: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-cfl-8109u/igt@kms_pm_backlight@basic-brightness.html> +11 other tests skip

  *   igt@kms_psr@psr-primary-mmap-gtt@edp-1:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@kms_psr@psr-primary-mmap-gtt@edp-1.html> (i915#10196<https://gitlab.freedesktop.org/drm/intel/issues/10196> / i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077> / i915#9688<https://gitlab.freedesktop.org/drm/intel/issues/9688>)

  *   igt@kms_psr@psr-primary-page-flip:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@kms_psr@psr-primary-page-flip.html> (i915#1072<https://gitlab.freedesktop.org/drm/intel/issues/1072> / i915#9732<https://gitlab.freedesktop.org/drm/intel/issues/9732>) +3 other tests skip

  *   igt@kms_setmode@basic-clone-single-crtc:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@kms_setmode@basic-clone-single-crtc.html> (i915#10208<https://gitlab.freedesktop.org/drm/intel/issues/10208> / i915#8809<https://gitlab.freedesktop.org/drm/intel/issues/8809>)
     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@kms_setmode@basic-clone-single-crtc.html> (i915#3555<https://gitlab.freedesktop.org/drm/intel/issues/3555>)

  *   igt@prime_vgem@basic-fence-flip:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@prime_vgem@basic-fence-flip.html> (i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708>) +3 other tests skip
     *   fi-rkl-11600: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14583/fi-rkl-11600/igt@prime_vgem@basic-fence-flip.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/fi-rkl-11600/igt@prime_vgem@basic-fence-flip.html> (i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708>)

  *   igt@prime_vgem@basic-fence-mmap:

     *   bat-dg1-7: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-dg1-7/igt@prime_vgem@basic-fence-mmap.html> (i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708> / i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077>) +1 other test skip
     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@prime_vgem@basic-fence-mmap.html> (i915#10196<https://gitlab.freedesktop.org/drm/intel/issues/10196> / i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708> / i915#4077<https://gitlab.freedesktop.org/drm/intel/issues/4077>) +1 other test skip

  *   igt@prime_vgem@basic-fence-read:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@prime_vgem@basic-fence-read.html> (i915#10212<https://gitlab.freedesktop.org/drm/intel/issues/10212> / i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708>)

  *   igt@prime_vgem@basic-read:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@prime_vgem@basic-read.html> (i915#10214<https://gitlab.freedesktop.org/drm/intel/issues/10214> / i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708>)

  *   igt@prime_vgem@basic-write:

     *   bat-arls-2: NOTRUN -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-arls-2/igt@prime_vgem@basic-write.html> (i915#10216<https://gitlab.freedesktop.org/drm/intel/issues/10216> / i915#3708<https://gitlab.freedesktop.org/drm/intel/issues/3708>)

Possible fixes

  *   igt@i915_selftest@live@active:

     *   bat-jsl-1: DMESG-FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14583/bat-jsl-1/igt@i915_selftest@live@active.html> (i915#10606<https://gitlab.freedesktop.org/drm/intel/issues/10606>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-jsl-1/igt@i915_selftest@live@active.html>

  *   igt@i915_selftest@live@gt_engines:

     *   bat-adls-6: TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14583/bat-adls-6/igt@i915_selftest@live@gt_engines.html> (i915#10026<https://gitlab.freedesktop.org/drm/intel/issues/10026>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_129123v4/bat-adls-6/igt@i915_selftest@live@gt_engines.html>

Build changes

  *   Linux: CI_DRM_14583 -> Patchwork_129123v4

CI-20190529: 20190529
CI_DRM_14583: 5f7597e990bea547bd1261170497e7476fb781bb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7806: 849cd963ce7e8222dcf17cc872d355181fd2c2a2 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_129123v4: 5f7597e990bea547bd1261170497e7476fb781bb @ git://anongit.freedesktop.org/gfx-ci/linux

Linux commits

e67fc4d1ee3a drm/i915: limit eDP MSO pipe only for display version 20 and below
Jani Nikula April 18, 2024, 11:28 a.m. UTC | #3
On Thu, 04 Apr 2024, Luca Coelho <luciano.coelho@intel.com> wrote:
> The pipes that can be used for eDP MSO are limited to pipe A (and
> sometimes also pipe B) only for display version 20 and below.
>
> Modify the function that returns the pipe mask for eDP MSO so that
> these limitations only apply to version 20 and below, enabling all
> pipes otherwise.

Thanks for the patch, pushed to din.

BR,
Jani.

>
> Bspec: 68923
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: James Ausmus <james.ausmus@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>
> In v5:
>    * fixed Ville's name's wrong charset, which prevented patchwork
>      from picking this up.
>
> In v4:
>    * actually go back to unrestricting only for > 20.  I sent the
>      wrong patch version in v3.
>
> In v3:
>    * go back to unrestricing only for > 20, since the change for
>      versions 14 to 20 should be tested separately;
>    * simplify the if blocks [Ville].
>
> In v2:
>    * allow pipes A and B from ver 14 to 20 [Gustavo]
>
>  drivers/gpu/drm/i915/display/intel_ddi.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index a3d3d4942eb1..5d2863c43296 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2336,10 +2336,15 @@ static void intel_ddi_power_up_lanes(struct intel_encoder *encoder,
>  	}
>  }
>  
> -/* Splitter enable for eDP MSO is limited to certain pipes. */
> +/*
> + * Splitter enable for eDP MSO is limited to certain pipes, on certain
> + * platforms.
> + */
>  static u8 intel_ddi_splitter_pipe_mask(struct drm_i915_private *i915)
>  {
> -	if (IS_ALDERLAKE_P(i915))
> +	if (DISPLAY_VER(i915) > 20)
> +		return ~0;
> +	else if (IS_ALDERLAKE_P(i915))
>  		return BIT(PIPE_A) | BIT(PIPE_B);
>  	else
>  		return BIT(PIPE_A);
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index a3d3d4942eb1..5d2863c43296 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2336,10 +2336,15 @@  static void intel_ddi_power_up_lanes(struct intel_encoder *encoder,
 	}
 }
 
-/* Splitter enable for eDP MSO is limited to certain pipes. */
+/*
+ * Splitter enable for eDP MSO is limited to certain pipes, on certain
+ * platforms.
+ */
 static u8 intel_ddi_splitter_pipe_mask(struct drm_i915_private *i915)
 {
-	if (IS_ALDERLAKE_P(i915))
+	if (DISPLAY_VER(i915) > 20)
+		return ~0;
+	else if (IS_ALDERLAKE_P(i915))
 		return BIT(PIPE_A) | BIT(PIPE_B);
 	else
 		return BIT(PIPE_A);