diff mbox series

[1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A

Message ID 20240418130120.67663-1-amadeus@jmu.edu.cn (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: arm: rockchip: correct the model name for Radxa ROCK 3A | expand

Commit Message

Chukun Pan April 18, 2024, 1:01 p.m. UTC
According to https://radxa.com/products/rock3/3a,
the name of this board should be "Radxa ROCK 3A".
Also update compatible to match the model name.

Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dragan Simic April 18, 2024, 3:21 p.m. UTC | #1
On 2024-04-18 15:01, Chukun Pan wrote:
> According to https://radxa.com/products/rock3/3a,
> the name of this board should be "Radxa ROCK 3A".
> Also update compatible to match the model name.
> 
> Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>

Looking good to me.  I'll send the remaining naming cleanup patches
a bit later.

Reviewed-by: Dragan Simic <dsimic@manjaro.org>


> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 99bd5e2c76a0..88e9e0011953 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -772,9 +772,9 @@ properties:
>            - const: radxa,rock2-square
>            - const: rockchip,rk3288
> 
> -      - description: Radxa ROCK3 Model A
> +      - description: Radxa ROCK 3A
>          items:
> -          - const: radxa,rock3a
> +          - const: radxa,rock-3a
>            - const: rockchip,rk3568
> 
>        - description: Radxa ROCK 5 Model A
Conor Dooley April 18, 2024, 3:36 p.m. UTC | #2
On Thu, Apr 18, 2024 at 09:01:19PM +0800, Chukun Pan wrote:
> According to https://radxa.com/products/rock3/3a,
> the name of this board should be "Radxa ROCK 3A".
> Also update compatible to match the model name.
> 
> Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 99bd5e2c76a0..88e9e0011953 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -772,9 +772,9 @@ properties:
>            - const: radxa,rock2-square
>            - const: rockchip,rk3288
>  
> -      - description: Radxa ROCK3 Model A
> +      - description: Radxa ROCK 3A

This is fine, but...

>          items:
> -          - const: radxa,rock3a
> +          - const: radxa,rock-3a

...this was added 2 years ago, I think it's too late to change it, NAK.

Cheers,
Conor.

>            - const: rockchip,rk3568
>  
>        - description: Radxa ROCK 5 Model A
> -- 
> 2.25.1
>
Conor Dooley April 18, 2024, 3:37 p.m. UTC | #3
On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
> On 2024-04-18 15:01, Chukun Pan wrote:
> > According to https://radxa.com/products/rock3/3a,
> > the name of this board should be "Radxa ROCK 3A".
> > Also update compatible to match the model name.
> > 
> > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> 
> Looking good to me.  I'll send the remaining naming cleanup patches
> a bit later.

What remaining patches?
Dragan Simic April 18, 2024, 3:46 p.m. UTC | #4
Hello Conor,

On 2024-04-18 17:37, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
>> On 2024-04-18 15:01, Chukun Pan wrote:
>> > According to https://radxa.com/products/rock3/3a,
>> > the name of this board should be "Radxa ROCK 3A".
>> > Also update compatible to match the model name.
>> >
>> > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>> 
>> Looking good to me.  I'll send the remaining naming cleanup patches
>> a bit later.
> 
> What remaining patches?

The same naming cleanups need to be performed for the Radxa
ROCK 5 boards. [1]  I had some more cleanups for the ROCK 4
boards in mind, but I'll drop them after your NAK. [2]

Though, I'm not really sure why the NAK?  Those names aren't
used anywhere, neither in the Linux kernel, nor in U-Boot.

[1] 
https://lore.kernel.org/linux-rockchip/B26C732A4DCEA9B3+282b8775-601b-4d4a-a513-4924b7940076@radxa.com/
[2] 
https://lore.kernel.org/linux-rockchip/20240418-liberty-pry-d270065a544f@spud/
Conor Dooley April 18, 2024, 3:57 p.m. UTC | #5
On Thu, Apr 18, 2024 at 05:46:30PM +0200, Dragan Simic wrote:
> Hello Conor,
> 
> On 2024-04-18 17:37, Conor Dooley wrote:
> > On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
> > > On 2024-04-18 15:01, Chukun Pan wrote:
> > > > According to https://radxa.com/products/rock3/3a,
> > > > the name of this board should be "Radxa ROCK 3A".
> > > > Also update compatible to match the model name.
> > > >
> > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
> > > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> > > 
> > > Looking good to me.  I'll send the remaining naming cleanup patches
> > > a bit later.
> > 
> > What remaining patches?
> 
> The same naming cleanups need to be performed for the Radxa
> ROCK 5 boards. [1]  I had some more cleanups for the ROCK 4
> boards in mind, but I'll drop them after your NAK. [2]
> 
> Though, I'm not really sure why the NAK?  Those names aren't
> used anywhere, neither in the Linux kernel, nor in U-Boot.

There may well be other users outside of those two projects that are
actually looking at it - I don't think that adding a hyphen is worth
disrupting anyone for, it seems perfectly clear without it what board
this is.
Dragan Simic April 18, 2024, 3:58 p.m. UTC | #6
On 2024-04-18 17:57, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 05:46:30PM +0200, Dragan Simic wrote:
>> On 2024-04-18 17:37, Conor Dooley wrote:
>> > On Thu, Apr 18, 2024 at 05:21:18PM +0200, Dragan Simic wrote:
>> > > On 2024-04-18 15:01, Chukun Pan wrote:
>> > > > According to https://radxa.com/products/rock3/3a,
>> > > > the name of this board should be "Radxa ROCK 3A".
>> > > > Also update compatible to match the model name.
>> > > >
>> > > > Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> > > > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
>> > >
>> > > Looking good to me.  I'll send the remaining naming cleanup patches
>> > > a bit later.
>> >
>> > What remaining patches?
>> 
>> The same naming cleanups need to be performed for the Radxa
>> ROCK 5 boards. [1]  I had some more cleanups for the ROCK 4
>> boards in mind, but I'll drop them after your NAK. [2]
>> 
>> Though, I'm not really sure why the NAK?  Those names aren't
>> used anywhere, neither in the Linux kernel, nor in U-Boot.
> 
> There may well be other users outside of those two projects that are
> actually looking at it - I don't think that adding a hyphen is worth
> disrupting anyone for, it seems perfectly clear without it what board
> this is.

I see, it's perhaps better to stay on the safe side.
Dragan Simic April 18, 2024, 4:34 p.m. UTC | #7
Hello Chukun,

On 2024-04-18 17:21, Dragan Simic wrote:
> On 2024-04-18 15:01, Chukun Pan wrote:
>> According to https://radxa.com/products/rock3/3a,
>> the name of this board should be "Radxa ROCK 3A".
>> Also update compatible to match the model name.
>> 
>> Suggested-by: FUKAUMI Naoki <naoki@radxa.com>
>> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> 
> Looking good to me.  I'll send the remaining naming cleanup patches
> a bit later.

Please note that I didn't touch the ROCK 3 board(s)
in my patches. [1][2]

[1] 
https://lore.kernel.org/linux-rockchip/1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org/
[2] 
https://lore.kernel.org/linux-rockchip/1e148d6cd4486b31b5e7f3824cf6bccf536b74c0.1713457260.git.dsimic@manjaro.org/

>> ---
>>  Documentation/devicetree/bindings/arm/rockchip.yaml | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 99bd5e2c76a0..88e9e0011953 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -772,9 +772,9 @@ properties:
>>            - const: radxa,rock2-square
>>            - const: rockchip,rk3288
>> 
>> -      - description: Radxa ROCK3 Model A
>> +      - description: Radxa ROCK 3A
>>          items:
>> -          - const: radxa,rock3a
>> +          - const: radxa,rock-3a
>>            - const: rockchip,rk3568
>> 
>>        - description: Radxa ROCK 5 Model A
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 99bd5e2c76a0..88e9e0011953 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -772,9 +772,9 @@  properties:
           - const: radxa,rock2-square
           - const: rockchip,rk3288
 
-      - description: Radxa ROCK3 Model A
+      - description: Radxa ROCK 3A
         items:
-          - const: radxa,rock3a
+          - const: radxa,rock-3a
           - const: rockchip,rk3568
 
       - description: Radxa ROCK 5 Model A