| Message ID | fa3b190b6e9cba65ecc36fc93121c6ed8704f704.1714036681.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 931c98463082f41571b77f73b0bc455dabdc4df9 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: brcmsmac: ampdu: remove unused cb_del_ampdu_pars struct | expand |
On 4/25/2024 11:22 AM, Christophe JAILLET wrote: > struct cb_del_ampdu_pars was added in the initial commit 5b435de0d7868 > ("net: wireless: add brcm80211 drivers") and its only usage was removed in > commit e041f65d5f00 ("brcmsmac: Remove internal tx queue"). > > Remove the structure definition now. This saves a few lines of code. Thanks. Looks good to me. Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Compile tested only > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 6 ------ > 1 file changed, 6 deletions(-)
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > struct cb_del_ampdu_pars was added in the initial commit 5b435de0d7868 > ("net: wireless: add brcm80211 drivers") and its only usage was removed in > commit e041f65d5f00 ("brcmsmac: Remove internal tx queue"). > > Remove the structure definition now. This saves a few lines of code. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Patch applied to wireless-next.git, thanks. 931c98463082 wifi: brcmsmac: ampdu: remove unused cb_del_ampdu_pars struct
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c index e859075db716..c3376f887114 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c @@ -143,12 +143,6 @@ struct ampdu_info { struct brcms_fifo_info fifo_tb[NUM_FFPLD_FIFO]; }; -/* used for flushing ampdu packets */ -struct cb_del_ampdu_pars { - struct ieee80211_sta *sta; - u16 tid; -}; - static void brcms_c_scb_ampdu_update_max_txlen(struct ampdu_info *ampdu, u8 dur) { u32 rate, mcs;
struct cb_del_ampdu_pars was added in the initial commit 5b435de0d7868 ("net: wireless: add brcm80211 drivers") and its only usage was removed in commit e041f65d5f00 ("brcmsmac: Remove internal tx queue"). Remove the structure definition now. This saves a few lines of code. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested only --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 6 ------ 1 file changed, 6 deletions(-)