| Message ID | 23afd8c1733ad087ce2399a07a30d689aef861d5.1714039373.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cc1380dd188204ada05936b034e93dbca9b5f06a |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: brcmfmac: remove unused brcmf_usb_image struct | expand |
On 4/25/2024 12:03 PM, Christophe JAILLET wrote: > struct brcmf_usb_image was added in the initial commit 71bb244ba2fd5 > ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") and updated > in commit 803599d40418 ("brcmfmac: store usb fw images in local linked > list.") > > Its only usage was removed in commit 52f98a57d8c1 ("brcmfmac: remove > firmware list from USB driver"). > > Remove the structure definition now. This saves a few lines of code. Thanks for the cleanup/ Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Compile tested only > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c > index 0ccf735316c2..9a105e6debe1 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c > @@ -117,13 +117,6 @@ struct bootrom_id_le { > __le32 boardrev; /* Board revision */ > }; > > -struct brcmf_usb_image { > - struct list_head list; > - s8 *fwname; > - u8 *image; > - int image_len; > -}; > - > struct brcmf_usbdev_info { > struct brcmf_usbdev bus_pub; /* MUST BE FIRST */ > spinlock_t qlock;
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > struct brcmf_usb_image was added in the initial commit 71bb244ba2fd5 > ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") and updated > in commit 803599d40418 ("brcmfmac: store usb fw images in local linked > list.") > > Its only usage was removed in commit 52f98a57d8c1 ("brcmfmac: remove > firmware list from USB driver"). > > Remove the structure definition now. This saves a few lines of code. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Patch applied to wireless-next.git, thanks. cc1380dd1882 wifi: brcmfmac: remove unused brcmf_usb_image struct
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c index 0ccf735316c2..9a105e6debe1 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c @@ -117,13 +117,6 @@ struct bootrom_id_le { __le32 boardrev; /* Board revision */ }; -struct brcmf_usb_image { - struct list_head list; - s8 *fwname; - u8 *image; - int image_len; -}; - struct brcmf_usbdev_info { struct brcmf_usbdev bus_pub; /* MUST BE FIRST */ spinlock_t qlock;
struct brcmf_usb_image was added in the initial commit 71bb244ba2fd5 ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets") and updated in commit 803599d40418 ("brcmfmac: store usb fw images in local linked list.") Its only usage was removed in commit 52f98a57d8c1 ("brcmfmac: remove firmware list from USB driver"). Remove the structure definition now. This saves a few lines of code. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested only --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 7 ------- 1 file changed, 7 deletions(-)