diff mbox series

[5/7] hw/arm/bcm2836: Remove unusued struct 'BCM283XClass'

Message ID 20240505171444.333302-6-dave@treblig.org (mailing list archive)
State New, archived
Headers show
Series Remove some unused structures | expand

Commit Message

Dr. David Alan Gilbert May 5, 2024, 5:14 p.m. UTC
This struct has been unused since
Commit f932093ae165 ("hw/arm/bcm2836: Split out common part of BCM283X
classes")

Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
 hw/arm/bcm2836.c | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Philippe Mathieu-Daudé May 6, 2024, 7:40 a.m. UTC | #1
On 5/5/24 19:14, Dr. David Alan Gilbert wrote:
> This struct has been unused since
> Commit f932093ae165 ("hw/arm/bcm2836: Split out common part of BCM283X
> classes")

Rather than "splitting out", commit f932093ae165 duplicated BCM283XClass
as BCM283XBaseClass and left it unmodified.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
>   hw/arm/bcm2836.c | 12 ------------
>   1 file changed, 12 deletions(-)
> 
> diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
> index db191661f2..40a379bc36 100644
> --- a/hw/arm/bcm2836.c
> +++ b/hw/arm/bcm2836.c
> @@ -18,18 +18,6 @@
>   #include "target/arm/cpu-qom.h"
>   #include "target/arm/gtimer.h"
>   
> -struct BCM283XClass {
> -    /*< private >*/
> -    DeviceClass parent_class;
> -    /*< public >*/
> -    const char *name;
> -    const char *cpu_type;
> -    unsigned core_count;
> -    hwaddr peri_base; /* Peripheral base address seen by the CPU */
> -    hwaddr ctrl_base; /* Interrupt controller and mailboxes etc. */
> -    int clusterid;
> -};
> -
>   static Property bcm2836_enabled_cores_property =
>       DEFINE_PROP_UINT32("enabled-cpus", BCM283XBaseState, enabled_cpus, 0);
>
diff mbox series

Patch

diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c
index db191661f2..40a379bc36 100644
--- a/hw/arm/bcm2836.c
+++ b/hw/arm/bcm2836.c
@@ -18,18 +18,6 @@ 
 #include "target/arm/cpu-qom.h"
 #include "target/arm/gtimer.h"
 
-struct BCM283XClass {
-    /*< private >*/
-    DeviceClass parent_class;
-    /*< public >*/
-    const char *name;
-    const char *cpu_type;
-    unsigned core_count;
-    hwaddr peri_base; /* Peripheral base address seen by the CPU */
-    hwaddr ctrl_base; /* Interrupt controller and mailboxes etc. */
-    int clusterid;
-};
-
 static Property bcm2836_enabled_cores_property =
     DEFINE_PROP_UINT32("enabled-cpus", BCM283XBaseState, enabled_cpus, 0);