diff mbox series

[RFC,v1,2/5] dt-bindings: clock: mediatek: add address-cells and size-cells to ethsys

Message ID 20240505164549.65644-3-linux@fw-web.de (mailing list archive)
State New, archived
Headers show
Series Add Bananapi R3 Mini | expand

Commit Message

Frank Wunderlich May 5, 2024, 4:45 p.m. UTC
From: Frank Wunderlich <frank-w@public-files.de>

Add missing properties already used in mt7986a.dtsi.

Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
 .../devicetree/bindings/clock/mediatek,ethsys.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski May 6, 2024, 8:18 a.m. UTC | #1
On 05/05/2024 18:45, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add missing properties already used in mt7986a.dtsi.

Missing for what? Or why? Provide context, IOW, explain why they are
missing.


Best regards,
Krzysztof
AngeloGioacchino Del Regno May 6, 2024, 12:48 p.m. UTC | #2
Il 05/05/24 18:45, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> Add missing properties already used in mt7986a.dtsi.
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Fixes tag? :-)

Cheers,
Angelo
Frank Wunderlich May 6, 2024, 4:01 p.m. UTC | #3
Am 6. Mai 2024 14:48:58 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>:
>Il 05/05/24 18:45, Frank Wunderlich ha scritto:
>> From: Frank Wunderlich <frank-w@public-files.de>
>> 
>> Add missing properties already used in mt7986a.dtsi.
>> 
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>
>Fixes tag? :-)
>
>Cheers,
>Angelo

Should i use fixes tag of binding commit or where dts (-part) was added?
regards Frank
Frank Wunderlich May 6, 2024, 4:51 p.m. UTC | #4
> Gesendet: Montag, 06. Mai 2024 um 10:18 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> On 05/05/2024 18:45, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Add missing properties already used in mt7986a.dtsi.
>
> Missing for what? Or why? Provide context, IOW, explain why they are
> missing.

ethernet-node in mt7986a.dtsi hast reset-cells-property

https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L559

and

address-cells and size-cells are used here:

https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L495

i saw the warnings while checking my r3mini dts...

arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: syscon@15000000: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/mediatek,ethsys.yaml#
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: ethernet@15100000: Unevaluated properties are not allowed ('#reset-cells' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/mediatek,net.yaml#

so i thought it is a good idea to fix this now ;)

but basicly not related to my dts as these are inherited, so i can drop binding-changes...

regards Frank

> Best regards,
> Krzysztof
AngeloGioacchino Del Regno May 7, 2024, 1:36 p.m. UTC | #5
Il 06/05/24 18:01, Frank Wunderlich ha scritto:
> Am 6. Mai 2024 14:48:58 MESZ schrieb AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>:
>> Il 05/05/24 18:45, Frank Wunderlich ha scritto:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> Add missing properties already used in mt7986a.dtsi.
>>>
>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>>
>> Fixes tag? :-)
>>
>> Cheers,
>> Angelo
> 
> Should i use fixes tag of binding commit or where dts (-part) was added?
> regards Frank

You're fixing the binding, so, the binding one :-)

Cheers,
Angelo
Rob Herring (Arm) May 7, 2024, 7:35 p.m. UTC | #6
On Mon, May 06, 2024 at 06:51:43PM +0200, Frank Wunderlich wrote:
> > Gesendet: Montag, 06. Mai 2024 um 10:18 Uhr
> > Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> > On 05/05/2024 18:45, Frank Wunderlich wrote:
> > > From: Frank Wunderlich <frank-w@public-files.de>
> > >
> > > Add missing properties already used in mt7986a.dtsi.
> >
> > Missing for what? Or why? Provide context, IOW, explain why they are
> > missing.
> 
> ethernet-node in mt7986a.dtsi hast reset-cells-property
> 
> https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L559
> 
> and
> 
> address-cells and size-cells are used here:
> 
> https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/mediatek/mt7986a.dtsi#L495
> 
> i saw the warnings while checking my r3mini dts...
> 
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: syscon@15000000: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/clock/mediatek,ethsys.yaml#
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: ethernet@15100000: Unevaluated properties are not allowed ('#reset-cells' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/net/mediatek,net.yaml#
> 
> so i thought it is a good idea to fix this now ;)

The dts is already fixed dropping these properties in linux-next.

If you don't have child nodes with reg/ranges, then you never need 
#address-cells or #size-cells.

Rob
Frank Wunderlich May 7, 2024, 9:22 p.m. UTC | #7
Hi

> Gesendet: Dienstag, 07. Mai 2024 um 21:35 Uhr
> Von: "Rob Herring" <robh@kernel.org>

> The dts is already fixed dropping these properties in linux-next.
>
> If you don't have child nodes with reg/ranges, then you never need
> #address-cells or #size-cells.

thx for pointing to this,

so i only need part 4+5 when 6.10-rc1 is out (as i drop netdev trigger from dts in v2).

any comments for these?

regards Frank
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/mediatek,ethsys.yaml b/Documentation/devicetree/bindings/clock/mediatek,ethsys.yaml
index f9cddacc2eae..ce953a35f307 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,ethsys.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,ethsys.yaml
@@ -32,12 +32,18 @@  properties:
   reg:
     maxItems: 1
 
+  "#address-cells":
+    const: 1
+
   "#clock-cells":
     const: 1
 
   "#reset-cells":
     const: 1
 
+  "#size-cells":
+    const: 1
+
 required:
   - reg
   - "#clock-cells"