diff mbox series

[03/13] dt-bindings: phy: qcom,usb-snps-femto-v2: use correct fallback for sc8180x

Message ID 20240501-qcom-phy-fixes-v1-3-f1fd15c33fb3@linaro.org
State Accepted
Commit 960b3f023d3bda0efd6e573a0647227d1115d266
Headers show
Series arm64: dts: qcom: fix PHY-related warnings | expand

Commit Message

Dmitry Baryshkov May 1, 2024, 4:19 p.m. UTC
The qcom,sc8180x-usb-hs-phy device uses qcom,usb-snps-hs-7nm-phy
fallback. Correct the schema for this platform.

Fixes: 9160fb7c39a1 ("dt-bindings: phy: qcom,usb-snps-femto-v2: use fallback compatibles")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Krzysztof Kozlowski May 3, 2024, 7:04 a.m. UTC | #1
On 01/05/2024 18:19, Dmitry Baryshkov wrote:
> The qcom,sc8180x-usb-hs-phy device uses qcom,usb-snps-hs-7nm-phy
> fallback. Correct the schema for this platform.
> 
> Fixes: 9160fb7c39a1 ("dt-bindings: phy: qcom,usb-snps-femto-v2: use fallback compatibles")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Rob Herring (Arm) May 9, 2024, 2:16 p.m. UTC | #2
On Wed, May 01, 2024 at 07:19:29PM +0300, Dmitry Baryshkov wrote:
> The qcom,sc8180x-usb-hs-phy device uses qcom,usb-snps-hs-7nm-phy
> fallback. Correct the schema for this platform.
> 
> Fixes: 9160fb7c39a1 ("dt-bindings: phy: qcom,usb-snps-femto-v2: use fallback compatibles")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> index 0f200e3f97a9..fce7f8a19e9c 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> @@ -15,9 +15,6 @@ description: |
>  properties:
>    compatible:
>      oneOf:
> -      - enum:
> -          - qcom,sc8180x-usb-hs-phy
> -          - qcom,usb-snps-femto-v2-phy

This is now listed as undocumented. You need to remove it from the 
driver as well or keep it here as deprecated.

>        - items:
>            - enum:
>                - qcom,sa8775p-usb-hs-phy
> @@ -26,6 +23,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,sc7280-usb-hs-phy
> +              - qcom,sc8180x-usb-hs-phy
>                - qcom,sdx55-usb-hs-phy
>                - qcom,sdx65-usb-hs-phy
>                - qcom,sm6375-usb-hs-phy
> 
> -- 
> 2.39.2
>
Dmitry Baryshkov May 9, 2024, 2:44 p.m. UTC | #3
On Thu, 9 May 2024 at 17:16, Rob Herring <robh@kernel.org> wrote:
>
> On Wed, May 01, 2024 at 07:19:29PM +0300, Dmitry Baryshkov wrote:
> > The qcom,sc8180x-usb-hs-phy device uses qcom,usb-snps-hs-7nm-phy
> > fallback. Correct the schema for this platform.
> >
> > Fixes: 9160fb7c39a1 ("dt-bindings: phy: qcom,usb-snps-femto-v2: use fallback compatibles")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> > index 0f200e3f97a9..fce7f8a19e9c 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> > @@ -15,9 +15,6 @@ description: |
> >  properties:
> >    compatible:
> >      oneOf:
> > -      - enum:
> > -          - qcom,sc8180x-usb-hs-phy
> > -          - qcom,usb-snps-femto-v2-phy
>
> This is now listed as undocumented. You need to remove it from the
> driver as well or keep it here as deprecated.

Ack, I'll send a separate patch, removing this compat. It has never
been used in the DT files.

>
> >        - items:
> >            - enum:
> >                - qcom,sa8775p-usb-hs-phy
> > @@ -26,6 +23,7 @@ properties:
> >        - items:
> >            - enum:
> >                - qcom,sc7280-usb-hs-phy
> > +              - qcom,sc8180x-usb-hs-phy
> >                - qcom,sdx55-usb-hs-phy
> >                - qcom,sdx65-usb-hs-phy
> >                - qcom,sm6375-usb-hs-phy
> >
> > --
> > 2.39.2
> >
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
index 0f200e3f97a9..fce7f8a19e9c 100644
--- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
@@ -15,9 +15,6 @@  description: |
 properties:
   compatible:
     oneOf:
-      - enum:
-          - qcom,sc8180x-usb-hs-phy
-          - qcom,usb-snps-femto-v2-phy
       - items:
           - enum:
               - qcom,sa8775p-usb-hs-phy
@@ -26,6 +23,7 @@  properties:
       - items:
           - enum:
               - qcom,sc7280-usb-hs-phy
+              - qcom,sc8180x-usb-hs-phy
               - qcom,sdx55-usb-hs-phy
               - qcom,sdx65-usb-hs-phy
               - qcom,sm6375-usb-hs-phy