diff mbox series

[2/4] Move shared/002 to generic/745

Message ID ddb9dd4eabcb5c6695c2c0ea7e257d0b615814e9.1715108589.git.dsterba@suse.com (mailing list archive)
State New, archived
Headers show
Series Move test cased from shared to generic | expand

Commit Message

David Sterba May 7, 2024, 7:07 p.m. UTC
The shared/ directory was supposed to host tests that apply to a subset
of all supported filesystems but this is not utilized much and creates a
split from the generic tests. Move the test to generic.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 tests/{shared/002 => generic/745}         | 2 +-
 tests/{shared/002.out => generic/745.out} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename tests/{shared/002 => generic/745} (99%)
 rename tests/{shared/002.out => generic/745.out} (100%)

Comments

Christoph Hellwig May 9, 2024, 5:40 a.m. UTC | #1
Same comment as last time - please add a common helper to check
one. e.g. a max_xattr_values or max_xattr_space helper.
David Sterba May 9, 2024, 4:34 p.m. UTC | #2
On Wed, May 08, 2024 at 10:40:59PM -0700, Christoph Hellwig wrote:
> Same comment as last time - please add a common helper to check
> one. e.g. a max_xattr_values or max_xattr_space helper.

I agree that adding the feature checks is the right way but I want to
keep minimal changes when files get moved.
diff mbox series

Patch

diff --git a/tests/shared/002 b/tests/generic/745
similarity index 99%
rename from tests/shared/002
rename to tests/generic/745
index d99539c91907b5..0f47f9c69ef40a 100755
--- a/tests/shared/002
+++ b/tests/generic/745
@@ -2,7 +2,7 @@ 
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (C) 2015 SUSE Linux Products GmbH. All Rights Reserved.
 #
-# FS QA Test No. 002
+# FS QA Test No. 745
 #
 # Test that after syncing the filesystem, adding many xattrs to a file, syncing
 # the filesystem again, writing to the file and then doing a fsync against that
diff --git a/tests/shared/002.out b/tests/generic/745.out
similarity index 100%
rename from tests/shared/002.out
rename to tests/generic/745.out