diff mbox series

[v2] wifi: ath12k: remove redundant peer delete for WCN7850

Message ID 20240510111238.1113-1-quic_kangyang@quicinc.com (mailing list archive)
State Accepted
Commit 3a29442a17413e9e64f00db3b98dbf911324cb86
Delegated to: Kalle Valo
Headers show
Series [v2] wifi: ath12k: remove redundant peer delete for WCN7850 | expand

Commit Message

Kang Yang May 10, 2024, 11:12 a.m. UTC 
From: Kang Yang <quic_kangyang@quicinc.com>

ath12k_mac_op_unassign_vif_chanctx() will do peer delete for WCN7850's
monitor interface.

But for host no need to do peer create/delete for monitor interface
because firmware doesn't require it, QCN9274 is the same.

Also, the first judgement is true only for WCN7850, so this logic won't
affect QCN9274 at any time.

So remove this peer delete.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
---

v2: rewrite commit message.

---
 drivers/net/wireless/ath/ath12k/mac.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Kalle Valo May 10, 2024, 11:27 a.m. UTC | #1 
kangyang <quic_kangyang@quicinc.com> writes:

> From: Kang Yang <quic_kangyang@quicinc.com>

Please fix your git config, it looks your name in email From header is
formatted wrong:

From: kangyang <quic_kangyang@quicinc.com>

https://lore.kernel.org/ath12k/20240510111238.1113-1-quic_kangyang@quicinc.com/raw

I guess it should be like this:

From: Kang Yang <quic_kangyang@quicinc.com>

Though I'm not sure what kind of formatting you prefer, please just pick
one and use it consistently :) No need to resend because of this.
Jeff Johnson May 10, 2024, 2:35 p.m. UTC | #2 
On 5/10/2024 4:12 AM, kangyang wrote:
> From: Kang Yang <quic_kangyang@quicinc.com>
> 
> ath12k_mac_op_unassign_vif_chanctx() will do peer delete for WCN7850's
> monitor interface.
> 
> But for host no need to do peer create/delete for monitor interface
> because firmware doesn't require it, QCN9274 is the same.
> 
> Also, the first judgement is true only for WCN7850, so this logic won't
> affect QCN9274 at any time.
> 
> So remove this peer delete.
> 
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Kalle Valo May 16, 2024, 8:28 a.m. UTC | #3 
kangyang <quic_kangyang@quicinc.com> wrote:

> ath12k_mac_op_unassign_vif_chanctx() will do peer delete for WCN7850's monitor
> interface. But for host no need to do peer create/delete for monitor interface
> because firmware doesn't require it, QCN9274 is the same. Also, the first
> judgement is true only for WCN7850, so this logic won't affect QCN9274 at any
> time.
> 
> So remove this peer delete.
> 
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
> 
> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

3a29442a1741 wifi: ath12k: remove redundant peer delete for WCN7850
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 96dc5c2e096f..1b8a74159ca5 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -7366,11 +7366,6 @@  ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw,
 
 	WARN_ON(!arvif->is_started);
 
-	if (ab->hw_params->vdev_start_delay &&
-	    arvif->vdev_type == WMI_VDEV_TYPE_MONITOR &&
-	    ath12k_peer_find_by_addr(ab, ar->mac_addr))
-		ath12k_peer_delete(ar, arvif->vdev_id, ar->mac_addr);
-
 	if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) {
 		ret = ath12k_mac_monitor_stop(ar);
 		if (ret) {