diff mbox series

[v2,23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub

Message ID	20240513074717.130949-24-richard.henderson@linaro.org (mailing list archive)
State	New, archived
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> From: Richard Henderson <richard.henderson@linaro.org> To: qemu-devel@nongnu.org Cc: deller@gmx.de Subject: [PATCH v2 23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub Date: Mon, 13 May 2024 09:46:55 +0200 Message-Id: <20240513074717.130949-24-richard.henderson@linaro.org> In-Reply-To: <20240513074717.130949-1-richard.henderson@linaro.org> References: <20240513074717.130949-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Series	target/hppa: Misc improvements \| expand [v2,00/45] target/hppa: Misc improvements [v2,01/45] target/hppa: Move cpu_get_tb_cpu_state out of line [v2,02/45] target/hppa: Use hppa_form_gva_psw in hppa_cpu_get_pc [v2,03/45] target/hppa: Move constant destination check into use_goto_tb [v2,04/45] target/hppa: Pass displacement to do_dbranch [v2,05/45] target/hppa: Allow prior nullification in do_ibranch [v2,06/45] target/hppa: Use CF_BP_PAGE instead of cpu_breakpoint_test [v2,07/45] target/hppa: Add install_iaq_entries [v2,08/45] target/hppa: Add install_link [v2,09/45] target/hppa: Delay computation of IAQ_Next [v2,10/45] target/hppa: Skip nullified insns in unconditional dbranch path [v2,11/45] target/hppa: Simplify TB end [v2,12/45] target/hppa: Add IASQ entries to DisasContext [v2,13/45] target/hppa: Add space arguments to install_iaq_entries [v2,14/45] target/hppa: Add space argument to do_ibranch [v2,15/45] target/hppa: Use umax in do_ibranch_priv [v2,16/45] target/hppa: Always make a copy in do_ibranch_priv [v2,17/45] target/hppa: Introduce and use DisasIAQE for branch management [v2,18/45] target/hppa: Use displacements in DisasIAQE [v2,19/45] target/hppa: Rename cond_make_* helpers [v2,20/45] target/hppa: Use TCG_COND_TST* in do_cond [v2,21/45] target/hppa: Use TCG_COND_TST* in do_log_cond [v2,22/45] target/hppa: Use TCG_COND_TST* in do_unit_zero_cond [v2,23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub [v2,24/45] target/hppa: Use TCG_COND_TST* in trans_bb_imm [v2,25/45] target/hppa: Use registerfields.h for FPSR [v2,26/45] target/hppa: Use TCG_COND_TST* in trans_ftest [v2,27/45] target/hppa: Remove cond_free [v2,28/45] target/hppa: Introduce DisasDelayException [v2,29/45] target/hppa: Use delay_excp for conditional traps [v2,30/45] target/hppa: Use delay_excp for conditional trap on overflow [v2,31/45] linux-user/hppa: Force all code addresses to PRIV_USER [v2,32/45] target/hppa: Store full iaoq_f and page offset of iaoq_b in TB [v2,33/45] target/hppa: Do not mask in copy_iaoq_entry [v2,34/45] target/hppa: Improve hppa_cpu_dump_state [v2,35/45] target/hppa: Split PSW X and B into their own field [v2,36/45] target/hppa: Manage PSW_X and PSW_B in translator [v2,37/45] target/hppa: Implement PSW_B [v2,38/45] target/hppa: Implement PSW_X [v2,39/45] target/hppa: Drop tlb_entry return from hppa_get_physical_address [v2,40/45] target/hppa: Adjust priv for B,GATE at runtime [v2,41/45] target/hppa: Implement CF_PCREL [v2,42/45] target/hppa: Implement PSW_T [v2,43/45] target/hppa: Implement PSW_H, PSW_L [v2,44/45] target/hppa: Log cpu state at interrupt [v2,45/45] target/hppa: Log cpu state on return-from-interrupt

Commit Message

Richard Henderson May 13, 2024, 7:46 a.m. UTC

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/hppa/translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Philippe Mathieu-Daudé May 13, 2024, 9:37 a.m. UTC | #1

On 13/5/24 09:46, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/hppa/translate.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Helge Deller May 14, 2024, 4:29 p.m. UTC | #2

* Richard Henderson <richard.henderson@linaro.org>:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Helge Deller <deller@gmx.de>

diff mbox series

Patch

diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 50cc6decd8..47f4b23d1b 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -1419,8 +1419,8 @@  static void do_unit_addsub(DisasContext *ctx, unsigned rt, TCGv_i64 in1,
             tcg_gen_shri_i64(cb, cb, 1);
         }
 
-        tcg_gen_andi_i64(cb, cb, test_cb);
-        cond = cond_make_ti(cf & 1 ? TCG_COND_EQ : TCG_COND_NE, cb, 0);
+        cond = cond_make_ti(cf & 1 ? TCG_COND_TSTEQ : TCG_COND_TSTNE,
+                            cb, test_cb);
     }
 
     if (is_tc) {