diff mbox series

[01/47] dt-bindings: arm: qcom: Document QCS9100 SoC and RIDE board

Message ID 20240703025850.2172008-2-quic_tengfan@quicinc.com (mailing list archive)
State Handled Elsewhere
Delegated to: Krzysztof WilczyƄski
Headers show
Series arm64: qcom: dts: add QCS9100 support | expand

Commit Message

Tengfei Fan July 3, 2024, 2:58 a.m. UTC
Document the QCS9100 SoC and RIDE board.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski July 3, 2024, 4:38 a.m. UTC | #1
On 03/07/2024 04:58, Tengfei Fan wrote:
> Document the QCS9100 SoC and RIDE board.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index ec1c10a12470..f06543f96026 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -45,6 +45,7 @@ description: |
>          qcs8550
>          qcm2290
>          qcm6490
> +        qcs9100
>          qdu1000
>          qrb2210
>          qrb4210
> @@ -894,7 +895,9 @@ properties:
>  
>        - items:
>            - enum:
> +              - qcom,qcs9100-ride
>                - qcom,sa8775p-ride
> +          - const: qcom,qcs9100

This changes existing compatible for sa8775p without any explanation in
commit msg.

Best regards,
Krzysztof
Tengfei Fan July 3, 2024, 9:21 a.m. UTC | #2
On 7/3/2024 12:38 PM, Krzysztof Kozlowski wrote:
> On 03/07/2024 04:58, Tengfei Fan wrote:
>> Document the QCS9100 SoC and RIDE board.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index ec1c10a12470..f06543f96026 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -45,6 +45,7 @@ description: |
>>           qcs8550
>>           qcm2290
>>           qcm6490
>> +        qcs9100
>>           qdu1000
>>           qrb2210
>>           qrb4210
>> @@ -894,7 +895,9 @@ properties:
>>   
>>         - items:
>>             - enum:
>> +              - qcom,qcs9100-ride
>>                 - qcom,sa8775p-ride
>> +          - const: qcom,qcs9100
> 
> This changes existing compatible for sa8775p without any explanation in
> commit msg.
> 
> Best regards,
> Krzysztof
> 

In the next verion patch series, I will provide relevant explanatory 
information in this patch commit message.
Krzysztof Kozlowski July 3, 2024, 9:33 a.m. UTC | #3
On 03/07/2024 11:21, Tengfei Fan wrote:
>>>         - items:
>>>             - enum:
>>> +              - qcom,qcs9100-ride
>>>                 - qcom,sa8775p-ride
>>> +          - const: qcom,qcs9100
>>
>> This changes existing compatible for sa8775p without any explanation in
>> commit msg.
>>
>> Best regards,
>> Krzysztof
>>
> 
> In the next verion patch series, I will provide relevant explanatory 
> information in this patch commit message.

TBH, I cannot think of any reasonable explanation for this, especially
considering rest of the patchset which does not fix resulting dtbs_check
warning.

Best regards,
Krzysztof
Tengfei Fan July 3, 2024, 9:48 a.m. UTC | #4
On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote:
> On 03/07/2024 11:21, Tengfei Fan wrote:
>>>>          - items:
>>>>              - enum:
>>>> +              - qcom,qcs9100-ride
>>>>                  - qcom,sa8775p-ride
>>>> +          - const: qcom,qcs9100
>>>
>>> This changes existing compatible for sa8775p without any explanation in
>>> commit msg.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> In the next verion patch series, I will provide relevant explanatory
>> information in this patch commit message.
> 
> TBH, I cannot think of any reasonable explanation for this, especially
> considering rest of the patchset which does not fix resulting dtbs_check
> warning.
> 
> Best regards,
> Krzysztof
> 

This patch may need to be updated based on the results of dtbs_check. In 
the new version patch series, I will revise the commit message according 
to the patch updates made.
Aiqun Yu (Maria) July 8, 2024, 4:45 a.m. UTC | #5
On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote:
> On 03/07/2024 11:21, Tengfei Fan wrote:
>>>>         - items:
>>>>             - enum:
>>>> +              - qcom,qcs9100-ride
>>>>                 - qcom,sa8775p-ride
>>>> +          - const: qcom,qcs9100
>>>
>>> This changes existing compatible for sa8775p without any explanation in
>>> commit msg.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> In the next verion patch series, I will provide relevant explanatory 
>> information in this patch commit message.
> 
> TBH, I cannot think of any reasonable explanation for this, especially
> considering rest of the patchset which does not fix resulting dtbs_check
> warning.

The existing compatible "sa8775p" warning can only be addressed When
@Nikunj's "sa8775p" changes merged.

Let me know if you have other suggestions for this.

> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski July 8, 2024, 6:07 a.m. UTC | #6
On 08/07/2024 06:45, Aiqun Yu (Maria) wrote:
> 
> 
> On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote:
>> On 03/07/2024 11:21, Tengfei Fan wrote:
>>>>>         - items:
>>>>>             - enum:
>>>>> +              - qcom,qcs9100-ride
>>>>>                 - qcom,sa8775p-ride
>>>>> +          - const: qcom,qcs9100
>>>>
>>>> This changes existing compatible for sa8775p without any explanation in
>>>> commit msg.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>> In the next verion patch series, I will provide relevant explanatory 
>>> information in this patch commit message.
>>
>> TBH, I cannot think of any reasonable explanation for this, especially
>> considering rest of the patchset which does not fix resulting dtbs_check
>> warning.
> 
> The existing compatible "sa8775p" warning can only be addressed When
> @Nikunj's "sa8775p" changes merged.
> 
> Let me know if you have other suggestions for this.

I don't have, because I don't understand why do you want/need to change
existing board compatible.

Best regards,
Krzysztof
Aiqun Yu (Maria) July 8, 2024, 7:13 a.m. UTC | #7
On 7/8/2024 2:07 PM, Krzysztof Kozlowski wrote:
> On 08/07/2024 06:45, Aiqun Yu (Maria) wrote:
>>
>>
>> On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote:
>>> On 03/07/2024 11:21, Tengfei Fan wrote:
>>>>>>         - items:
>>>>>>             - enum:
>>>>>> +              - qcom,qcs9100-ride
>>>>>>                 - qcom,sa8775p-ride
>>>>>> +          - const: qcom,qcs9100
>>>>>
>>>>> This changes existing compatible for sa8775p without any explanation in
>>>>> commit msg.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>
>>>> In the next verion patch series, I will provide relevant explanatory 
>>>> information in this patch commit message.
>>>
>>> TBH, I cannot think of any reasonable explanation for this, especially
>>> considering rest of the patchset which does not fix resulting dtbs_check
>>> warning.
>>
>> The existing compatible "sa8775p" warning can only be addressed When
>> @Nikunj's "sa8775p" changes merged.
>>
>> Let me know if you have other suggestions for this.
> 
> I don't have, because I don't understand why do you want/need to change
> existing board compatible.

We can left the current existing sa8775p board compatible as it is. And
have a brand new qcs9100 and qcs9100-board item for current non-scmi
resources compatible.

Will that be more reasonable from your end?

> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski July 8, 2024, 7:31 a.m. UTC | #8
On 08/07/2024 09:13, Aiqun Yu (Maria) wrote:
> 
> 
> On 7/8/2024 2:07 PM, Krzysztof Kozlowski wrote:
>> On 08/07/2024 06:45, Aiqun Yu (Maria) wrote:
>>>
>>>
>>> On 7/3/2024 5:33 PM, Krzysztof Kozlowski wrote:
>>>> On 03/07/2024 11:21, Tengfei Fan wrote:
>>>>>>>         - items:
>>>>>>>             - enum:
>>>>>>> +              - qcom,qcs9100-ride
>>>>>>>                 - qcom,sa8775p-ride
>>>>>>> +          - const: qcom,qcs9100
>>>>>>
>>>>>> This changes existing compatible for sa8775p without any explanation in
>>>>>> commit msg.
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>>>
>>>>>
>>>>> In the next verion patch series, I will provide relevant explanatory 
>>>>> information in this patch commit message.
>>>>
>>>> TBH, I cannot think of any reasonable explanation for this, especially
>>>> considering rest of the patchset which does not fix resulting dtbs_check
>>>> warning.
>>>
>>> The existing compatible "sa8775p" warning can only be addressed When
>>> @Nikunj's "sa8775p" changes merged.
>>>
>>> Let me know if you have other suggestions for this.
>>
>> I don't have, because I don't understand why do you want/need to change
>> existing board compatible.
> 
> We can left the current existing sa8775p board compatible as it is. And
> have a brand new qcs9100 and qcs9100-board item for current non-scmi
> resources compatible.
> 
> Will that be more reasonable from your end?

Yes, this is what I would expect. If you choose any other way - just
like I wrote - you need to explain why you are doing this.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index ec1c10a12470..f06543f96026 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -45,6 +45,7 @@  description: |
         qcs8550
         qcm2290
         qcm6490
+        qcs9100
         qdu1000
         qrb2210
         qrb4210
@@ -894,7 +895,9 @@  properties:
 
       - items:
           - enum:
+              - qcom,qcs9100-ride
               - qcom,sa8775p-ride
+          - const: qcom,qcs9100
           - const: qcom,sa8775p
 
       - items: