| Message ID | 20240704143611.2979589-1-arnd@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arch: convert everything to syscall.tbl | expand |
On Thu, 4 Jul 2024, Arnd Bergmann wrote:
> arch/alpha/include/asm/unistd.h | 1 +
This seems out of sync with the actual changes, any idea what happened
here?
Maciej
On Fri, Jul 5, 2024, at 12:18, Maciej W. Rozycki wrote: > On Thu, 4 Jul 2024, Arnd Bergmann wrote: > >> arch/alpha/include/asm/unistd.h | 1 + > > This seems out of sync with the actual changes, any idea what happened > here? Sorry about this, I was writing the series description while still doing some treewide tests that showed I had missed a change in a rebase. When I originally wrote the clone3 patch, alpha was still missing clone3 support, so I added a line there to mark the syscall as broken. The current version is based on 6.10-rc, so clone3 actually works now and the patch I sent no longer needs to mark it as broken. Arnd
Hello: This series was applied to riscv/linux.git (for-next) by Arnd Bergmann <arnd@arndb.de>: On Thu, 4 Jul 2024 16:35:54 +0200 you wrote: > From: Arnd Bergmann <arnd@arndb.de> > > There are eight architectures using include/uapi/asm-generic/unistd.h, > which is still in an old format and not easily parsed by scripts. > In addition, arm64 uses the old format for the 32-bit arm compat syscalls, > despite them using the modern syscall.tbl format for the native calls. > > [...] Here is the summary with links: - [01/17] syscalls: add generic scripts/syscall.tbl https://git.kernel.org/riscv/c/4fe53bf2ba0a - [02/17] csky: drop asm/gpio.h wrapper https://git.kernel.org/riscv/c/ed8023ae9d79 - [03/17] um: don't generate asm/bpf_perf_event.h (no matching commit) - [04/17] loongarch: avoid generating extra header files https://git.kernel.org/riscv/c/ff96f5c6971c - [05/17] kbuild: verify asm-generic header list https://git.kernel.org/riscv/c/b70f12e962bc - [06/17] kbuild: add syscall table generation to scripts/Makefile.asm-headers https://git.kernel.org/riscv/c/fbb5c0606fa4 - [07/17] clone3: drop __ARCH_WANT_SYS_CLONE3 macro https://git.kernel.org/riscv/c/505d66d1abfb - [08/17] arc: convert to generic syscall table https://git.kernel.org/riscv/c/4414ad8eb4c2 - [09/17] arm64: convert unistd_32.h to syscall.tbl format https://git.kernel.org/riscv/c/7fe33e9f662c - [10/17] arm64: generate 64-bit syscall.tbl (no matching commit) - [11/17] arm64: rework compat syscall macros (no matching commit) - [12/17] csky: convert to generic syscall table (no matching commit) - [13/17] hexagon: use new system call table (no matching commit) - [14/17] loongarch: convert to generic syscall table https://git.kernel.org/riscv/c/26a3b85bac08 - [15/17] nios2: convert to generic syscall table https://git.kernel.org/riscv/c/ef608c5767f9 - [16/17] openrisc: convert to generic syscall table https://git.kernel.org/riscv/c/77122bf9e3df - [17/17] riscv: convert to generic syscall table https://git.kernel.org/riscv/c/3db80c999deb You are awesome, thank you!
From: Arnd Bergmann <arnd@arndb.de> There are eight architectures using include/uapi/asm-generic/unistd.h, which is still in an old format and not easily parsed by scripts. In addition, arm64 uses the old format for the 32-bit arm compat syscalls, despite them using the modern syscall.tbl format for the native calls. As part of a larger cleanup, this converts all of them to use the new format with a shared file. I was planning to post this earlier, but ended up fixing up any system calls that have mismatched calling conventions between kernel and userspace first, as that seemed more important. I originally tried adding the same arch/*/kernel/syscalls/Makefile as used on the other architectures, but ended up simplifying this in the process to use a single set of Makefile rules in scripts/Makefile.asm-headers, which in turn requires a few cleanups to arch/*/include/asm/Kbuild files. Another prerequisite included in here is to make sys_clone3 get provided on all architectures, though it remains broken and returns -ENOSYS on hexagon, nios2, sh and sparc. To preserve the compile-time warning, I added an explicit #warning for those that are marked broken. Once we have the new table format in place everywhere, additional improvements I have planned will be much easier, including: - generating machine-readable syscall API descriptions for each syscall on each architecture - type checking to ensure that the in-kernel prototype matches what userspace tools see - unifying the last common bits of all tables so that new syscalls only need to get added in one place - generate human-readable wrappers for native and compat syscalls on all architectures to replace the SYSCALL_DEFINEx() macros. Arnd Arnd Bergmann (17): syscalls: add generic scripts/syscall.tbl csky: drop asm/gpio.h wrapper um: don't generate asm/bpf_perf_event.h loongarch: avoid generating extra header files kbuild: verify asm-generic header list kbuild: add syscall table generation to scripts/Makefile.asm-headers clone3: drop __ARCH_WANT_SYS_CLONE3 macro arc: convert to generic syscall table arm64: convert unistd_32.h to syscall.tbl format arm64: generate 64-bit syscall.tbl arm64: rework compat syscall macros csky: convert to generic syscall table hexagon: use new system call table loongarch: convert to generic syscall table nios2: convert to generic syscall table openrisc: convert to generic syscall table riscv: convert to generic syscall table Makefile | 2 +- arch/alpha/include/asm/unistd.h | 1 + arch/arc/include/asm/Kbuild | 2 + arch/arc/include/asm/unistd.h | 14 + arch/arc/include/uapi/asm/Kbuild | 2 + arch/arc/include/uapi/asm/unistd.h | 44 +- arch/arc/kernel/Makefile.syscalls | 3 + arch/arc/kernel/sys.c | 5 +- arch/arm/include/asm/unistd.h | 1 - arch/arm64/include/asm/Kbuild | 8 + arch/arm64/include/asm/seccomp.h | 13 +- arch/arm64/include/asm/unistd.h | 22 +- arch/arm64/include/asm/unistd32.h | 939 +----------------- .../include/asm/vdso/compat_gettimeofday.h | 12 +- arch/arm64/include/uapi/asm/Kbuild | 1 + arch/arm64/include/uapi/asm/unistd.h | 25 +- arch/arm64/kernel/Makefile.syscalls | 6 + arch/arm64/kernel/signal32.c | 2 +- arch/arm64/kernel/sigreturn32.S | 18 +- arch/arm64/kernel/sys.c | 6 +- arch/arm64/kernel/sys32.c | 17 +- arch/arm64/kernel/syscall.c | 3 +- arch/arm64/tools/Makefile | 6 +- arch/arm64/tools/syscall_32.tbl | 476 +++++++++ arch/arm64/tools/syscall_64.tbl | 1 + arch/csky/include/asm/Kbuild | 3 +- arch/csky/include/asm/unistd.h | 3 + arch/csky/include/uapi/asm/Kbuild | 2 + arch/csky/include/uapi/asm/unistd.h | 15 +- arch/csky/kernel/Makefile.syscalls | 4 + arch/csky/kernel/syscall_table.c | 4 +- arch/hexagon/include/asm/Kbuild | 2 + arch/hexagon/include/asm/unistd.h | 10 + arch/hexagon/include/uapi/asm/Kbuild | 2 + arch/hexagon/include/uapi/asm/unistd.h | 13 +- arch/hexagon/kernel/Makefile.syscalls | 3 + arch/hexagon/kernel/syscalltab.c | 8 +- arch/loongarch/include/asm/Kbuild | 17 +- arch/loongarch/include/asm/unistd.h | 2 + arch/loongarch/include/uapi/asm/Kbuild | 2 + arch/loongarch/include/uapi/asm/unistd.h | 4 +- arch/loongarch/kernel/Makefile.syscalls | 4 + arch/loongarch/kernel/syscall.c | 3 +- arch/m68k/include/asm/unistd.h | 1 - arch/microblaze/include/asm/unistd.h | 2 + arch/mips/include/asm/unistd.h | 1 - arch/nios2/include/asm/Kbuild | 2 + arch/nios2/include/asm/unistd.h | 10 + arch/nios2/include/uapi/asm/Kbuild | 2 + arch/nios2/include/uapi/asm/unistd.h | 14 +- arch/nios2/kernel/Makefile.syscalls | 3 + arch/nios2/kernel/syscall_table.c | 6 +- arch/openrisc/include/asm/Kbuild | 2 + arch/openrisc/include/asm/syscalls.h | 4 - arch/openrisc/include/asm/unistd.h | 8 + arch/openrisc/include/uapi/asm/Kbuild | 2 + arch/openrisc/include/uapi/asm/unistd.h | 15 +- arch/openrisc/kernel/Makefile.syscalls | 3 + arch/openrisc/kernel/sys_call_table.c | 9 +- arch/parisc/include/asm/unistd.h | 1 - arch/powerpc/include/asm/unistd.h | 1 - arch/riscv/include/asm/Kbuild | 3 + arch/riscv/include/asm/syscall_table.h | 7 + arch/riscv/include/asm/unistd.h | 13 +- arch/riscv/include/uapi/asm/Kbuild | 2 + arch/riscv/include/uapi/asm/unistd.h | 41 +- arch/riscv/kernel/Makefile.syscalls | 4 + arch/riscv/kernel/compat_syscall_table.c | 6 +- arch/riscv/kernel/syscall_table.c | 6 +- arch/s390/include/asm/unistd.h | 1 - arch/sh/include/asm/unistd.h | 2 + arch/sparc/include/asm/unistd.h | 2 + arch/um/include/asm/Kbuild | 1 - arch/um/include/asm/bpf_perf_event.h | 3 + arch/x86/include/asm/unistd.h | 1 - arch/xtensa/include/asm/unistd.h | 1 - include/asm-generic/Kbuild | 1 - include/uapi/asm-generic/unistd.h | 4 - kernel/fork.c | 8 +- kernel/sys_ni.c | 2 - scripts/Makefile.asm-generic | 58 -- scripts/Makefile.asm-headers | 98 ++ scripts/syscall.tbl | 404 ++++++++ tools/arch/arm64/include/uapi/asm/unistd.h | 1 - .../arch/loongarch/include/uapi/asm/unistd.h | 1 - tools/include/uapi/asm-generic/unistd.h | 4 - 86 files changed, 1219 insertions(+), 1271 deletions(-) create mode 100644 arch/arc/include/asm/unistd.h create mode 100644 arch/arc/kernel/Makefile.syscalls create mode 100644 arch/arm64/kernel/Makefile.syscalls create mode 100644 arch/arm64/tools/syscall_32.tbl create mode 120000 arch/arm64/tools/syscall_64.tbl create mode 100644 arch/csky/kernel/Makefile.syscalls create mode 100644 arch/hexagon/include/asm/unistd.h create mode 100644 arch/hexagon/kernel/Makefile.syscalls create mode 100644 arch/loongarch/kernel/Makefile.syscalls create mode 100644 arch/nios2/include/asm/unistd.h create mode 100644 arch/nios2/kernel/Makefile.syscalls create mode 100644 arch/openrisc/include/asm/unistd.h create mode 100644 arch/openrisc/kernel/Makefile.syscalls create mode 100644 arch/riscv/include/asm/syscall_table.h create mode 100644 arch/riscv/kernel/Makefile.syscalls create mode 100644 arch/um/include/asm/bpf_perf_event.h delete mode 100644 scripts/Makefile.asm-generic create mode 100644 scripts/Makefile.asm-headers create mode 100644 scripts/syscall.tbl