diff mbox series

wifi: rtw88: Set efuse->ext_lna_5g - fix typo

Message ID 8ccc9e13-0d45-417d-8f88-93a0ad294f77@gmail.com (mailing list archive)
State Accepted
Delegated to: Ping-Ke Shih
Headers show
Series wifi: rtw88: Set efuse->ext_lna_5g - fix typo | expand

Commit Message

Bitterblue Smith July 5, 2024, 10:40 p.m. UTC
efuse->ext_lna_2g is set twice and efuse->ext_lna_5g is not set at all.
Set each one once.

Nothing uses these members right now. They will be used by the RTL8821AU
and RTL8812AU drivers.

Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
---
 drivers/net/wireless/realtek/rtw88/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ping-Ke Shih July 8, 2024, 6:54 a.m. UTC | #1
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> efuse->ext_lna_2g is set twice and efuse->ext_lna_5g is not set at all.
> Set each one once.
> 
> Nothing uses these members right now. They will be used by the RTL8821AU
> and RTL8812AU drivers.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Ping-Ke Shih July 17, 2024, 3:50 a.m. UTC | #2
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> efuse->ext_lna_2g is set twice and efuse->ext_lna_5g is not set at all.
> Set each one once.
> 
> Nothing uses these members right now. They will be used by the RTL8821AU
> and RTL8812AU drivers.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

8fbcaa308591 wifi: rtw88: Set efuse->ext_lna_5g - fix typo

---
https://github.com/pkshih/rtw.git
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
index 7ab7a988b123..9d9d33a4a503 100644
--- a/drivers/net/wireless/realtek/rtw88/main.c
+++ b/drivers/net/wireless/realtek/rtw88/main.c
@@ -2005,7 +2005,7 @@  static int rtw_chip_efuse_info_setup(struct rtw_dev *rtwdev)
 	efuse->ext_pa_2g = efuse->pa_type_2g & BIT(4) ? 1 : 0;
 	efuse->ext_lna_2g = efuse->lna_type_2g & BIT(3) ? 1 : 0;
 	efuse->ext_pa_5g = efuse->pa_type_5g & BIT(0) ? 1 : 0;
-	efuse->ext_lna_2g = efuse->lna_type_5g & BIT(3) ? 1 : 0;
+	efuse->ext_lna_5g = efuse->lna_type_5g & BIT(3) ? 1 : 0;
 
 	if (!is_valid_ether_addr(efuse->addr)) {
 		eth_random_addr(efuse->addr);