| Message ID | 20240709-add_qcs9100_pcie_ep_compatible-v2-1-217742eac32b@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: qcom-ep: Add QCS9100 PCIe ep compatible | expand |
On Tue, Jul 09, 2024 at 10:53:43PM +0800, Tengfei Fan wrote: > Add devicetree bindings support for QCS9100 SoC. It has DMA register > space and dma interrupt to support HDMA. s/dma/DMA/ above for consistency. Add blank line here if this is a paragraph break. > QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p > platform use non-SCMI resource. In the future, the SA8775p platform will > move to use SCMI resources and it will have new sa8775p-related device > tree. Consequently, introduce "qcom,qcs9100-pcie-ep" to describe non-SCMI > based PCIe. s/drived/derived/ This patch doesn't add anything related to SCMI, so this paragraph seems like a distraction. The first paragraph seems a bit of a distraction too, since the patch doesn't say anything about DMA register space or interrupt. > Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > index 46802f7d9482..8012663e7efc 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > @@ -13,6 +13,7 @@ properties: > compatible: > oneOf: > - enum: > + - qcom,qcs9100-pcie-ep > - qcom,sa8775p-pcie-ep > - qcom,sdx55-pcie-ep > - qcom,sm8450-pcie-ep > @@ -203,6 +204,7 @@ allOf: > compatible: > contains: > enum: > + - qcom,qcs9100-pcie-ep > - qcom,sa8775p-pcie-ep > then: > properties: > > -- > 2.25.1 >
On 7/10/2024 12:28 AM, Bjorn Helgaas wrote: > On Tue, Jul 09, 2024 at 10:53:43PM +0800, Tengfei Fan wrote: >> Add devicetree bindings support for QCS9100 SoC. It has DMA register >> space and dma interrupt to support HDMA. > > s/dma/DMA/ above for consistency. This update will be included in the next verion of the patch series. > > Add blank line here if this is a paragraph break. A blank line will be added in the next verion of the patch series. > >> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p >> platform use non-SCMI resource. In the future, the SA8775p platform will >> move to use SCMI resources and it will have new sa8775p-related device >> tree. Consequently, introduce "qcom,qcs9100-pcie-ep" to describe non-SCMI >> based PCIe. > > s/drived/derived/ This update will be included in the next verion of the patch series > > This patch doesn't add anything related to SCMI, so this paragraph > seems like a distraction. This patch is used to support QSC9100. QCS9100 uses non-SCMI resources, so there is nothing related to SCMI in this patch. Only SA8775p will move to use SCMI resources in the future. > > The first paragraph seems a bit of a distraction too, since the patch > doesn't say anything about DMA register space or interrupt. I will update this commit message as follows in the next version of the patch series. "Add devicetree bindings support for QCS9100 PCIe EP compatible." > >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> index 46802f7d9482..8012663e7efc 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> @@ -13,6 +13,7 @@ properties: >> compatible: >> oneOf: >> - enum: >> + - qcom,qcs9100-pcie-ep >> - qcom,sa8775p-pcie-ep >> - qcom,sdx55-pcie-ep >> - qcom,sm8450-pcie-ep >> @@ -203,6 +204,7 @@ allOf: >> compatible: >> contains: >> enum: >> + - qcom,qcs9100-pcie-ep >> - qcom,sa8775p-pcie-ep >> then: >> properties: >> >> -- >> 2.25.1 >>
On 7/10/2024 12:28 AM, Bjorn Helgaas wrote: > On Tue, Jul 09, 2024 at 10:53:43PM +0800, Tengfei Fan wrote: >> Add devicetree bindings support for QCS9100 SoC. It has DMA register >> space and dma interrupt to support HDMA. > > s/dma/DMA/ above for consistency. > > Add blank line here if this is a paragraph break. > >> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p >> platform use non-SCMI resource. In the future, the SA8775p platform will >> move to use SCMI resources and it will have new sa8775p-related device >> tree. Consequently, introduce "qcom,qcs9100-pcie-ep" to describe non-SCMI >> based PCIe. > > s/drived/derived/ > > This patch doesn't add anything related to SCMI, so this paragraph > seems like a distraction. The paragraph can be removed from the commit message in next patchsets. Let me know if others looks good to you or not. > > The first paragraph seems a bit of a distraction too, since the patch > doesn't say anything about DMA register space or interrupt. agree. Suggest to remove the first paragraph as well. > >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> index 46802f7d9482..8012663e7efc 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >> @@ -13,6 +13,7 @@ properties: >> compatible: >> oneOf: >> - enum: >> + - qcom,qcs9100-pcie-ep >> - qcom,sa8775p-pcie-ep >> - qcom,sdx55-pcie-ep >> - qcom,sm8450-pcie-ep >> @@ -203,6 +204,7 @@ allOf: >> compatible: >> contains: >> enum: >> + - qcom,qcs9100-pcie-ep >> - qcom,sa8775p-pcie-ep >> then: >> properties: >> >> -- >> 2.25.1 >>
On 7/10/2024 6:31 PM, Aiqun Yu (Maria) wrote: > > > On 7/10/2024 12:28 AM, Bjorn Helgaas wrote: >> On Tue, Jul 09, 2024 at 10:53:43PM +0800, Tengfei Fan wrote: >>> Add devicetree bindings support for QCS9100 SoC. It has DMA register >>> space and dma interrupt to support HDMA. >> >> s/dma/DMA/ above for consistency. >> >> Add blank line here if this is a paragraph break. >> >>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p >>> platform use non-SCMI resource. In the future, the SA8775p platform will >>> move to use SCMI resources and it will have new sa8775p-related device >>> tree. Consequently, introduce "qcom,qcs9100-pcie-ep" to describe non-SCMI >>> based PCIe. >> >> s/drived/derived/ >> >> This patch doesn't add anything related to SCMI, so this paragraph >> seems like a distraction. > > The paragraph can be removed from the commit message in next patchsets. > Let me know if others looks good to you or not. >> >> The first paragraph seems a bit of a distraction too, since the patch >> doesn't say anything about DMA register space or interrupt. > > agree. Suggest to remove the first paragraph as well. After considering the feedback provided on the subject, We have decided to keep current SA8775p compatible and ABI compatibility in drivers. Let's close this session and ignore all the current patches here. Thank you for your input. >> >>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >>> index 46802f7d9482..8012663e7efc 100644 >>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml >>> @@ -13,6 +13,7 @@ properties: >>> compatible: >>> oneOf: >>> - enum: >>> + - qcom,qcs9100-pcie-ep >>> - qcom,sa8775p-pcie-ep >>> - qcom,sdx55-pcie-ep >>> - qcom,sm8450-pcie-ep >>> @@ -203,6 +204,7 @@ allOf: >>> compatible: >>> contains: >>> enum: >>> + - qcom,qcs9100-pcie-ep >>> - qcom,sa8775p-pcie-ep >>> then: >>> properties: >>> >>> -- >>> 2.25.1 >>> >
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml index 46802f7d9482..8012663e7efc 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml @@ -13,6 +13,7 @@ properties: compatible: oneOf: - enum: + - qcom,qcs9100-pcie-ep - qcom,sa8775p-pcie-ep - qcom,sdx55-pcie-ep - qcom,sm8450-pcie-ep @@ -203,6 +204,7 @@ allOf: compatible: contains: enum: + - qcom,qcs9100-pcie-ep - qcom,sa8775p-pcie-ep then: properties:
Add devicetree bindings support for QCS9100 SoC. It has DMA register space and dma interrupt to support HDMA. QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p platform use non-SCMI resource. In the future, the SA8775p platform will move to use SCMI resources and it will have new sa8775p-related device tree. Consequently, introduce "qcom,qcs9100-pcie-ep" to describe non-SCMI based PCIe. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 2 ++ 1 file changed, 2 insertions(+)