diff mbox series

[1/2] dt-bindings: net: wireless: add ath12k pcie bindings

Message ID ZpV7B9uGVpeTSCzp@windev.fritz.box (mailing list archive)
State Deferred
Delegated to: Kalle Valo
Headers show
Series arm64: dts: qcom: x1e80100-yoga: add wifi calibration variant | expand

Commit Message

Patrick Wildt July 15, 2024, 7:39 p.m. UTC
Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850
for which the calibration data variant may need to be described.

Signed-off-by: Patrick Wildt <patrick@blueri.se>
---
 .../net/wireless/qcom,ath12k-pci.yaml         | 59 +++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml

Comments

Andrew Lunn July 15, 2024, 8:54 p.m. UTC | #1
On Mon, Jul 15, 2024 at 09:39:51PM +0200, Patrick Wildt wrote:
> Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850
> for which the calibration data variant may need to be described.

Hi Patrick

General, the device tree binding and the needed changes to the driver
to implement the binding are in the same patchset. I don't see
anything implementing qcom,ath12k-calibration-variant here? Does the
driver already support this, and you are just fixing up missing
documentation?

	Andrew
Patrick Wildt July 15, 2024, 9:10 p.m. UTC | #2
Am Mon, Jul 15, 2024 at 10:54:18PM +0200 schrieb Andrew Lunn:
> On Mon, Jul 15, 2024 at 09:39:51PM +0200, Patrick Wildt wrote:
> > Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850
> > for which the calibration data variant may need to be described.
> 
> Hi Patrick
> 
> General, the device tree binding and the needed changes to the driver
> to implement the binding are in the same patchset. I don't see
> anything implementing qcom,ath12k-calibration-variant here? Does the
> driver already support this, and you are just fixing up missing
> documentation?
> 
> 	Andrew

Hi there,

technically I could try and make that change, but I don't actually run
this driver or Linux at all; this change is for running OpenBSD on that
machine with a correctly defined device tree.

The realities of Linux being the de facto upstream for device tree
bindings force me to submit changes here so they end up being usable
for other operating systems as well.

I would assume that eventually someone that runs Linux will adjust the
ath12k driver as well, because this kind of binding has been used for
both ath10k and ath11k and this is just a copy with a name change for
ath12k.

Cheers,
Patrick
Konrad Dybcio July 15, 2024, 10:46 p.m. UTC | #3
On 15.07.2024 11:10 PM, Patrick Wildt wrote:
> Am Mon, Jul 15, 2024 at 10:54:18PM +0200 schrieb Andrew Lunn:
>> On Mon, Jul 15, 2024 at 09:39:51PM +0200, Patrick Wildt wrote:
>>> Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850
>>> for which the calibration data variant may need to be described.
>>
>> Hi Patrick
>>
>> General, the device tree binding and the needed changes to the driver
>> to implement the binding are in the same patchset. I don't see
>> anything implementing qcom,ath12k-calibration-variant here? Does the
>> driver already support this, and you are just fixing up missing
>> documentation?
>>
>> 	Andrew
> 
> Hi there,
> 
> technically I could try and make that change, but I don't actually run
> this driver or Linux at all; this change is for running OpenBSD on that
> machine with a correctly defined device tree.
> 
> The realities of Linux being the de facto upstream for device tree
> bindings force me to submit changes here so they end up being usable
> for other operating systems as well.
> 
> I would assume that eventually someone that runs Linux will adjust the
> ath12k driver as well, because this kind of binding has been used for
> both ath10k and ath11k and this is just a copy with a name change for
> ath12k.

Paraphrasing a certain company.. Linux <3 OpenBSD!

Since as you mentioned Linux is the de facto upstream for dt-bindings,
many people identify those two.. I think a solution that would keep
everyone reasonably happy is dropping a line about your usage in the
cover letter

Konrad
Krzysztof Kozlowski July 16, 2024, 9:55 a.m. UTC | #4
On 15/07/2024 21:39, Patrick Wildt wrote:
> Add devicetree bindings for Qualcomm ath12k PCIe devices such as WCN7850
> for which the calibration data variant may need to be described.
> 
> Signed-off-by: Patrick Wildt <patrick@blueri.se>
> ---
>  .../net/wireless/qcom,ath12k-pci.yaml         | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
> new file mode 100644
> index 000000000000..8f18868ee726
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (c) 2024 Linaro Limited
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies ath12k wireless devices (PCIe)
> +
> +maintainers:
> +  - Kalle Valo <kvalo@kernel.org>
> +  - Jeff Johnson <jjohnson@kernel.org>
> +
> +description: |
> +  Qualcomm Technologies IEEE 802.11ax PCIe devices
> +
> +properties:
> +  compatible:
> +    enum:
> +      - pci17cb,1107  # WCN7850

That's a duplicate of:
https://lore.kernel.org/all/20240605122106.23818-1-brgl@bgdev.pl/

AFAIK, this was already merged. I don't get why after ~1 month it is not
in the linux-next.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
new file mode 100644
index 000000000000..8f18868ee726
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath12k-pci.yaml
@@ -0,0 +1,59 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (c) 2024 Linaro Limited
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/qcom,ath12k-pci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies ath12k wireless devices (PCIe)
+
+maintainers:
+  - Kalle Valo <kvalo@kernel.org>
+  - Jeff Johnson <jjohnson@kernel.org>
+
+description: |
+  Qualcomm Technologies IEEE 802.11ax PCIe devices
+
+properties:
+  compatible:
+    enum:
+      - pci17cb,1107  # WCN7850
+
+  reg:
+    maxItems: 1
+
+  qcom,ath12k-calibration-variant:
+    $ref: /schemas/types.yaml#/definitions/string
+    description: |
+      string to uniquely identify variant of the calibration data for designs
+      with colliding bus and device ids
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    pcie {
+        #address-cells = <3>;
+        #size-cells = <2>;
+
+        pcie@0 {
+            device_type = "pci";
+            reg = <0x0 0x0 0x0 0x0 0x0>;
+            #address-cells = <3>;
+            #size-cells = <2>;
+            ranges;
+
+            bus-range = <0x01 0xff>;
+
+            wifi@0 {
+                compatible = "pci17cb,1107";
+                reg = <0x10000 0x0 0x0 0x0 0x0>;
+
+                qcom,ath12k-calibration-variant = "LES790";
+            };
+        };
+    };