| Message ID | 20240726110355.2181563-2-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce ASPEED AST27XX BMC SoC | expand |
On 26/07/2024 13:03, Kevin Chen wrote:
> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>
Missing commit msg.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Best regards,
Krzysztof
Hi Krzk, I will speperate clock part in the v3 patch into Ryan's clock series. >Missing commit msg. > >Please use subject prefixes matching the subsystem. You can get them for >example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >your patch is touching. For bindings, the preferred subjects are >explained here: >https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > >A nit, subject: drop second/last, redundant "bindings for". The >"dt-bindings" prefix is already stating that these are bindings. >See also: >https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Agree, already fixed in another commit in Ryan's series. [1/4] dt-bindings: mfd: aspeed: support for AST2700 - Patchwork (kernel.org)<https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-2-ryan_chen@aspeedtech.com/> -- Best Regards, Kevin. Chen
Hi Krzk, I will separate clock part in the v3 patch into Ryan's clock series. > > Missing commit msg. > > Please use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your > patch is touching. For bindings, the preferred subjects are explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patch > es.html#i-for-patch-submitters > > A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" > prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bin > dings/submitting-patches.rst#L18 Agree, already fixed in another commit in Ryan's series. https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-2-ryan_chen@aspeedtech.com/ > > > > Best regards, > Krzysztof -- Best Regards, Kevin.Chen ************* Email Confidentiality Notice ******************** 免責聲明: 本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作! DISCLAIMER: This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
On 15/08/2024 07:50, Kevin Chen wrote: > Hi Krzk, > > I will speperate clock part in the v3 patch into Ryan's clock series. > >> Missing commit msg. >> >> Please use subject prefixes matching the subsystem. You can get them for >> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >> your patch is touching. For bindings, the preferred subjects are >> explained here: >> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters >> >> A nit, subject: drop second/last, redundant "bindings for". The >> "dt-bindings" prefix is already stating that these are bindings. >> See also: >> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > Agree, already fixed in another commit in Ryan's series. > [1/4] dt-bindings: mfd: aspeed: support fo Just to make it clear: you responded after 2.5 months. This patchset is neither in my mailbox nor in my brain. Best regards, Krzysztof
On 07/10/2024 13:03, Krzysztof Kozlowski wrote: > On 15/08/2024 07:50, Kevin Chen wrote: >> Hi Krzk, >> >> I will speperate clock part in the v3 patch into Ryan's clock series. >> >>> Missing commit msg. >>> >>> Please use subject prefixes matching the subsystem. You can get them for >>> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >>> your patch is touching. For bindings, the preferred subjects are >>> explained here: >>> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters >>> >>> A nit, subject: drop second/last, redundant "bindings for". The >>> "dt-bindings" prefix is already stating that these are bindings. >>> See also: >>> https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 >> Agree, already fixed in another commit in Ryan's series. >> [1/4] dt-bindings: mfd: aspeed: support fo > > Just to make it clear: you responded after 2.5 months. This patchset is > neither in my mailbox nor in my brain. Uh, this was supposed to be replied to your recent emails. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml index 86ee69c0f45b..3fc991e4514d 100644 --- a/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml +++ b/Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml @@ -13,6 +13,7 @@ description: maintainers: - Joel Stanley <joel@jms.id.au> - Andrew Jeffery <andrew@aj.id.au> + - Kevin Chen <kevin_chen@aspeedtech.com> properties: compatible: @@ -21,6 +22,7 @@ properties: - aspeed,ast2400-scu - aspeed,ast2500-scu - aspeed,ast2600-scu + - aspeed,ast2700-scu - const: syscon - const: simple-mfd @@ -76,6 +78,7 @@ patternProperties: - aspeed,ast2400-silicon-id - aspeed,ast2500-silicon-id - aspeed,ast2600-silicon-id + - aspeed,ast2700-silicon-id - const: aspeed,silicon-id reg:
Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> --- Documentation/devicetree/bindings/mfd/aspeed,ast2x00-scu.yaml | 3 +++ 1 file changed, 3 insertions(+)