| Message ID | 20240802090544.2741206-11-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce ASPEED AST27XX BMC SoC | expand |
On 02/08/2024 11:05, Kevin Chen wrote: > Add EVB board of AST2700 in ASPEED G7 Architecture. > > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > --- > arch/arm64/boot/dts/aspeed/Makefile | 4 ++ > arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 58 ++++++++++++++++++++++ > 2 files changed, 62 insertions(+) > create mode 100644 arch/arm64/boot/dts/aspeed/Makefile > create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts > > diff --git a/arch/arm64/boot/dts/aspeed/Makefile b/arch/arm64/boot/dts/aspeed/Makefile > new file mode 100644 > index 000000000000..ffe7e15017cc > --- /dev/null > +++ b/arch/arm64/boot/dts/aspeed/Makefile > @@ -0,0 +1,4 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +dtb-$(CONFIG_ARCH_ASPEED) += \ > + ast2700-evb.dtb > diff --git a/arch/arm64/boot/dts/aspeed/ast2700-evb.dts b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts > new file mode 100644 > index 000000000000..09c9569c0f7b > --- /dev/null > +++ b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts > @@ -0,0 +1,58 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > + > +/dts-v1/; > + > +#include "aspeed-g7.dtsi" > +#include <dt-bindings/gpio/aspeed-gpio.h> > + > +/ { > + model = "AST2700A1-EVB"; > + compatible = "aspeed,ast2700-evb", "aspeed,ast2700"; > + > + aliases { > + serial4 = &uart4; > + }; > + > + chosen { > + bootargs = "console=ttyS4,115200n8"; > + stdout-path = &uart4; <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/aspeed/Makefile b/arch/arm64/boot/dts/aspeed/Makefile new file mode 100644 index 000000000000..ffe7e15017cc --- /dev/null +++ b/arch/arm64/boot/dts/aspeed/Makefile @@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0 + +dtb-$(CONFIG_ARCH_ASPEED) += \ + ast2700-evb.dtb diff --git a/arch/arm64/boot/dts/aspeed/ast2700-evb.dts b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts new file mode 100644 index 000000000000..09c9569c0f7b --- /dev/null +++ b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts @@ -0,0 +1,58 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +/dts-v1/; + +#include "aspeed-g7.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> + +/ { + model = "AST2700A1-EVB"; + compatible = "aspeed,ast2700-evb", "aspeed,ast2700"; + + aliases { + serial4 = &uart4; + }; + + chosen { + bootargs = "console=ttyS4,115200n8"; + stdout-path = &uart4; + }; + + firmware { + optee: optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; + + memory@400000000 { + device_type = "memory"; + reg = <0x4 0x00000000 0x0 0x40000000>; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + mcu_fw: mcu-firmware@42fe00000 { + reg = <0x4 0x2fe00000 0x0 0x200000>; + no-map; + }; + + atf: trusted-firmware-a@430000000 { + reg = <0x4 0x30000000 0x0 0x80000>; + no-map; + }; + + optee_core: optee_core@430080000 { + reg = <0x4 0x30080000 0x0 0x1000000>; + no-map; + }; + }; +}; + +&uart4 { + status = "okay"; +}; +
Add EVB board of AST2700 in ASPEED G7 Architecture. Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> --- arch/arm64/boot/dts/aspeed/Makefile | 4 ++ arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 58 ++++++++++++++++++++++ 2 files changed, 62 insertions(+) create mode 100644 arch/arm64/boot/dts/aspeed/Makefile create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts