| Message ID | 20240813190306.154943-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | dt-bindings: net: ath11k: document the inputs of the ath11k on WCN6855 | expand |
On Tue, 13 Aug 2024 21:03:05 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Describe the inputs from the PMU of the ath11k module on WCN6855. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > .../net/wireless/qcom,ath11k-pci.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddrfacmn-supply' is a required property from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddaon-supply' is a required property from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddwlcx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddwlmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddrfa0p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddrfa1p2-supply' is a required property from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddrfa1p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddpcie0p9-supply' is a required property from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddpcie1p8-supply' is a required property from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240813190306.154943-1-brgl@bgdev.pl The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Aug 13, 2024 at 10:59 PM Rob Herring (Arm) <robh@kernel.org> wrote: > > > On Tue, 13 Aug 2024 21:03:05 +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Describe the inputs from the PMU of the ath11k module on WCN6855. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > --- > > .../net/wireless/qcom,ath11k-pci.yaml | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddrfacmn-supply' is a required property > from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddaon-supply' is a required property > from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddwlcx-supply' is a required property > from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddwlmx-supply' is a required property > from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddrfa0p8-supply' is a required property > from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddrfa1p2-supply' is a required property > from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddrfa1p8-supply' is a required property > from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddpcie0p9-supply' is a required property > from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.example.dtb: wifi@0: 'vddpcie1p8-supply' is a required property > from schema $id: http://devicetree.org/schemas/net/wireless/qcom,ath11k-pci.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240813190306.154943-1-brgl@bgdev.pl > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Sorry, I ran dtbs_check but forgot to test the binding document itself. Bart
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml index 8675d7d0215c..404974d77826 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml @@ -50,6 +50,9 @@ properties: vddrfa1p7-supply: description: VDD_RFA_1P7 supply regulator handle + vddrfa1p8-supply: + description: VDD_RFA_1P8 supply regulator handle + vddpcie0p9-supply: description: VDD_PCIE_0P9 supply regulator handle @@ -77,6 +80,22 @@ allOf: - vddrfa1p7-supply - vddpcie0p9-supply - vddpcie1p8-supply + - if: + properties: + compatible: + contains: + const: pci17cb,1103 + then: + required: + - vddrfacmn-supply + - vddaon-supply + - vddwlcx-supply + - vddwlmx-supply + - vddrfa0p8-supply + - vddrfa1p2-supply + - vddrfa1p8-supply + - vddpcie0p9-supply + - vddpcie1p8-supply additionalProperties: false