| Message ID | 20240822205941.643187-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | [next] PCI: rcar-gen4: make read-only const array check_addr static | expand |
On Thu, Aug 22, 2024 at 10:59 PM Colin Ian King <colin.i.king@gmail.com> wrote: > Don't populate the const read-only array check_addr on the stack at > run time, instead make it static. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hello, > Don't populate the const read-only array check_addr on the stack at > run time, instead make it static. Applied to controller/rcar-gen4, thank you! [1/1] PCI: rcar-gen4: Make read-only const array check_addr static https://git.kernel.org/pci/pci/c/5603a3491b36 Krzysztof
diff --git a/drivers/pci/controller/dwc/pcie-rcar-gen4.c b/drivers/pci/controller/dwc/pcie-rcar-gen4.c index f0f3ebd1a033..c0ea6b02f1cd 100644 --- a/drivers/pci/controller/dwc/pcie-rcar-gen4.c +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4.c @@ -606,7 +606,9 @@ static int rcar_gen4_pcie_reg_test_bit(struct rcar_gen4_pcie *rcar, static int rcar_gen4_pcie_download_phy_firmware(struct rcar_gen4_pcie *rcar) { /* The check_addr values are magical numbers in the datasheet */ - const u32 check_addr[] = { 0x00101018, 0x00101118, 0x00101021, 0x00101121}; + static const u32 check_addr[] = { + 0x00101018, 0x00101118, 0x00101021, 0x00101121 + }; struct dw_pcie *dw = &rcar->dw; const struct firmware *fw; unsigned int i, timeout;
Don't populate the const read-only array check_addr on the stack at run time, instead make it static. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/pci/controller/dwc/pcie-rcar-gen4.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)