diff mbox series

[net] RDMA/mana_ib: fix a bug in calculating the wrong page table index when 64kb page table is used

Message ID 1724875569-12912-1-git-send-email-longli@linuxonhyperv.com (mailing list archive)
State Not Applicable
Headers show
Series [net] RDMA/mana_ib: fix a bug in calculating the wrong page table index when 64kb page table is used | expand

Commit Message

Long Li Aug. 28, 2024, 8:06 p.m. UTC 
From: Long Li <longli@microsoft.com>

MANA hardware uses 4k page size. When calculating the page table index,
it should use the hardware page size, not the system page size.

Cc: stable@vger.kernel.org
Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
Signed-off-by: Long Li <longli@microsoft.com>
---
 drivers/infiniband/hw/mana/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Romanovsky Aug. 29, 2024, 10:24 a.m. UTC | #1 
On Wed, Aug 28, 2024 at 01:06:08PM -0700, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
> 
> MANA hardware uses 4k page size. When calculating the page table index,
> it should use the hardware page size, not the system page size.
> 
> Cc: stable@vger.kernel.org
> Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
>  drivers/infiniband/hw/mana/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

These two patches are RDMA ones, please fix the target tree, rephrase
the commit title to simplify it and resend.

Thanks

> 
> diff --git a/drivers/infiniband/hw/mana/main.c b/drivers/infiniband/hw/mana/main.c
> index d13abc954d2a..f68f54aea820 100644
> --- a/drivers/infiniband/hw/mana/main.c
> +++ b/drivers/infiniband/hw/mana/main.c
> @@ -383,7 +383,7 @@ static int mana_ib_gd_create_dma_region(struct mana_ib_dev *dev, struct ib_umem
>  
>  	create_req->length = umem->length;
>  	create_req->offset_in_page = ib_umem_dma_offset(umem, page_sz);
> -	create_req->gdma_page_type = order_base_2(page_sz) - PAGE_SHIFT;
> +	create_req->gdma_page_type = order_base_2(page_sz) - MANA_PAGE_SHIFT;
>  	create_req->page_count = num_pages_total;
>  
>  	ibdev_dbg(&dev->ib_dev, "size_dma_region %lu num_pages_total %lu\n",
> -- 
> 2.17.1
>
Long Li Aug. 30, 2024, 12:56 a.m. UTC | #2 
> Subject: Re: [PATCH net] RDMA/mana_ib: fix a bug in calculating the wrong
> page table index when 64kb page table is used
> 
> On Wed, Aug 28, 2024 at 01:06:08PM -0700, longli@linuxonhyperv.com
> wrote:
> > From: Long Li <longli@microsoft.com>
> >
> > MANA hardware uses 4k page size. When calculating the page table
> > index, it should use the hardware page size, not the system page size.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure
> > Network Adapter")
> > Signed-off-by: Long Li <longli@microsoft.com>
> > ---
> >  drivers/infiniband/hw/mana/main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> These two patches are RDMA ones, please fix the target tree, rephrase the
> commit title to simplify it and resend.
> 
> Thanks

I'm sending v2 to have those fixed.

Long
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mana/main.c b/drivers/infiniband/hw/mana/main.c
index d13abc954d2a..f68f54aea820 100644
--- a/drivers/infiniband/hw/mana/main.c
+++ b/drivers/infiniband/hw/mana/main.c
@@ -383,7 +383,7 @@  static int mana_ib_gd_create_dma_region(struct mana_ib_dev *dev, struct ib_umem
 
 	create_req->length = umem->length;
 	create_req->offset_in_page = ib_umem_dma_offset(umem, page_sz);
-	create_req->gdma_page_type = order_base_2(page_sz) - PAGE_SHIFT;
+	create_req->gdma_page_type = order_base_2(page_sz) - MANA_PAGE_SHIFT;
 	create_req->page_count = num_pages_total;
 
 	ibdev_dbg(&dev->ib_dev, "size_dma_region %lu num_pages_total %lu\n",