[v8,00/11] PCI: imx6: Fix\rename\clean up and add lut information for imx95

Message

Frank Li July 29, 2024, 8:18 p.m. UTC

Fixed 8mp EP mode problem.

imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid
confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to
pci-imx.c to avoid confuse.

Using callback to reduce switch case for core reset and refclk.

Base on linux 6.11-rc1

To: Richard Zhu <[e-mail]>
To: Lucas Stach <[e-mail]>
To: Lorenzo Pieralisi <[e-mail]>
To: Krzysztof Wilczyński <[e-mail]>
To: Rob Herring <[e-mail]>
To: Bjorn Helgaas <[e-mail]>
To: Shawn Guo <[e-mail]>
To: Sascha Hauer <[e-mail]>
To: Pengutronix Kernel Team <[e-mail]>
To: Fabio Estevam <[e-mail]>
To: NXP Linux Team <[e-mail]>
To: Philipp Zabel <[e-mail]>
To: Liam Girdwood <[e-mail]>
To: Mark Brown <[e-mail]>
To: Manivannan Sadhasivam <[e-mail]>
To: Krzysztof Kozlowski <[e-mail]>
To: Conor Dooley <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Signed-off-by: Frank Li <[e-mail]>

Changes in v8:                                                             
- Rebase to 6.11-rc1
- Add Mani's review tags for 2, 6, 8, 9, 10
- Add fix patch PCI: imx6: Fix missing call to phy_power_off() in error handling
- keep enable_ref_clk(), I will add more code to make disabe/enable symtric
- Link to v7: https://lore.kernel.org/r/[e-mail]

Changes in v7:
- rework commit message for PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI 
- Add Mani's review tags for patch 1, 5
- Fix errata number in commit message for patch 6
- replace set_ref_clk with enable_ref_clk in patch 4
- using regmap_set(clear)_bits in patch 4
- Use exactly the same logic with original code at patch 4
- Add errata doc link for patch 6
- Fix miss "." at comment form patch 6.
- order include header for patch 9
- use cap register to set_speed for patch 9
- use PCIe in error msg for patch 9
- Remove reduntant ':' at patch 9' subject.
- Change range to ranges for patch 10.
- Change error code to -ENODEV for patch 10.
- Link to v6: https://lore.kernel.org/r/[e-mail]

Changes in v6:
- Base on Linux 6.10-rc1 by Bjorn's required.
- Remove imx95 LUT patch because it need more time to work out the
solution. This patch add 8qxp and 8qm and support and some bug fixes.
- Link to v5: https://lore.kernel.org/r/[e-mail]

Changes in v5:
- Rebase to linux-pci next. fix conflict with gpiod change
- Add rob and cornor's review tag
- Link to v4: https://lore.kernel.org/r/[e-mail]

Changes in v4:
- Improve comment message for patch 1 and 2.
- Rework commit message for patch 3 and add mani's review tag
- Remove file rename patch and update maintainer patch
- [PATCH v3 06/11] PCI: imx: Simplify switch-case logic by involve set_ref_clk callback
	remove extra space.
	keep original comments format (wrap at 80 column width)
	update error message "'Failed to enable PCIe REFCLK'"
- PATCH v3 07/11] PCI: imx: Simplify switch-case logic by involve core_reset callback
	keep exact the logic as original code
- Add patch to update comment about workaround ERR010728
- Add patch about help function imx_pcie_match_device()
- Using bus device notify to update LUT information for imx95 to avoid
parse iommu-map and msi-map in driver code.  Bus notify will better and
only update lut when device added.
- split patch call PHY interface function.
- Improve commit message for imx8q. remove local-address dts proptery. and
use standard "range" to convert cpu address to bus address.
- Check entry in cpu_fix function is too late. Check it at probe
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Add an EP fixed patch
  PCI: imx6: Fix PCIe link down when i.MX8MM and i.MX8MP PCIe is EP mode
  PCI: imx6: Fix i.MX8MP PCIe EP can not trigger MSI
- Add 8qxp rc support
dt-bing yaml pass binding check
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,imx6q-pcie.yaml
  LINT    Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dts
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  DTC_CHK Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dtb

- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- remove file to 'pcie-imx.c'
- keep CONFIG unchange.
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Frank Li (7):
      PCI: imx6: Fix missing call to phy_power_off() in error handling
      PCI: imx6: Rename imx6_* with imx_*
      PCI: imx6: Introduce SoC specific callbacks for controlling REFCLK
      PCI: imx6: Simplify switch-case logic by involve core_reset callback
      PCI: imx6: Improve comment for workaround ERR010728
      PCI: imx6: Consolidate redundant if-checks
      PCI: imx6: Call common PHY API to set mode, speed, and submode

Richard Zhu (4):
      PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP
      PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI
      dt-bindings: imx6q-pcie: Add i.MX8Q pcie compatible string
      PCI: imx6: Add i.MX8Q PCIe root complex (RC) support

 .../devicetree/bindings/pci/fsl,imx6q-pcie.yaml    |  16 +
 drivers/pci/controller/dwc/pci-imx6.c              | 989 +++++++++++----------
 2 files changed, 542 insertions(+), 463 deletions(-)
---
base-commit: c428091cdcf7f368ad9884f8caa68b79cd6c333a
change-id: 20240227-pci2_upstream-0cdd19a15163

Best regards,
---
Frank Li <[e-mail]>

Comments

Frank Li Aug. 6, 2024, 8:33 p.m. UTC | #1

On Mon, Jul 29, 2024 at 04:18:07PM -0400, Frank Li wrote:
> Fixed 8mp EP mode problem.
>
> imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid
> confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to
> pci-imx.c to avoid confuse.
>
> Using callback to reduce switch case for core reset and refclk.
>
> Base on linux 6.11-rc1
>
> To: Richard Zhu <[e-mail]>
> To: Lucas Stach <[e-mail]>
> To: Lorenzo Pieralisi <[e-mail]>
> To: Krzysztof Wilczyński <[e-mail]>
> To: Rob Herring <[e-mail]>
> To: Bjorn Helgaas <[e-mail]>
> To: Shawn Guo <[e-mail]>
> To: Sascha Hauer <[e-mail]>
> To: Pengutronix Kernel Team <[e-mail]>
> To: Fabio Estevam <[e-mail]>
> To: NXP Linux Team <[e-mail]>
> To: Philipp Zabel <[e-mail]>
> To: Liam Girdwood <[e-mail]>
> To: Mark Brown <[e-mail]>
> To: Manivannan Sadhasivam <[e-mail]>
> To: Krzysztof Kozlowski <[e-mail]>
> To: Conor Dooley <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Signed-off-by: Frank Li <[e-mail]>
>
> Changes in v8:
> - Rebase to 6.11-rc1
> - Add Mani's review tags for 2, 6, 8, 9, 10
> - Add fix patch PCI: imx6: Fix missing call to phy_power_off() in error handling
> - keep enable_ref_clk(), I will add more code to make disabe/enable symtric
> - Link to v7: https://lore.kernel.org/r/[e-mail]


Manivannan:

	Do you have chance to review these again? Only few patch without
your review tag.

Frank

>
> Changes in v7:
> - rework commit message for PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI
> - Add Mani's review tags for patch 1, 5
> - Fix errata number in commit message for patch 6
> - replace set_ref_clk with enable_ref_clk in patch 4
> - using regmap_set(clear)_bits in patch 4
> - Use exactly the same logic with original code at patch 4
> - Add errata doc link for patch 6
> - Fix miss "." at comment form patch 6.
> - order include header for patch 9
> - use cap register to set_speed for patch 9
> - use PCIe in error msg for patch 9
> - Remove reduntant ':' at patch 9' subject.
> - Change range to ranges for patch 10.
> - Change error code to -ENODEV for patch 10.
> - Link to v6: https://lore.kernel.org/r/[e-mail]
>
> Changes in v6:
> - Base on Linux 6.10-rc1 by Bjorn's required.
> - Remove imx95 LUT patch because it need more time to work out the
> solution. This patch add 8qxp and 8qm and support and some bug fixes.
> - Link to v5: https://lore.kernel.org/r/[e-mail]
>
> Changes in v5:
> - Rebase to linux-pci next. fix conflict with gpiod change
> - Add rob and cornor's review tag
> - Link to v4: https://lore.kernel.org/r/[e-mail]
>
> Changes in v4:
> - Improve comment message for patch 1 and 2.
> - Rework commit message for patch 3 and add mani's review tag
> - Remove file rename patch and update maintainer patch
> - [PATCH v3 06/11] PCI: imx: Simplify switch-case logic by involve set_ref_clk callback
> 	remove extra space.
> 	keep original comments format (wrap at 80 column width)
> 	update error message "'Failed to enable PCIe REFCLK'"
> - PATCH v3 07/11] PCI: imx: Simplify switch-case logic by involve core_reset callback
> 	keep exact the logic as original code
> - Add patch to update comment about workaround ERR010728
> - Add patch about help function imx_pcie_match_device()
> - Using bus device notify to update LUT information for imx95 to avoid
> parse iommu-map and msi-map in driver code.  Bus notify will better and
> only update lut when device added.
> - split patch call PHY interface function.
> - Improve commit message for imx8q. remove local-address dts proptery. and
> use standard "range" to convert cpu address to bus address.
> - Check entry in cpu_fix function is too late. Check it at probe
> - Link to v3: https://lore.kernel.org/r/[e-mail]
>
> Changes in v3:
> - Add an EP fixed patch
>   PCI: imx6: Fix PCIe link down when i.MX8MM and i.MX8MP PCIe is EP mode
>   PCI: imx6: Fix i.MX8MP PCIe EP can not trigger MSI
> - Add 8qxp rc support
> dt-bing yaml pass binding check
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,imx6q-pcie.yaml
>   LINT    Documentation/devicetree/bindings
>   DTEX    Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dts
>   CHKDT   Documentation/devicetree/bindings/processed-schema.json
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>   DTC_CHK Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dtb
>
> - Link to v2: https://lore.kernel.org/r/[e-mail]
>
> Changes in v2:
> - remove file to 'pcie-imx.c'
> - keep CONFIG unchange.
> - Link to v1: https://lore.kernel.org/r/[e-mail]
>
> ---
> Frank Li (7):
>       PCI: imx6: Fix missing call to phy_power_off() in error handling
>       PCI: imx6: Rename imx6_* with imx_*
>       PCI: imx6: Introduce SoC specific callbacks for controlling REFCLK
>       PCI: imx6: Simplify switch-case logic by involve core_reset callback
>       PCI: imx6: Improve comment for workaround ERR010728
>       PCI: imx6: Consolidate redundant if-checks
>       PCI: imx6: Call common PHY API to set mode, speed, and submode
>
> Richard Zhu (4):
>       PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP
>       PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI
>       dt-bindings: imx6q-pcie: Add i.MX8Q pcie compatible string
>       PCI: imx6: Add i.MX8Q PCIe root complex (RC) support
>
>  .../devicetree/bindings/pci/fsl,imx6q-pcie.yaml    |  16 +
>  drivers/pci/controller/dwc/pci-imx6.c              | 989 +++++++++++----------
>  2 files changed, 542 insertions(+), 463 deletions(-)
> ---
> base-commit: c428091cdcf7f368ad9884f8caa68b79cd6c333a
> change-id: 20240227-pci2_upstream-0cdd19a15163
>
> Best regards,
> ---
> Frank Li <[e-mail]>
>

Manivannan Sadhasivam Aug. 7, 2024, 2:38 a.m. UTC | #2

On Tue, Aug 06, 2024 at 04:33:38PM -0400, Frank Li wrote:
> On Mon, Jul 29, 2024 at 04:18:07PM -0400, Frank Li wrote:
> > Fixed 8mp EP mode problem.
> >
> > imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid
> > confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to
> > pci-imx.c to avoid confuse.
> >
> > Using callback to reduce switch case for core reset and refclk.
> >
> > Base on linux 6.11-rc1
> >
> > To: Richard Zhu <[e-mail]>
> > To: Lucas Stach <[e-mail]>
> > To: Lorenzo Pieralisi <[e-mail]>
> > To: Krzysztof Wilczyński <[e-mail]>
> > To: Rob Herring <[e-mail]>
> > To: Bjorn Helgaas <[e-mail]>
> > To: Shawn Guo <[e-mail]>
> > To: Sascha Hauer <[e-mail]>
> > To: Pengutronix Kernel Team <[e-mail]>
> > To: Fabio Estevam <[e-mail]>
> > To: NXP Linux Team <[e-mail]>
> > To: Philipp Zabel <[e-mail]>
> > To: Liam Girdwood <[e-mail]>
> > To: Mark Brown <[e-mail]>
> > To: Manivannan Sadhasivam <[e-mail]>
> > To: Krzysztof Kozlowski <[e-mail]>
> > To: Conor Dooley <[e-mail]>
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Signed-off-by: Frank Li <[e-mail]>
> >
> > Changes in v8:
> > - Rebase to 6.11-rc1
> > - Add Mani's review tags for 2, 6, 8, 9, 10
> > - Add fix patch PCI: imx6: Fix missing call to phy_power_off() in error handling
> > - keep enable_ref_clk(), I will add more code to make disabe/enable symtric
> > - Link to v7: https://lore.kernel.org/r/[e-mail]
> 
> 
> Manivannan:
> 
> 	Do you have chance to review these again? Only few patch without
> your review tag.
> 

Done, series LGTM.

- Mani

> Frank
> 
> >
> > Changes in v7:
> > - rework commit message for PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI
> > - Add Mani's review tags for patch 1, 5
> > - Fix errata number in commit message for patch 6
> > - replace set_ref_clk with enable_ref_clk in patch 4
> > - using regmap_set(clear)_bits in patch 4
> > - Use exactly the same logic with original code at patch 4
> > - Add errata doc link for patch 6
> > - Fix miss "." at comment form patch 6.
> > - order include header for patch 9
> > - use cap register to set_speed for patch 9
> > - use PCIe in error msg for patch 9
> > - Remove reduntant ':' at patch 9' subject.
> > - Change range to ranges for patch 10.
> > - Change error code to -ENODEV for patch 10.
> > - Link to v6: https://lore.kernel.org/r/[e-mail]
> >
> > Changes in v6:
> > - Base on Linux 6.10-rc1 by Bjorn's required.
> > - Remove imx95 LUT patch because it need more time to work out the
> > solution. This patch add 8qxp and 8qm and support and some bug fixes.
> > - Link to v5: https://lore.kernel.org/r/[e-mail]
> >
> > Changes in v5:
> > - Rebase to linux-pci next. fix conflict with gpiod change
> > - Add rob and cornor's review tag
> > - Link to v4: https://lore.kernel.org/r/[e-mail]
> >
> > Changes in v4:
> > - Improve comment message for patch 1 and 2.
> > - Rework commit message for patch 3 and add mani's review tag
> > - Remove file rename patch and update maintainer patch
> > - [PATCH v3 06/11] PCI: imx: Simplify switch-case logic by involve set_ref_clk callback
> > 	remove extra space.
> > 	keep original comments format (wrap at 80 column width)
> > 	update error message "'Failed to enable PCIe REFCLK'"
> > - PATCH v3 07/11] PCI: imx: Simplify switch-case logic by involve core_reset callback
> > 	keep exact the logic as original code
> > - Add patch to update comment about workaround ERR010728
> > - Add patch about help function imx_pcie_match_device()
> > - Using bus device notify to update LUT information for imx95 to avoid
> > parse iommu-map and msi-map in driver code.  Bus notify will better and
> > only update lut when device added.
> > - split patch call PHY interface function.
> > - Improve commit message for imx8q. remove local-address dts proptery. and
> > use standard "range" to convert cpu address to bus address.
> > - Check entry in cpu_fix function is too late. Check it at probe
> > - Link to v3: https://lore.kernel.org/r/[e-mail]
> >
> > Changes in v3:
> > - Add an EP fixed patch
> >   PCI: imx6: Fix PCIe link down when i.MX8MM and i.MX8MP PCIe is EP mode
> >   PCI: imx6: Fix i.MX8MP PCIe EP can not trigger MSI
> > - Add 8qxp rc support
> > dt-bing yaml pass binding check
> > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,imx6q-pcie.yaml
> >   LINT    Documentation/devicetree/bindings
> >   DTEX    Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dts
> >   CHKDT   Documentation/devicetree/bindings/processed-schema.json
> >   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> >   DTC_CHK Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.example.dtb
> >
> > - Link to v2: https://lore.kernel.org/r/[e-mail]
> >
> > Changes in v2:
> > - remove file to 'pcie-imx.c'
> > - keep CONFIG unchange.
> > - Link to v1: https://lore.kernel.org/r/[e-mail]
> >
> > ---
> > Frank Li (7):
> >       PCI: imx6: Fix missing call to phy_power_off() in error handling
> >       PCI: imx6: Rename imx6_* with imx_*
> >       PCI: imx6: Introduce SoC specific callbacks for controlling REFCLK
> >       PCI: imx6: Simplify switch-case logic by involve core_reset callback
> >       PCI: imx6: Improve comment for workaround ERR010728
> >       PCI: imx6: Consolidate redundant if-checks
> >       PCI: imx6: Call common PHY API to set mode, speed, and submode
> >
> > Richard Zhu (4):
> >       PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP
> >       PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI
> >       dt-bindings: imx6q-pcie: Add i.MX8Q pcie compatible string
> >       PCI: imx6: Add i.MX8Q PCIe root complex (RC) support
> >
> >  .../devicetree/bindings/pci/fsl,imx6q-pcie.yaml    |  16 +
> >  drivers/pci/controller/dwc/pci-imx6.c              | 989 +++++++++++----------
> >  2 files changed, 542 insertions(+), 463 deletions(-)
> > ---
> > base-commit: c428091cdcf7f368ad9884f8caa68b79cd6c333a
> > change-id: 20240227-pci2_upstream-0cdd19a15163
> >
> > Best regards,
> > ---
> > Frank Li <[e-mail]>
> >

Frank Li Aug. 15, 2024, 2:56 p.m. UTC | #3

On Wed, Aug 07, 2024 at 08:08:14AM +0530, Manivannan Sadhasivam wrote:
> On Tue, Aug 06, 2024 at 04:33:38PM -0400, Frank Li wrote:
> > On Mon, Jul 29, 2024 at 04:18:07PM -0400, Frank Li wrote:
> > > Fixed 8mp EP mode problem.
> > >
> > > imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid
> > > confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to
> > > pci-imx.c to avoid confuse.
> > >
> > > Using callback to reduce switch case for core reset and refclk.
> > >
> > > Base on linux 6.11-rc1
> > >
....
> >
> > Manivannan:
> >
> > 	Do you have chance to review these again? Only few patch without
> > your review tag.
> >
>
> Done, series LGTM.

Krzysztof Wilczyński and Bjorn Helgaas

Could you please take care these patches, which Mani already reviewed?
I still have some, which depend on these.

Frank


>
> - Mani
>
> > Frank
> >
> > >
...
>
> --
> மணிவண்ணன் சதாசிவம்

Frank Li Aug. 22, 2024, 5:03 p.m. UTC | #4

On Thu, Aug 15, 2024 at 10:56:27AM -0400, Frank Li wrote:
> On Wed, Aug 07, 2024 at 08:08:14AM +0530, Manivannan Sadhasivam wrote:
> > On Tue, Aug 06, 2024 at 04:33:38PM -0400, Frank Li wrote:
> > > On Mon, Jul 29, 2024 at 04:18:07PM -0400, Frank Li wrote:
> > > > Fixed 8mp EP mode problem.
> > > >
> > > > imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid
> > > > confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to
> > > > pci-imx.c to avoid confuse.
> > > >
> > > > Using callback to reduce switch case for core reset and refclk.
> > > >
> > > > Base on linux 6.11-rc1
> > > >
> ....
> > >
> > > Manivannan:
> > >
> > > 	Do you have chance to review these again? Only few patch without
> > > your review tag.
> > >
> >
> > Done, series LGTM.
>
> Krzysztof Wilczyński and Bjorn Helgaas
>
> Could you please take care these patches, which Mani already reviewed?
> I still have some, which depend on these.
>
> Frank

Krzysztof Wilczyński:
	Any update?

Frank

>
>
> >
> > - Mani
> >
> > > Frank
> > >
> > > >
> ...
> >
> > --
> > மணிவண்ணன் சதாசிவம்

Frank Li Aug. 29, 2024, 9:25 p.m. UTC | #5

On Thu, Aug 22, 2024 at 01:03:15PM -0400, Frank Li wrote:
> On Thu, Aug 15, 2024 at 10:56:27AM -0400, Frank Li wrote:
> > On Wed, Aug 07, 2024 at 08:08:14AM +0530, Manivannan Sadhasivam wrote:
> > > On Tue, Aug 06, 2024 at 04:33:38PM -0400, Frank Li wrote:
> > > > On Mon, Jul 29, 2024 at 04:18:07PM -0400, Frank Li wrote:
> > > > > Fixed 8mp EP mode problem.
> > > > >
> > > > > imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid
> > > > > confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to
> > > > > pci-imx.c to avoid confuse.
> > > > >
> > > > > Using callback to reduce switch case for core reset and refclk.
> > > > >
> > > > > Base on linux 6.11-rc1
> > > > >
> > ....
> > > >
> > > > Manivannan:
> > > >
> > > > 	Do you have chance to review these again? Only few patch without
> > > > your review tag.
> > > >
> > >
> > > Done, series LGTM.
> >
> > Krzysztof Wilczyński and Bjorn Helgaas
> >
> > Could you please take care these patches, which Mani already reviewed?
> > I still have some, which depend on these.
> >
> > Frank
>
> Krzysztof Wilczyński:
> 	Any update?

Ping?

>
> Frank
>
> >
> >
> > >
> > > - Mani
> > >
> > > > Frank
> > > >
> > > > >
> > ...
> > >
> > > --
> > > மணிவண்ணன் சதாசிவம்

Krzysztof Wilczyński Sept. 1, 2024, 5:55 p.m. UTC | #6

Hello,

> Fixed 8mp EP mode problem.
> 
> imx6 actaully for all imx chips (imx6*, imx7*, imx8*, imx9*). To avoid
> confuse, rename all imx6_* to imx_*, IMX6_* to IMX_*. pci-imx6.c to
> pci-imx.c to avoid confuse.
> 
> Using callback to reduce switch case for core reset and refclk.

Applied to controller/imx6, thank you!

[01/11] PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP
        https://git.kernel.org/pci/pci/c/c9d04436880c

[02/11] PCI: imx6: Fix i.MX8MP PCIe EP's occasional failure to trigger MSI
        https://git.kernel.org/pci/pci/c/f82e7aa14378

[03/11] PCI: imx6: Fix missing call to phy_power_off() in error handling
        https://git.kernel.org/pci/pci/c/3268637c4f74

[04/11] PCI: imx6: Rename imx6_* with imx_*
        https://git.kernel.org/pci/pci/c/09bec00b3591

[05/11] PCI: imx6: Introduce SoC specific callbacks for controlling REFCLK
        https://git.kernel.org/pci/pci/c/8bc6b9ccba59

[06/11] PCI: imx6: Simplify switch-case logic by involve core_reset callback
        https://git.kernel.org/pci/pci/c/79049b791bbc

[07/11] PCI: imx6: Improve comment for workaround ERR010728
        https://git.kernel.org/pci/pci/c/ea7eddfc0c9d

[08/11] PCI: imx6: Consolidate redundant if-checks
        https://git.kernel.org/pci/pci/c/dce6ed132a2f

[09/11] dt-bindings: PCI: imx6q-pcie: Add i.MX8Q PCIe compatible string
        https://git.kernel.org/pci/pci/c/99807815121a

[10/11] PCI: imx6: Call common PHY API to set mode, speed, and submode
        https://git.kernel.org/pci/pci/c/b7e35e029881

[11/11] PCI: imx6: Add i.MX8Q PCIe Root Complex (RC) support
        https://git.kernel.org/pci/pci/c/3474e6ceabdc

	Krzysztof