| Message ID | 20240903014455.4144536-1-make24@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Felix Fietkau |
| Headers | show |
| Series | [RESEND] wifi: mt76: mt7921: Check devm_kasprintf() returned value | expand |
Ma Ke <make24@iscas.ac.cn> writes: > devm_kasprintf() can return a NULL pointer on failure but this returned > value is not checked. Fix this lack and check the returned value. > > Found by code review. > > Cc: stable@vger.kernel.org > Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor") > Signed-off-by: Ma Ke <make24@iscas.ac.cn> > --- > drivers/net/wireless/mediatek/mt76/mt7921/init.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c > index ef0c721d26e3..5ab395d9d93e 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c > @@ -52,6 +52,8 @@ static int mt7921_thermal_init(struct mt792x_phy *phy) > > name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7921_%s", > wiphy_name(wiphy)); > + if (!name) > + return -ENOMEM; > > hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy, > mt7921_hwmon_groups); You sent the previous version of this on August 26th: https://patchwork.kernel.org/project/linux-wireless/patch/20240826095535.2603538-1-make24@iscas.ac.cn/ Please stop spamming like this and understand that maintainers are busy.
On 03/09/2024 03:44, Ma Ke wrote: > devm_kasprintf() can return a NULL pointer on failure but this returned > value is not checked. Fix this lack and check the returned value. > > Found by code review. > > Cc: stable@vger.kernel.org > Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor") > Signed-off-by: Ma Ke <make24@iscas.ac.cn> Reviwed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/net/wireless/mediatek/mt76/mt7921/init.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c > index ef0c721d26e3..5ab395d9d93e 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c > @@ -52,6 +52,8 @@ static int mt7921_thermal_init(struct mt792x_phy *phy) > > name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7921_%s", > wiphy_name(wiphy)); > + if (!name) > + return -ENOMEM; > > hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy, > mt7921_hwmon_groups);
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/init.c b/drivers/net/wireless/mediatek/mt76/mt7921/init.c index ef0c721d26e3..5ab395d9d93e 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/init.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/init.c @@ -52,6 +52,8 @@ static int mt7921_thermal_init(struct mt792x_phy *phy) name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7921_%s", wiphy_name(wiphy)); + if (!name) + return -ENOMEM; hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, phy, mt7921_hwmon_groups);
devm_kasprintf() can return a NULL pointer on failure but this returned value is not checked. Fix this lack and check the returned value. Found by code review. Cc: stable@vger.kernel.org Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor") Signed-off-by: Ma Ke <make24@iscas.ac.cn> --- drivers/net/wireless/mediatek/mt76/mt7921/init.c | 2 ++ 1 file changed, 2 insertions(+)