mbox series

[leds,v2,00/11] Turris Omnia LED driver changes

Message ID 20240903101930.16251-1-kabel@kernel.org (mailing list archive)
Headers show
Series Turris Omnia LED driver changes | expand

Message

Marek Behún Sept. 3, 2024, 10:19 a.m. UTC
Hello Lee,

this is v2 of Turris Omnia LED driver changes.
v1 can be found at
  https://lore.kernel.org/linux-leds/20240902124104.14297-1-kabel@kernel.org/

This series is for 6.12, but it depends on changes that have been
merged to 6.11-rc3. Your for-leds-next branch is based on 6.11-rc1, so
it won't apply there.

Changes since v1:
- patch 2 does away also with i2c_master_send() call, in favor of
  omnia_cmd_write()
- patch 5 was rewritten to not use devm_device_add_group() anymore,
  since this function was deprecated. Instead, the sysfs_put() call for
  the "brightness" node is done the first time the IRQ handler is
  called, instead of driver probe.
- the changes were done with 100 columns limit in mind
- added 3 more "cosmetic" patches

Marek

Marek Behún (11):
  turris-omnia-mcu-interface.h: Move command execution function to
    global header
  leds: turris-omnia: Use command execution functions from the MCU
    driver
  turris-omnia-mcu-interface.h: Add LED commands related definitions to
    global header
  leds: turris-omnia: Use global header for MCU command definitions
  leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change
  platform: cznic: turris-omnia-mcu: Inform about missing LED panel
    brightness change interrupt feature
  leds: turris-omnia: Inform about missing LED gamma correction feature
    in the MCU driver
  leds: turris-omnia: Use dev_err_probe() where appropriate
  leds: turris-omnia: Use uppercase first letter in all comments
  leds: turris-omnia: Use 100 columns in the rest of the code
  ARM: dts: turris-omnia: Add global LED brightness change interrupt

 .../dts/marvell/armada-385-turris-omnia.dts   |   1 +
 drivers/leds/leds-turris-omnia.c              | 283 +++++++-----------
 .../platform/cznic/turris-omnia-mcu-base.c    |   3 +
 drivers/platform/cznic/turris-omnia-mcu.h     | 130 --------
 include/linux/turris-omnia-mcu-interface.h    | 148 ++++++++-
 5 files changed, 257 insertions(+), 308 deletions(-)

Comments

Rob Herring (Arm) Sept. 3, 2024, 2:26 p.m. UTC | #1
On Tue, 03 Sep 2024 12:19:19 +0200, Marek Behún wrote:
> Hello Lee,
> 
> this is v2 of Turris Omnia LED driver changes.
> v1 can be found at
>   https://lore.kernel.org/linux-leds/20240902124104.14297-1-kabel@kernel.org/
> 
> This series is for 6.12, but it depends on changes that have been
> merged to 6.11-rc3. Your for-leds-next branch is based on 6.11-rc1, so
> it won't apply there.
> 
> Changes since v1:
> - patch 2 does away also with i2c_master_send() call, in favor of
>   omnia_cmd_write()
> - patch 5 was rewritten to not use devm_device_add_group() anymore,
>   since this function was deprecated. Instead, the sysfs_put() call for
>   the "brightness" node is done the first time the IRQ handler is
>   called, instead of driver probe.
> - the changes were done with 100 columns limit in mind
> - added 3 more "cosmetic" patches
> 
> Marek
> 
> Marek Behún (11):
>   turris-omnia-mcu-interface.h: Move command execution function to
>     global header
>   leds: turris-omnia: Use command execution functions from the MCU
>     driver
>   turris-omnia-mcu-interface.h: Add LED commands related definitions to
>     global header
>   leds: turris-omnia: Use global header for MCU command definitions
>   leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change
>   platform: cznic: turris-omnia-mcu: Inform about missing LED panel
>     brightness change interrupt feature
>   leds: turris-omnia: Inform about missing LED gamma correction feature
>     in the MCU driver
>   leds: turris-omnia: Use dev_err_probe() where appropriate
>   leds: turris-omnia: Use uppercase first letter in all comments
>   leds: turris-omnia: Use 100 columns in the rest of the code
>   ARM: dts: turris-omnia: Add global LED brightness change interrupt
> 
>  .../dts/marvell/armada-385-turris-omnia.dts   |   1 +
>  drivers/leds/leds-turris-omnia.c              | 283 +++++++-----------
>  .../platform/cznic/turris-omnia-mcu-base.c    |   3 +
>  drivers/platform/cznic/turris-omnia-mcu.h     | 130 --------
>  include/linux/turris-omnia-mcu-interface.h    | 148 ++++++++-
>  5 files changed, 257 insertions(+), 308 deletions(-)
> 
> --
> 2.44.2
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y marvell/armada-385-turris-omnia.dtb' for 20240903101930.16251-1-kabel@kernel.org:

arch/arm/boot/dts/marvell/armada-385-turris-omnia.dtb: led-controller@2b: 'interrupts-extended' does not match any of the regexes: '^multi-led@[0-9a-b]$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/leds/cznic,turris-omnia-leds.yaml#