diff mbox series

PATCH: Turing RK1 DTB Fan

Message ID bZF0liAaH-7lJuzf_4iIfAWAgwYauu7IpIJMMpY7BT8mZXiKZFZ797Sa9gONDEt2wIFlLd4l10qSfs44ZAiBJ7_c3yvAFci4kuOdeYy7ZQU=@flety.net (mailing list archive)
State Changes Requested
Headers show
Series PATCH: Turing RK1 DTB Fan | expand

Commit Message

Damien FLETY Aug. 1, 2024, 8:16 a.m. UTC 
Support the official cooling fan on Turing RK1.


Damien FLETY

Comments

Damien FLETY Aug. 1, 2024, 8:41 a.m. UTC | #1 
Sorry I'm not accustomed to patch and even less kernel patches...

Add support for Turing RK1 official fan
---
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi
index dbaa94ca69f4..1e4d2d3c469f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi
@@ -65,6 +65,47 @@ vcc_1v1_nldo_s3: vcc-1v1-nldo-s3-regulator {
};
};

+&package_thermal {
+ polling-delay = <1000>;
+
+ trips {
+ trip_passive: trip_passive {
+ temperature = <40000>;
+ hysteresis = <2000>;
+ type = "passive";
+ };
+ trip_active: trip_active {
+ temperature = <45000>;
+ hysteresis = <2000>;
+ type = "active";
+ };
+ trip_hot: trip_hot {
+ temperature = <80000>;
+ hysteresis = <2000>;
+ type = "hot";
+ };
+ };
+
+ cooling-maps {
+ map0 {
+ trip = <&trip_passive>;
+ cooling-device = <&fan 0 1>;
+ };
+ map1 {
+ trip = <&trip_active>;
+ cooling-device = <&fan 1 4>;
+ };
+ map2 {
+ trip = <&trip_hot>;
+ cooling-device = <&fan 4 5>;
+ };
+ map3 {
+ trip = <&package_crit>;
+ cooling-device = <&fan 5 5>;
+ };
+ };
+};
+
&combphy2_psu {
status = "okay";
};
Le jeudi 1 août 2024 à 10:16, Damien FLETY <damien@flety.net> a écrit :

> Support the official cooling fan on Turing RK1.
>
> --- rk3588-turing-rk1.dtsi 2024-08-01 08:07:42.967506469 +0000
> +++ src/linux/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi 2024-08-01 08:08:58.292765373 +0000
> @@ -65,47 +65,6 @@
> };
> };
>
> -&package_thermal {
> - polling-delay = <1000>;
> -
> - trips {
> - trip_passive: trip_passive {
> - temperature = <40000>;
> - hysteresis = <2000>;
> - type = "passive";
> - };
> - trip_active: trip_active {
> - temperature = <45000>;
> - hysteresis = <2000>;
> - type = "active";
> - };
> - trip_hot: trip_hot {
> - temperature = <80000>;
> - hysteresis = <2000>;
> - type = "hot";
> - };
> - };
> -
> - cooling-maps {
> - map0 {
> - trip = <&trip_passive>;
> - cooling-device = <&fan 0 1>;
> - };
> - map1 {
> - trip = <&trip_active>;
> - cooling-device = <&fan 1 4>;
> - };
> - map2 {
> - trip = <&trip_hot>;
> - cooling-device = <&fan 4 5>;
> - };
> - map3 {
> - trip = <&package_crit>;
> - cooling-device = <&fan 5 5>;
> - };
> - };
> -};
> -
> &combphy2_psu {
> status = "okay";
> };
>
> Damien FLETY
Arnd Bergmann Sept. 5, 2024, 1:23 p.m. UTC | #2 
On Thu, Aug 1, 2024, at 08:41, Damien FLETY wrote:
> Sorry I'm not accustomed to patch and even less kernel patches...
>
> Add support for Turing RK1 official fan
> ---


Hi Damien,

I found this patch in the backlog and noticed that you sent it to the
wrong place. Please address future versions to Heiko Stübner and the
linux-rockchip mailing list (added to Cc here).

I have not checked the actual patch contents in detail, but please
ensure you follow these steps:

- Make sure that your patch description (everything above the first
  three dashes, ---) makes sense as a git changelog text. See
  'git log arch/arm64/boot/dts/rockchip' for other examples)

- Add a Signed-off-by line, as documented in
  Documentation/process/submitting-patches.rst

- Use 'git send-email' to send the patch in a form that can
  be applied from the mailing list.

      Arnd

(fullquote below, no further comments)

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi 
> b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi
> index dbaa94ca69f4..1e4d2d3c469f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi
> @@ -65,6 +65,47 @@ vcc_1v1_nldo_s3: vcc-1v1-nldo-s3-regulator {
>         };
>  };
> 
> +&package_thermal {
> +       polling-delay = <1000>;
> +
> +       trips {
> +               trip_passive: trip_passive {
> +                       temperature = <40000>;
> +                       hysteresis = <2000>;
> +                       type = "passive";
> +               };
> +    trip_active: trip_active {
> +                       temperature = <45000>;
> +                       hysteresis = <2000>;
> +                       type = "active";
> +               };
> +    trip_hot: trip_hot {
> +                       temperature = <80000>;
> +                       hysteresis = <2000>;
> +                       type = "hot";
> +               };
> +       };
> +
> +       cooling-maps {
> +               map0 {
> +                       trip = <&trip_passive>;
> +                       cooling-device = <&fan 0 1>;
> +               };
> +    map1 {
> +      trip = <&trip_active>;
> +      cooling-device = <&fan 1 4>;
> +    };
> +    map2 {
> +      trip = <&trip_hot>;
> +      cooling-device = <&fan 4 5>;
> +    };
> +    map3 {
> +      trip = <&package_crit>;
> +      cooling-device = <&fan 5 5>;
> +    };
> +       };
> +};
> +
>  &combphy2_psu {
>         status = "okay";
>  };
>
> Le jeudi 1 août 2024 à 10:16, Damien FLETY <damien@flety.net> a écrit :
>> 
>> Support the official cooling fan on Turing RK1.
>> 
>> --- rk3588-turing-rk1.dtsi 2024-08-01 08:07:42.967506469 +0000
>> +++ src/linux/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi 2024-08-01 08:08:58.292765373 +0000
>> @@ -65,47 +65,6 @@
>>   };
>>  };
>>  
>> -&package_thermal {
>> - polling-delay = <1000>;
>> -
>> - trips {
>> - trip_passive: trip_passive {
>> - temperature = <40000>;
>> - hysteresis = <2000>;
>> - type = "passive";
>> - };
>> -    trip_active: trip_active {
>> - temperature = <45000>;
>> - hysteresis = <2000>;
>> - type = "active";
>> - };
>> -    trip_hot: trip_hot {
>> - temperature = <80000>;
>> - hysteresis = <2000>;
>> - type = "hot";
>> - };
>> - };
>> -
>> - cooling-maps {
>> - map0 {
>> - trip = <&trip_passive>;
>> - cooling-device = <&fan 0 1>;
>> - };
>> -    map1 {
>> -      trip = <&trip_active>;
>> -      cooling-device = <&fan 1 4>;
>> -    };
>> -    map2 {
>> -      trip = <&trip_hot>;
>> -      cooling-device = <&fan 4 5>;
>> -    };
>> -    map3 {
>> -      trip = <&package_crit>;
>> -      cooling-device = <&fan 5 5>;
>> -    };
>> - };
>> -};
>> -
>>  &combphy2_psu {
>>   status = "okay";
>>  };
>> 
>> 
>> Damien FLETY
Mark Brown Sept. 5, 2024, 2:11 p.m. UTC | #3 
On Thu, Sep 05, 2024 at 01:23:34PM +0000, Arnd Bergmann wrote:

> - Use 'git send-email' to send the patch in a form that can
>   be applied from the mailing list.

There's another tool 'b4' which does this too, plus wrapping some other
technical bits of the upstreaming process:

   https://b4.docs.kernel.org/en/latest/
diff mbox series

Patch

--- rk3588-turing-rk1.dtsi 2024-08-01 08:07:42.967506469 +0000
+++ src/linux/arch/arm64/boot/dts/rockchip/rk3588-turing-rk1.dtsi 2024-08-01 08:08:58.292765373 +0000
@@ -65,47 +65,6 @@ 
};
};

-&package_thermal {
- polling-delay = <1000>;
-
- trips {
- trip_passive: trip_passive {
- temperature = <40000>;
- hysteresis = <2000>;
- type = "passive";
- };
- trip_active: trip_active {
- temperature = <45000>;
- hysteresis = <2000>;
- type = "active";
- };
- trip_hot: trip_hot {
- temperature = <80000>;
- hysteresis = <2000>;
- type = "hot";
- };
- };
-
- cooling-maps {
- map0 {
- trip = <&trip_passive>;
- cooling-device = <&fan 0 1>;
- };
- map1 {
- trip = <&trip_active>;
- cooling-device = <&fan 1 4>;
- };
- map2 {
- trip = <&trip_hot>;
- cooling-device = <&fan 4 5>;
- };
- map3 {
- trip = <&package_crit>;
- cooling-device = <&fan 5 5>;
- };
- };
-};
-
&combphy2_psu {
status = "okay";
};