| Message ID | 20240907083822.100942-2-zhangzekun11@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Remove unused declarations in header files | expand |
On 07/09/2024 11:38, Zhang Zekun wrote: > The definition of iser_finalize_rdma_unaligned_sg() has been removed > since commit dd0107a08996 ("IB/iser: set block queue_virt_boundary"). > Let's remove the unused declaration in header file. > > Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> > --- > drivers/infiniband/ulp/iser/iscsi_iser.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser/iscsi_iser.h > index 68429a5f796d..1d7ac24c4c00 100644 > --- a/drivers/infiniband/ulp/iser/iscsi_iser.h > +++ b/drivers/infiniband/ulp/iser/iscsi_iser.h > @@ -507,10 +507,6 @@ void iser_task_rdma_finalize(struct iscsi_iser_task *task); > > void iser_free_rx_descriptors(struct iser_conn *iser_conn); > > -void iser_finalize_rdma_unaligned_sg(struct iscsi_iser_task *iser_task, > - struct iser_data_buf *mem, > - enum iser_data_dir cmd_dir); > - > int iser_reg_mem_fastreg(struct iscsi_iser_task *task, > enum iser_data_dir dir, > bool all_imm); Looks good, Acked-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Typo in the commit title, s/heder/header Looks good to me otherwise. Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> On Sat, Sep 7, 2024 at 2:22 PM Zhang Zekun <zhangzekun11@huawei.com> wrote: > > The definition of iser_finalize_rdma_unaligned_sg() has been removed > since commit dd0107a08996 ("IB/iser: set block queue_virt_boundary"). > Let's remove the unused declaration in header file. > > Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> > --- > drivers/infiniband/ulp/iser/iscsi_iser.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser/iscsi_iser.h > index 68429a5f796d..1d7ac24c4c00 100644 > --- a/drivers/infiniband/ulp/iser/iscsi_iser.h > +++ b/drivers/infiniband/ulp/iser/iscsi_iser.h > @@ -507,10 +507,6 @@ void iser_task_rdma_finalize(struct iscsi_iser_task *task); > > void iser_free_rx_descriptors(struct iser_conn *iser_conn); > > -void iser_finalize_rdma_unaligned_sg(struct iscsi_iser_task *iser_task, > - struct iser_data_buf *mem, > - enum iser_data_dir cmd_dir); > - > int iser_reg_mem_fastreg(struct iscsi_iser_task *task, > enum iser_data_dir dir, > bool all_imm); > -- > 2.17.1 > >
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h b/drivers/infiniband/ulp/iser/iscsi_iser.h index 68429a5f796d..1d7ac24c4c00 100644 --- a/drivers/infiniband/ulp/iser/iscsi_iser.h +++ b/drivers/infiniband/ulp/iser/iscsi_iser.h @@ -507,10 +507,6 @@ void iser_task_rdma_finalize(struct iscsi_iser_task *task); void iser_free_rx_descriptors(struct iser_conn *iser_conn); -void iser_finalize_rdma_unaligned_sg(struct iscsi_iser_task *iser_task, - struct iser_data_buf *mem, - enum iser_data_dir cmd_dir); - int iser_reg_mem_fastreg(struct iscsi_iser_task *task, enum iser_data_dir dir, bool all_imm);
The definition of iser_finalize_rdma_unaligned_sg() has been removed since commit dd0107a08996 ("IB/iser: set block queue_virt_boundary"). Let's remove the unused declaration in header file. Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> --- drivers/infiniband/ulp/iser/iscsi_iser.h | 4 ---- 1 file changed, 4 deletions(-)