diff mbox series

platform: cznic: turris-omnia-mcu: fix HW_RANDOM dependency

Message ID 20240909110417.247453-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit b97acde6f9840edbac5c7ea07cba6f10308d24ee
Headers show
Series platform: cznic: turris-omnia-mcu: fix HW_RANDOM dependency | expand

Commit Message

Arnd Bergmann Sept. 9, 2024, 11:04 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

There is still a build failure when the rwrng support is in a loadable
module but the mcu driver is built-in:

arm-linux-gnueabi-ld: drivers/platform/cznic/turris-omnia-mcu-trng.o: in function `omnia_mcu_register_trng':
turris-omnia-mcu-trng.c:(.text.omnia_mcu_register_trng+0x11c): undefined reference to `devm_hwrng_register'

Change the dependency to explicitly disallow the broken
configuration.

Fixes: 41bb142a4028 ("platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/platform/cznic/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Behún Sept. 10, 2024, 10:09 a.m. UTC | #1 
Reviewed-by: Marek Behún <kabel@kernel.org>

On Mon, Sep 09, 2024 at 11:04:09AM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> There is still a build failure when the rwrng support is in a loadable
> module but the mcu driver is built-in:
> 
> arm-linux-gnueabi-ld: drivers/platform/cznic/turris-omnia-mcu-trng.o: in function `omnia_mcu_register_trng':
> turris-omnia-mcu-trng.c:(.text.omnia_mcu_register_trng+0x11c): undefined reference to `devm_hwrng_register'
> 
> Change the dependency to explicitly disallow the broken
> configuration.
> 
> Fixes: 41bb142a4028 ("platform: cznic: turris-omnia-mcu: Add support for MCU provided TRNG")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/platform/cznic/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/cznic/Kconfig b/drivers/platform/cznic/Kconfig
> index a111eca8ff57..49c383eb6785 100644
> --- a/drivers/platform/cznic/Kconfig
> +++ b/drivers/platform/cznic/Kconfig
> @@ -70,7 +70,7 @@ config TURRIS_OMNIA_MCU_TRNG
>  	bool "Turris Omnia MCU true random number generator"
>  	default y
>  	depends on TURRIS_OMNIA_MCU_GPIO
> -	depends on HW_RANDOM
> +	depends on HW_RANDOM=y || HW_RANDOM=TURRIS_OMNIA_MCU
>  	help
>  	  Say Y here to add support for the true random number generator
>  	  provided by CZ.NIC's Turris Omnia MCU.
> -- 
> 2.39.2
>
patchwork-bot+linux-soc@kernel.org Sept. 11, 2024, 9 a.m. UTC | #2 
Hello:

This patch was applied to soc/soc.git (arm/fixes)
by Arnd Bergmann <arnd@arndb.de>:

On Mon,  9 Sep 2024 11:04:09 +0000 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> There is still a build failure when the rwrng support is in a loadable
> module but the mcu driver is built-in:
> 
> arm-linux-gnueabi-ld: drivers/platform/cznic/turris-omnia-mcu-trng.o: in function `omnia_mcu_register_trng':
> turris-omnia-mcu-trng.c:(.text.omnia_mcu_register_trng+0x11c): undefined reference to `devm_hwrng_register'
> 
> [...]

Here is the summary with links:
  - platform: cznic: turris-omnia-mcu: fix HW_RANDOM dependency
    https://git.kernel.org/soc/soc/c/b97acde6f984

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/platform/cznic/Kconfig b/drivers/platform/cznic/Kconfig
index a111eca8ff57..49c383eb6785 100644
--- a/drivers/platform/cznic/Kconfig
+++ b/drivers/platform/cznic/Kconfig
@@ -70,7 +70,7 @@  config TURRIS_OMNIA_MCU_TRNG
 	bool "Turris Omnia MCU true random number generator"
 	default y
 	depends on TURRIS_OMNIA_MCU_GPIO
-	depends on HW_RANDOM
+	depends on HW_RANDOM=y || HW_RANDOM=TURRIS_OMNIA_MCU
 	help
 	  Say Y here to add support for the true random number generator
 	  provided by CZ.NIC's Turris Omnia MCU.