Message ID | 20240911084147.A205DC4AF0F@smtp.kernel.org (mailing list archive) |
---|---|
State | Not Applicable |
Delegated to: | Kalle Valo |
Headers | show |
Series | pull-request: wireless-next-2024-09-11 | expand |
On Wed, 11 Sep 2024 08:41:47 +0000 (UTC) Kalle Valo wrote: > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. For a follow up, clang W=1 says: ../drivers/net/wireless/realtek/rtw89/coex.c:6323:23: warning: variable 'cnt_2g' set but not used [-Wunused-but-set-variable] 6323 | u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc; | ^ ../drivers/net/wireless/realtek/rtw89/coex.c:6323:35: warning: variable 'cnt_5g' set but not used [-Wunused-but-set-variable] 6323 | u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc; | ^ 2 warnings generated. ../drivers/staging/rtl8712/rtl8712_recv.c:139:6: warning: variable 'drvinfo_sz' set but not used [-Wunused-but-set-variable] 139 | u16 drvinfo_sz; | ^ 1 warning generated. ../drivers/staging/rtl8723bs/core/rtw_efuse.c:285:6: warning: variable 'efuseValue' set but not used [-Wunused-but-set-variable] 285 | u32 efuseValue; | ^ 1 warning generated. ../drivers/staging/rtl8723bs/core/rtw_recv.c:2030:7: warning: variable 'cnt' set but not used [-Wunused-but-set-variable] 2030 | int cnt = 0; | ^ 1 warning generated. ../drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:288:6: warning: variable 'poll_cnt' set but not used [-Wunused-but-set-variable] 288 | u8 poll_cnt = 0; | ^
Jakub Kicinski <kuba@kernel.org> writes: > On Wed, 11 Sep 2024 08:41:47 +0000 (UTC) Kalle Valo wrote: >> here's a pull request to net-next tree, more info below. Please let me know if >> there are any problems. > > For a follow up, clang W=1 says: > > ../drivers/net/wireless/realtek/rtw89/coex.c:6323:23: warning: > variable 'cnt_2g' set but not used [-Wunused-but-set-variable] > 6323 | u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc; > | ^ > ../drivers/net/wireless/realtek/rtw89/coex.c:6323:35: warning: > variable 'cnt_5g' set but not used [-Wunused-but-set-variable] > 6323 | u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc; > | ^ > 2 warnings generated. > ../drivers/staging/rtl8712/rtl8712_recv.c:139:6: warning: variable > 'drvinfo_sz' set but not used [-Wunused-but-set-variable] > 139 | u16 drvinfo_sz; > | ^ > 1 warning generated. > ../drivers/staging/rtl8723bs/core/rtw_efuse.c:285:6: warning: variable > 'efuseValue' set but not used [-Wunused-but-set-variable] > 285 | u32 efuseValue; > | ^ > 1 warning generated. > ../drivers/staging/rtl8723bs/core/rtw_recv.c:2030:7: warning: variable > 'cnt' set but not used [-Wunused-but-set-variable] > 2030 | int cnt = 0; > | ^ > 1 warning generated. > ../drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:288:6: warning: > variable 'poll_cnt' set but not used [-Wunused-but-set-variable] > 288 | u8 poll_cnt = 0; > | ^ What's the deadline for these? Do you need the fixes tomorrow or can it wait a week or two?
Hello: This pull request was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 11 Sep 2024 08:41:47 +0000 (UTC) you wrote: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > [...] Here is the summary with links: - pull-request: wireless-next-2024-09-11 https://git.kernel.org/netdev/net-next/c/a18c097eda42 You are awesome, thank you!
On Thu, 12 Sep 2024 01:29:53 +0300 Kalle Valo wrote: > > ../drivers/net/wireless/realtek/rtw89/coex.c:6323:23: warning: > > variable 'cnt_2g' set but not used [-Wunused-but-set-variable] > > 6323 | u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc; > > | ^ > > ../drivers/net/wireless/realtek/rtw89/coex.c:6323:35: warning: > > variable 'cnt_5g' set but not used [-Wunused-but-set-variable] > > 6323 | u8 i, mode, cnt = 0, cnt_2g = 0, cnt_5g = 0, phy_now = RTW89_PHY_MAX, phy_dbcc; > > | ^ > > 2 warnings generated. > > ../drivers/staging/rtl8712/rtl8712_recv.c:139:6: warning: variable > > 'drvinfo_sz' set but not used [-Wunused-but-set-variable] > > 139 | u16 drvinfo_sz; > > | ^ > > 1 warning generated. > > ../drivers/staging/rtl8723bs/core/rtw_efuse.c:285:6: warning: variable > > 'efuseValue' set but not used [-Wunused-but-set-variable] > > 285 | u32 efuseValue; > > | ^ > > 1 warning generated. > > ../drivers/staging/rtl8723bs/core/rtw_recv.c:2030:7: warning: variable > > 'cnt' set but not used [-Wunused-but-set-variable] > > 2030 | int cnt = 0; > > | ^ > > 1 warning generated. > > ../drivers/staging/rtl8723bs/core/rtw_pwrctrl.c:288:6: warning: > > variable 'poll_cnt' set but not used [-Wunused-but-set-variable] > > 288 | u8 poll_cnt = 0; > > | ^ > > What's the deadline for these? Do you need the fixes tomorrow or can it > wait a week or two? It can wait, half of them are old anyway
On Wed, 11 Sep 2024 15:36:33 -0700 Jakub Kicinski wrote: > > What's the deadline for these? Do you need the fixes tomorrow or can it > > wait a week or two? > > It can wait, half of them are old anyway Oh, that's because they are in staging :) I missed that. But anyway, I don't think that a harmless, single compiler, W=1 warning is a blocker.
Jakub Kicinski <kuba@kernel.org> wrote: > On Wed, 11 Sep 2024 15:36:33 -0700 Jakub Kicinski wrote: > > > What's the deadline for these? Do you need the fixes tomorrow or can it > > > wait a week or two? > > > > It can wait, half of them are old anyway > > Oh, that's because they are in staging :) I missed that. > But anyway, I don't think that a harmless, single compiler, > W=1 warning is a blocker. I have fixed warnings of "wifi: rtw89" by [1]. For staging code, I use another patchset [2] to fix it. I'm not sure [1] should go wireless or rtw tree. Please guide me. Thanks. [1] https://lore.kernel.org/linux-wireless/20240912021626.10494-1-pkshih@realtek.com/T/#u [2] https://lore.kernel.org/linux-staging/20240912022522.10715-1-pkshih@realtek.com/T/#t
Ping-Ke Shih <pkshih@realtek.com> writes: > Jakub Kicinski <kuba@kernel.org> wrote: >> On Wed, 11 Sep 2024 15:36:33 -0700 Jakub Kicinski wrote: >> > > What's the deadline for these? Do you need the fixes tomorrow or can it >> > > wait a week or two? >> > >> > It can wait, half of them are old anyway >> >> Oh, that's because they are in staging :) I missed that. >> But anyway, I don't think that a harmless, single compiler, >> W=1 warning is a blocker. Ok, we'll send the rtw89 fix in the normal wireless pull request, hopefully before the merge window closes. > I have fixed warnings of "wifi: rtw89" by [1]. For staging code, I use another > patchset [2] to fix it. Oh wow, that was quick. We have 24/7 watch around the world :) Thanks Ping! > I'm not sure [1] should go wireless or rtw tree. Please guide me. Thanks. Let's queue the rtw89 fix for wireless so that the quick goes to net tree soon. So please assign it to me on patchwork.
> > I'm not sure [1] should go wireless or rtw tree. Please guide me. Thanks. > > Let's queue the rtw89 fix for wireless so that the quick goes to net > tree soon. So please assign it to me on patchwork. Assigned. Thanks!