| Message ID | 20240912144456.591494-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f8acfee2f8e042bda680e55fb801a7d18f00a42e |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [next] wifi: mac80211: make read-only array svc_id static const | expand |
On 9/12/2024 7:44 AM, Colin Ian King wrote: subject prefix should be wifi: ath12k: but no need to re-send; Kalle can fix this in the pending branch > Don't populate the read-only array svc_id on the stack at run time, > instead make it static const. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Colin Ian King <colin.i.king@gmail.com> wrote: > Don't populate the read-only array svc_id on the stack at run time, > instead make it static const. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. f8acfee2f8e0 wifi: ath12k: make read-only array svc_id static const
diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c index 2cd3ff9b0164..190439ad7f23 100644 --- a/drivers/net/wireless/ath/ath12k/wmi.c +++ b/drivers/net/wireless/ath/ath12k/wmi.c @@ -7284,9 +7284,11 @@ static int ath12k_connect_pdev_htc_service(struct ath12k_base *ab, u32 pdev_idx) { int status; - u32 svc_id[] = { ATH12K_HTC_SVC_ID_WMI_CONTROL, - ATH12K_HTC_SVC_ID_WMI_CONTROL_MAC1, - ATH12K_HTC_SVC_ID_WMI_CONTROL_MAC2 }; + static const u32 svc_id[] = { + ATH12K_HTC_SVC_ID_WMI_CONTROL, + ATH12K_HTC_SVC_ID_WMI_CONTROL_MAC1, + ATH12K_HTC_SVC_ID_WMI_CONTROL_MAC2 + }; struct ath12k_htc_svc_conn_req conn_req = {}; struct ath12k_htc_svc_conn_resp conn_resp = {};
Don't populate the read-only array svc_id on the stack at run time, instead make it static const. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/wireless/ath/ath12k/wmi.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)