| Message ID | 20240925095635.30452-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 29ce0bca6d5fc0f14a0b7a2c6551128fc27cb8db |
| Headers | show |
| Series | [v2] Documentation/process: maintainer-soc: clarify submitting patches | expand |
On Wed, Sep 25, 2024 at 11:56 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > Patches for SoCs are expected to be picked up by SoC submaintainers. > The main SoC maintainers should be addressed only in few cases. > > Rewrite the section about maintainer handling to document above > expectation. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Will Deacon <will@kernel.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Conor Dooley <conor@kernel.org> > Cc: Heiko Stübner <heiko@sntech.de> Very nice and to the point document. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes: > Patches for SoCs are expected to be picked up by SoC submaintainers. > The main SoC maintainers should be addressed only in few cases. > > Rewrite the section about maintainer handling to document above > expectation. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Will Deacon <will@kernel.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Conor Dooley <conor@kernel.org> > Cc: Heiko Stübner <heiko@sntech.de> Reviewed-by: Kevin Hilman <khilman@baylibre.com> Thanks for writing this up Krzysztof, Kevin
On Wed, Sep 25, 2024 at 11:56:35AM +0200, Krzysztof Kozlowski wrote: > Patches for SoCs are expected to be picked up by SoC submaintainers. > The main SoC maintainers should be addressed only in few cases. > > Rewrite the section about maintainer handling to document above > expectation. > LGTM, thanks! Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes: > Patches for SoCs are expected to be picked up by SoC submaintainers. > The main SoC maintainers should be addressed only in few cases. > > Rewrite the section about maintainer handling to document above > expectation. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Will Deacon <will@kernel.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Conor Dooley <conor@kernel.org> > Cc: Heiko Stübner <heiko@sntech.de> > > --- > > During our LPC ad-hoc BoF, we discussed improving Maintainer SoC docs > and I think I volunteered to write something. The trouble is that > whatever I won't write in my notes, escapes my memory. > > I believe this is what we discussed. Was there anything more to > write/document? > > Changes in v2: > 1. Fix missing closing ) (Conor). > 2. Style changes (in point 3.). > 3. Soften note that soc@kernel is not for discussing ("is usually not"). > --- > Documentation/process/maintainer-soc.rst | 42 +++++++++++++++++++++--- > 1 file changed, 37 insertions(+), 5 deletions(-) Applied, thanks. jon
Hello: This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <arnd@arndb.de>: On Wed, 25 Sep 2024 11:56:35 +0200 you wrote: > Patches for SoCs are expected to be picked up by SoC submaintainers. > The main SoC maintainers should be addressed only in few cases. > > Rewrite the section about maintainer handling to document above > expectation. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Will Deacon <will@kernel.org> > Cc: Kevin Hilman <khilman@baylibre.com> > Cc: Palmer Dabbelt <palmer@dabbelt.com> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Conor Dooley <conor@kernel.org> > Cc: Heiko Stübner <heiko@sntech.de> > > [...] Here is the summary with links: - [v2] Documentation/process: maintainer-soc: clarify submitting patches https://git.kernel.org/soc/soc/c/29ce0bca6d5f You are awesome, thank you!
On 07/10/2024 19:18, Jonathan Corbet wrote: >> >> --- >> >> During our LPC ad-hoc BoF, we discussed improving Maintainer SoC docs >> and I think I volunteered to write something. The trouble is that >> whatever I won't write in my notes, escapes my memory. >> >> I believe this is what we discussed. Was there anything more to >> write/document? >> >> Changes in v2: >> 1. Fix missing closing ) (Conor). >> 2. Style changes (in point 3.). >> 3. Soften note that soc@kernel is not for discussing ("is usually not"). >> --- >> Documentation/process/maintainer-soc.rst | 42 +++++++++++++++++++++--- >> 1 file changed, 37 insertions(+), 5 deletions(-) > > Applied, thanks. Thanks Jon and Arnd. I got now notification that this was also applied to soc tree, so it seems it got applied twice. Best regards, Krzysztof
diff --git a/Documentation/process/maintainer-soc.rst b/Documentation/process/maintainer-soc.rst index 12637530d68f..fe9d8bcfbd2b 100644 --- a/Documentation/process/maintainer-soc.rst +++ b/Documentation/process/maintainer-soc.rst @@ -30,10 +30,13 @@ tree as a dedicated branch covering multiple subsystems. The main SoC tree is housed on git.kernel.org: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/ +Maintainers +----------- + Clearly this is quite a wide range of topics, which no one person, or even small group of people are capable of maintaining. Instead, the SoC subsystem -is comprised of many submaintainers, each taking care of individual platforms -and driver subdirectories. +is comprised of many submaintainers (platform maintainers), each taking care of +individual platforms and driver subdirectories. In this regard, "platform" usually refers to a series of SoCs from a given vendor, for example, Nvidia's series of Tegra SoCs. Many submaintainers operate on a vendor level, responsible for multiple product lines. For several reasons, @@ -43,14 +46,43 @@ MAINTAINERS file. Most of these submaintainers have their own trees where they stage patches, sending pull requests to the main SoC tree. These trees are usually, but not -always, listed in MAINTAINERS. The main SoC maintainers can be reached via the -alias soc@kernel.org if there is no platform-specific maintainer, or if they -are unresponsive. +always, listed in MAINTAINERS. What the SoC tree is not, however, is a location for architecture-specific code changes. Each architecture has its own maintainers that are responsible for architectural details, CPU errata and the like. +Submitting Patches for Given SoC +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +All typical platform related patches should be sent via SoC submaintainers +(platform-specific maintainers). This includes also changes to per-platform or +shared defconfigs (scripts/get_maintainer.pl might not provide correct +addresses in such case). + +Submitting Patches to the Main SoC Maintainers +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +The main SoC maintainers can be reached via the alias soc@kernel.org only in +following cases: + +1. There are no platform-specific maintainers. + +2. Platform-specific maintainers are unresponsive. + +3. Introducing a completely new SoC platform. Such new SoC work should be sent + first to common mailing lists, pointed out by scripts/get_maintainer.pl, for + community review. After positive community review, work should be sent to + soc@kernel.org in one patchset containing new arch/foo/Kconfig entry, DTS + files, MAINTAINERS file entry and optionally initial drivers with their + Devicetree bindings. The MAINTAINERS file entry should list new + platform-specific maintainers, who are going to be responsible for handling + patches for the platform from now on. + +Note that the soc@kernel.org is usually not the place to discuss the patches, +thus work sent to this address should be already considered as acceptable by +the community. + Information for (new) Submaintainers ------------------------------------
Patches for SoCs are expected to be picked up by SoC submaintainers. The main SoC maintainers should be addressed only in few cases. Rewrite the section about maintainer handling to document above expectation. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Will Deacon <will@kernel.org> Cc: Kevin Hilman <khilman@baylibre.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Conor Dooley <conor@kernel.org> Cc: Heiko Stübner <heiko@sntech.de> --- During our LPC ad-hoc BoF, we discussed improving Maintainer SoC docs and I think I volunteered to write something. The trouble is that whatever I won't write in my notes, escapes my memory. I believe this is what we discussed. Was there anything more to write/document? Changes in v2: 1. Fix missing closing ) (Conor). 2. Style changes (in point 3.). 3. Soften note that soc@kernel is not for discussing ("is usually not"). --- Documentation/process/maintainer-soc.rst | 42 +++++++++++++++++++++--- 1 file changed, 37 insertions(+), 5 deletions(-)