| Message ID | 20240802090544.2741206-9-kevin_chen@aspeedtech.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Introduce ASPEED AST27XX BMC SoC | expand |
On Fri, 2 Aug 2024 at 12:05, Kevin Chen <kevin_chen@aspeedtech.com> wrote: > > Enable CONFIG_ARCH_ASPEED in arm64 defconfig. Why? Usually the defconfig changes have "Enable CONFIG_FOO as it is used on the Bar Baz platform" commit message. > > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 7d32fca64996..b393735a695f 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -38,6 +38,7 @@ CONFIG_ARCH_AIROHA=y > CONFIG_ARCH_SUNXI=y > CONFIG_ARCH_ALPINE=y > CONFIG_ARCH_APPLE=y > +CONFIG_ARCH_ASPEED=y > CONFIG_ARCH_BCM=y > CONFIG_ARCH_BCM2835=y > CONFIG_ARCH_BCM_IPROC=y > -- > 2.34.1 >
On Fri, Aug 2, 2024, at 21:20, Dmitry Baryshkov wrote: > On Fri, 2 Aug 2024 at 12:05, Kevin Chen <kevin_chen@aspeedtech.com> wrote: >> >> Enable CONFIG_ARCH_ASPEED in arm64 defconfig. > > Why? Usually the defconfig changes have "Enable CONFIG_FOO as it is > used on the Bar Baz platform" commit message. I would also expect to see aspeed specific device drivers to get enabled in the same commit. On arm32, I see CONFIG_ASPEED_KCS_IPMI_BMC=m CONFIG_ASPEED_BT_IPMI_BMC=m CONFIG_I2C_ASPEED=m CONFIG_SPI_ASPEED_SMC=m CONFIG_GPIO_ASPEED_SGPIO=y CONFIG_SENSORS_ASPEED=m CONFIG_VIDEO_ASPEED=m CONFIG_DRM_ASPEED_GFX=m CONFIG_USB_ASPEED_VHUB=m CONFIG_RTC_DRV_ASPEED=m CONFIG_ASPEED_LPC_CTRL=m CONFIG_ASPEED_LPC_SNOOP=m CONFIG_ASPEED_P2A_CTRL=m CONFIG_ASPEED_ADC=m CONFIG_FSI_MASTER_ASPEED=m Presumably not all but a lot of these are also used on AST2700. Arnd
> > > > Enable CONFIG_ARCH_ASPEED in arm64 defconfig. > > Why? Usually the defconfig changes have "Enable CONFIG_FOO as it is used on > the Bar Baz platform" commit message. Agree. I will fix it in next patch. > > > > > Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig > > b/arch/arm64/configs/defconfig index 7d32fca64996..b393735a695f 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -38,6 +38,7 @@ CONFIG_ARCH_AIROHA=y CONFIG_ARCH_SUNXI=y > > CONFIG_ARCH_ALPINE=y CONFIG_ARCH_APPLE=y > > +CONFIG_ARCH_ASPEED=y > > CONFIG_ARCH_BCM=y > > CONFIG_ARCH_BCM2835=y > > CONFIG_ARCH_BCM_IPROC=y > > -- > > 2.34.1 > > > > > -- > With best wishes > Dmitry
> >> > >> Enable CONFIG_ARCH_ASPEED in arm64 defconfig. > > > > Why? Usually the defconfig changes have "Enable CONFIG_FOO as it is > > used on the Bar Baz platform" commit message. > > I would also expect to see aspeed specific device drivers to get enabled in the > same commit. On arm32, I see For different device drivers, ASPEED would submit code by its owner with CONFIG enabled. > > CONFIG_ASPEED_KCS_IPMI_BMC=m > CONFIG_ASPEED_BT_IPMI_BMC=m > CONFIG_I2C_ASPEED=m > CONFIG_SPI_ASPEED_SMC=m > CONFIG_GPIO_ASPEED_SGPIO=y > CONFIG_SENSORS_ASPEED=m > CONFIG_VIDEO_ASPEED=m > CONFIG_DRM_ASPEED_GFX=m > CONFIG_USB_ASPEED_VHUB=m > CONFIG_RTC_DRV_ASPEED=m > CONFIG_ASPEED_LPC_CTRL=m > CONFIG_ASPEED_LPC_SNOOP=m > CONFIG_ASPEED_P2A_CTRL=m > CONFIG_ASPEED_ADC=m > CONFIG_FSI_MASTER_ASPEED=m > > Presumably not all but a lot of these are also used on AST2700. > > Arnd
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 7d32fca64996..b393735a695f 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -38,6 +38,7 @@ CONFIG_ARCH_AIROHA=y CONFIG_ARCH_SUNXI=y CONFIG_ARCH_ALPINE=y CONFIG_ARCH_APPLE=y +CONFIG_ARCH_ASPEED=y CONFIG_ARCH_BCM=y CONFIG_ARCH_BCM2835=y CONFIG_ARCH_BCM_IPROC=y
Enable CONFIG_ARCH_ASPEED in arm64 defconfig. Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)