diff mbox series

[net-next,02/11] dt-bindings: net: add i.MX95 ENETC support

Message ID 20241009095116.147412-3-wei.fang@nxp.com (mailing list archive)
State Superseded
Headers show
Series add basic support for i.MX95 NETC | expand

Commit Message

Wei Fang Oct. 9, 2024, 9:51 a.m. UTC
The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
ID and device ID have also changed, so add the new compatible strings
for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
or RMII reference clock.

Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 .../devicetree/bindings/net/fsl,enetc.yaml    | 23 +++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

Comments

Frank Li Oct. 9, 2024, 4:29 p.m. UTC | #1
On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote:
> The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
> ID and device ID have also changed, so add the new compatible strings
> for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
> or RMII reference clock.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
>  .../devicetree/bindings/net/fsl,enetc.yaml    | 23 +++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> index e152c93998fe..1a6685bb7230 100644
> --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> @@ -20,14 +20,29 @@ maintainers:
>
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - pci1957,e100
> -      - const: fsl,enetc
> +    oneOf:
> +      - items:
> +          - enum:
> +              - pci1957,e100
> +          - const: fsl,enetc
> +      - items:
> +          - const: pci1131,e101
> +      - items:
> +          - enum:
> +              - nxp,imx95-enetc
> +          - const: pci1131,e101

    oneOf:
      - items:
          - enum:
              - pci1957,e100
          - const: fsl,enetc
      - items:
          - const: pci1131,e101
          - enum:
              - nxp,imx95-enetc
          minItems: 1

keep consistent, pid/did as first one.

Frank

>
>    reg:
>      maxItems: 1
>
> +  clocks:
> +    items:
> +      - description: MAC transmit/receiver reference clock
> +
> +  clock-names:
> +    items:
> +      - const: enet_ref_clk
> +
>    mdio:
>      $ref: mdio.yaml
>      unevaluatedProperties: false
> --
> 2.34.1
>
Rob Herring Oct. 9, 2024, 8:53 p.m. UTC | #2
On Wed, Oct 09, 2024 at 12:29:57PM -0400, Frank Li wrote:
> On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote:
> > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
> > ID and device ID have also changed, so add the new compatible strings
> > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
> > or RMII reference clock.
> >
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > ---
> >  .../devicetree/bindings/net/fsl,enetc.yaml    | 23 +++++++++++++++----
> >  1 file changed, 19 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > index e152c93998fe..1a6685bb7230 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > @@ -20,14 +20,29 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    items:
> > -      - enum:
> > -          - pci1957,e100
> > -      - const: fsl,enetc
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - pci1957,e100
> > +          - const: fsl,enetc
> > +      - items:
> > +          - const: pci1131,e101
> > +      - items:
> > +          - enum:
> > +              - nxp,imx95-enetc
> > +          - const: pci1131,e101
> 
>     oneOf:
>       - items:
>           - enum:
>               - pci1957,e100
>           - const: fsl,enetc
>       - items:
>           - const: pci1131,e101
>           - enum:
>               - nxp,imx95-enetc

const.

Or maybe just drop it. Hopefully the PCI ID changes with each chip. If 
not, we kind of have the compatibles backwards.

>           minItems: 1

Then why have the fallback?
Wei Fang Oct. 10, 2024, 2 a.m. UTC | #3
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: 2024年10月10日 0:30
> To: Wei Fang <wei.fang@nxp.com>
> Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
> pabeni@redhat.com; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; Vladimir Oltean <vladimir.oltean@nxp.com>; Claudiu
> Manoil <claudiu.manoil@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>;
> christophe.leroy@csgroup.eu; linux@armlinux.org.uk; bhelgaas@google.com;
> imx@lists.linux.dev; netdev@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org
> Subject: Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support
> 
> On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote:
> > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
> > ID and device ID have also changed, so add the new compatible strings
> > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
> > or RMII reference clock.
> >
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > ---
> >  .../devicetree/bindings/net/fsl,enetc.yaml    | 23 +++++++++++++++----
> >  1 file changed, 19 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > index e152c93998fe..1a6685bb7230 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > @@ -20,14 +20,29 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    items:
> > -      - enum:
> > -          - pci1957,e100
> > -      - const: fsl,enetc
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - pci1957,e100
> > +          - const: fsl,enetc
> > +      - items:
> > +          - const: pci1131,e101
> > +      - items:
> > +          - enum:
> > +              - nxp,imx95-enetc
> > +          - const: pci1131,e101
> 
>     oneOf:
>       - items:
>           - enum:
>               - pci1957,e100
>           - const: fsl,enetc
>       - items:
>           - const: pci1131,e101
>           - enum:
>               - nxp,imx95-enetc
>           minItems: 1
> 
> keep consistent, pid/did as first one.
> 

I think it's better to put enum before const, and minItems
does not seem to be placed here.

> 
> >
> >    reg:
> >      maxItems: 1
> >
> > +  clocks:
> > +    items:
> > +      - description: MAC transmit/receiver reference clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: enet_ref_clk
> > +
> >    mdio:
> >      $ref: mdio.yaml
> >      unevaluatedProperties: false
> > --
> > 2.34.1
> >
Wei Fang Oct. 10, 2024, 2:14 a.m. UTC | #4
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 2024年10月10日 4:53
> To: Frank Li <frank.li@nxp.com>
> Cc: Wei Fang <wei.fang@nxp.com>; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> krzk+dt@kernel.org; conor+dt@kernel.org; Vladimir Oltean
> <vladimir.oltean@nxp.com>; Claudiu Manoil <claudiu.manoil@nxp.com>; Clark
> Wang <xiaoning.wang@nxp.com>; christophe.leroy@csgroup.eu;
> linux@armlinux.org.uk; bhelgaas@google.com; imx@lists.linux.dev;
> netdev@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org
> Subject: Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support
> 
> On Wed, Oct 09, 2024 at 12:29:57PM -0400, Frank Li wrote:
> > On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote:
> > > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
> > > ID and device ID have also changed, so add the new compatible strings
> > > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
> > > or RMII reference clock.
> > >
> > > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > > ---
> > >  .../devicetree/bindings/net/fsl,enetc.yaml    | 23 +++++++++++++++----
> > >  1 file changed, 19 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > index e152c93998fe..1a6685bb7230 100644
> > > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > @@ -20,14 +20,29 @@ maintainers:
> > >
> > >  properties:
> > >    compatible:
> > > -    items:
> > > -      - enum:
> > > -          - pci1957,e100
> > > -      - const: fsl,enetc
> > > +    oneOf:
> > > +      - items:
> > > +          - enum:
> > > +              - pci1957,e100
> > > +          - const: fsl,enetc
> > > +      - items:
> > > +          - const: pci1131,e101
> > > +      - items:
> > > +          - enum:
> > > +              - nxp,imx95-enetc
> > > +          - const: pci1131,e101
> >
> >     oneOf:
> >       - items:
> >           - enum:
> >               - pci1957,e100
> >           - const: fsl,enetc
> >       - items:
> >           - const: pci1131,e101
> >           - enum:
> >               - nxp,imx95-enetc
> 
> const.
> 
> Or maybe just drop it. Hopefully the PCI ID changes with each chip. If
> not, we kind of have the compatibles backwards.

I am pretty sure that the device ID will not change in later chips unless
the functionality of the ENETC is different.
> 
> >           minItems: 1
> 
> Then why have the fallback?
Frank Li Oct. 10, 2024, 3:16 p.m. UTC | #5
On Thu, Oct 10, 2024 at 02:14:50AM +0000, Wei Fang wrote:
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: 2024年10月10日 4:53
> > To: Frank Li <frank.li@nxp.com>
> > Cc: Wei Fang <wei.fang@nxp.com>; davem@davemloft.net;
> > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> > krzk+dt@kernel.org; conor+dt@kernel.org; Vladimir Oltean
> > <vladimir.oltean@nxp.com>; Claudiu Manoil <claudiu.manoil@nxp.com>; Clark
> > Wang <xiaoning.wang@nxp.com>; christophe.leroy@csgroup.eu;
> > linux@armlinux.org.uk; bhelgaas@google.com; imx@lists.linux.dev;
> > netdev@vger.kernel.org; devicetree@vger.kernel.org;
> > linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org
> > Subject: Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support
> >
> > On Wed, Oct 09, 2024 at 12:29:57PM -0400, Frank Li wrote:
> > > On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote:
> > > > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
> > > > ID and device ID have also changed, so add the new compatible strings
> > > > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
> > > > or RMII reference clock.
> > > >
> > > > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > > > ---
> > > >  .../devicetree/bindings/net/fsl,enetc.yaml    | 23 +++++++++++++++----
> > > >  1 file changed, 19 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > index e152c93998fe..1a6685bb7230 100644
> > > > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > @@ -20,14 +20,29 @@ maintainers:
> > > >
> > > >  properties:
> > > >    compatible:
> > > > -    items:
> > > > -      - enum:
> > > > -          - pci1957,e100
> > > > -      - const: fsl,enetc
> > > > +    oneOf:
> > > > +      - items:
> > > > +          - enum:
> > > > +              - pci1957,e100
> > > > +          - const: fsl,enetc
> > > > +      - items:
> > > > +          - const: pci1131,e101
> > > > +      - items:
> > > > +          - enum:
> > > > +              - nxp,imx95-enetc
> > > > +          - const: pci1131,e101
> > >
> > >     oneOf:
> > >       - items:
> > >           - enum:
> > >               - pci1957,e100
> > >           - const: fsl,enetc
> > >       - items:
> > >           - const: pci1131,e101
> > >           - enum:
> > >               - nxp,imx95-enetc
> >
> > const.
> >
> > Or maybe just drop it. Hopefully the PCI ID changes with each chip. If
> > not, we kind of have the compatibles backwards.
>
> I am pretty sure that the device ID will not change in later chips unless
> the functionality of the ENETC is different.

It is quite weird for PCIe devices. Device ID, at least Reversion ID should
change. At least, I have not see use "nxp,imx95-enetc" at driver code.

Frank

> >
> > >           minItems: 1
> >
> > Then why have the fallback?
Wei Fang Oct. 11, 2024, 1:56 a.m. UTC | #6
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: 2024年10月10日 23:17
> To: Wei Fang <wei.fang@nxp.com>
> Cc: Rob Herring <robh@kernel.org>; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> krzk+dt@kernel.org; conor+dt@kernel.org; Vladimir Oltean
> <vladimir.oltean@nxp.com>; Claudiu Manoil <claudiu.manoil@nxp.com>; Clark
> Wang <xiaoning.wang@nxp.com>; christophe.leroy@csgroup.eu;
> linux@armlinux.org.uk; bhelgaas@google.com; imx@lists.linux.dev;
> netdev@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org
> Subject: Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC support
> 
> On Thu, Oct 10, 2024 at 02:14:50AM +0000, Wei Fang wrote:
> > > -----Original Message-----
> > > From: Rob Herring <robh@kernel.org>
> > > Sent: 2024年10月10日 4:53
> > > To: Frank Li <frank.li@nxp.com>
> > > Cc: Wei Fang <wei.fang@nxp.com>; davem@davemloft.net;
> > > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> > > krzk+dt@kernel.org; conor+dt@kernel.org; Vladimir Oltean
> > > <vladimir.oltean@nxp.com>; Claudiu Manoil <claudiu.manoil@nxp.com>;
> Clark
> > > Wang <xiaoning.wang@nxp.com>; christophe.leroy@csgroup.eu;
> > > linux@armlinux.org.uk; bhelgaas@google.com; imx@lists.linux.dev;
> > > netdev@vger.kernel.org; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; linux-pci@vger.kernel.org
> > > Subject: Re: [PATCH net-next 02/11] dt-bindings: net: add i.MX95 ENETC
> support
> > >
> > > On Wed, Oct 09, 2024 at 12:29:57PM -0400, Frank Li wrote:
> > > > On Wed, Oct 09, 2024 at 05:51:07PM +0800, Wei Fang wrote:
> > > > > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
> > > > > ID and device ID have also changed, so add the new compatible strings
> > > > > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
> > > > > or RMII reference clock.
> > > > >
> > > > > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > > > > ---
> > > > >  .../devicetree/bindings/net/fsl,enetc.yaml    | 23
> +++++++++++++++----
> > > > >  1 file changed, 19 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > > index e152c93998fe..1a6685bb7230 100644
> > > > > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > > > @@ -20,14 +20,29 @@ maintainers:
> > > > >
> > > > >  properties:
> > > > >    compatible:
> > > > > -    items:
> > > > > -      - enum:
> > > > > -          - pci1957,e100
> > > > > -      - const: fsl,enetc
> > > > > +    oneOf:
> > > > > +      - items:
> > > > > +          - enum:
> > > > > +              - pci1957,e100
> > > > > +          - const: fsl,enetc
> > > > > +      - items:
> > > > > +          - const: pci1131,e101
> > > > > +      - items:
> > > > > +          - enum:
> > > > > +              - nxp,imx95-enetc
> > > > > +          - const: pci1131,e101
> > > >
> > > >     oneOf:
> > > >       - items:
> > > >           - enum:
> > > >               - pci1957,e100
> > > >           - const: fsl,enetc
> > > >       - items:
> > > >           - const: pci1131,e101
> > > >           - enum:
> > > >               - nxp,imx95-enetc
> > >
> > > const.
> > >
> > > Or maybe just drop it. Hopefully the PCI ID changes with each chip. If
> > > not, we kind of have the compatibles backwards.
> >
> > I am pretty sure that the device ID will not change in later chips unless
> > the functionality of the ENETC is different.
> 
> It is quite weird for PCIe devices. Device ID, at least Reversion ID should
> change. At least, I have not see use "nxp,imx95-enetc" at driver code.
>
Yes, the "nxp,imx95-enetc" is not used in the driver yet, I just referred to
"fsl,enetc". I think I can remove it in the next version. Thanks.

> 
> > >
> > > >           minItems: 1
> > >
> > > Then why have the fallback?
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
index e152c93998fe..1a6685bb7230 100644
--- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
@@ -20,14 +20,29 @@  maintainers:
 
 properties:
   compatible:
-    items:
-      - enum:
-          - pci1957,e100
-      - const: fsl,enetc
+    oneOf:
+      - items:
+          - enum:
+              - pci1957,e100
+          - const: fsl,enetc
+      - items:
+          - const: pci1131,e101
+      - items:
+          - enum:
+              - nxp,imx95-enetc
+          - const: pci1131,e101
 
   reg:
     maxItems: 1
 
+  clocks:
+    items:
+      - description: MAC transmit/receiver reference clock
+
+  clock-names:
+    items:
+      - const: enet_ref_clk
+
   mdio:
     $ref: mdio.yaml
     unevaluatedProperties: false