diff mbox series

wifi: ipw2x00/lib80211: select ARC4 helper

Message ID 20241015073216.9443-1-arnd@kernel.org (mailing list archive)
State Superseded
Delegated to: Kalle Valo
Headers show
Series wifi: ipw2x00/lib80211: select ARC4 helper | expand

Commit Message

Arnd Bergmann Oct. 15, 2024, 7:32 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The lib80211 code uses arc4 crypto helpers that can be
disabled:

ERROR: modpost: "arc4_setkey" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
ERROR: modpost: "arc4_crypt" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!

Select the library from Kconfig to ensure this can be called.

Fixes: 02f220b52670 ("wifi: ipw2x00/lib80211: move remaining lib80211 into libipw")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/wireless/intel/ipw2x00/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Johannes Berg Oct. 15, 2024, 7:45 a.m. UTC | #1 
On Tue, 2024-10-15 at 07:32 +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The lib80211 code uses arc4 crypto helpers that can be
> disabled:
> 
> ERROR: modpost: "arc4_setkey" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
> ERROR: modpost: "arc4_crypt" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
> 
> Select the library from Kconfig to ensure this can be called.
> 
> Fixes: 02f220b52670 ("wifi: ipw2x00/lib80211: move remaining lib80211 into libipw")

Right, sorry. I sent a similar one before:

https://lore.kernel.org/linux-wireless/20241011115820.070c468b271d.Iac76e81b5cd9a5b949b8c154381128e8131d581d@changeid/

> +++ b/drivers/net/wireless/intel/ipw2x00/Kconfig
> @@ -6,6 +6,7 @@
>  config IPW2100
>  	tristate "Intel PRO/Wireless 2100 Network Connection"
>  	depends on PCI && CFG80211
> +	select CRYPTO_LIB_ARC4
> 
I think this got to the wrong place?

johannes
Arnd Bergmann Oct. 15, 2024, 8:26 a.m. UTC | #2 
On Tue, Oct 15, 2024, at 07:45, Johannes Berg wrote:
>> +++ b/drivers/net/wireless/intel/ipw2x00/Kconfig
>> @@ -6,6 +6,7 @@
>>  config IPW2100
>>  	tristate "Intel PRO/Wireless 2100 Network Connection"
>>  	depends on PCI && CFG80211
>> +	select CRYPTO_LIB_ARC4
>> 
> I think this got to the wrong place?

Right, your versions is the correct one.

     Arnd
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/ipw2x00/Kconfig b/drivers/net/wireless/intel/ipw2x00/Kconfig
index 5e98be664d38..98a17c941100 100644
--- a/drivers/net/wireless/intel/ipw2x00/Kconfig
+++ b/drivers/net/wireless/intel/ipw2x00/Kconfig
@@ -6,6 +6,7 @@ 
 config IPW2100
 	tristate "Intel PRO/Wireless 2100 Network Connection"
 	depends on PCI && CFG80211
+	select CRYPTO_LIB_ARC4
 	select WIRELESS_EXT
 	select WEXT_PRIV
 	select FW_LOADER