| Message ID | 40245564-41fe-4a5e-881f-cd517255b20a@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a95d28a8a2f76c591a195c06ea15f5b15c66c3d1 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: rtlwifi: rtl8192du: Don't claim USB ID 0bda:8171 | expand |
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: > This ID appears to be RTL8188SU, not RTL8192DU. This is the wrong driver > for RTL8188SU. The r8712u driver from staging handles this ID. > > I think this ID comes from the original rtl8192du driver from Realtek. > I don't know if they added it by mistake, or it was actually used for > two different chips. > > RTL8188SU with this ID exists in the wild. RTL8192DU with this ID > probably doesn't. Confirmed with internal ID table, 0bda:8171 is belong to 8188SU. > > Cc: stable@vger.kernel.org # v6.11 > Link: https://github.com/lwfinger/rtl8192du/issues/105 > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: > This ID appears to be RTL8188SU, not RTL8192DU. This is the wrong driver > for RTL8188SU. The r8712u driver from staging handles this ID. > > I think this ID comes from the original rtl8192du driver from Realtek. > I don't know if they added it by mistake, or it was actually used for > two different chips. > > RTL8188SU with this ID exists in the wild. RTL8192DU with this ID > probably doesn't. > > Cc: stable@vger.kernel.org # v6.11 > Link: https://github.com/lwfinger/rtl8192du/issues/105 > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> I assigned this to me on patchwork, I'll take this to wireless tree and add: Fixes: b5dc8873b6ff ("wifi: rtlwifi: Add rtl8192du/sw.c") Ok?
Kalle Valo <kvalo@kernel.org> wrote: > Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: > > > This ID appears to be RTL8188SU, not RTL8192DU. This is the wrong driver > > for RTL8188SU. The r8712u driver from staging handles this ID. > > > > I think this ID comes from the original rtl8192du driver from Realtek. > > I don't know if they added it by mistake, or it was actually used for > > two different chips. > > > > RTL8188SU with this ID exists in the wild. RTL8192DU with this ID > > probably doesn't. > > > > Cc: stable@vger.kernel.org # v6.11 > > Link: https://github.com/lwfinger/rtl8192du/issues/105 > > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> > > Acked-by: Ping-Ke Shih <pkshih@realtek.com> > > I assigned this to me on patchwork, I'll take this to wireless tree and add: > > Fixes: b5dc8873b6ff ("wifi: rtlwifi: Add rtl8192du/sw.c") > > Ok? Ok. Thanks!
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: > This ID appears to be RTL8188SU, not RTL8192DU. This is the wrong driver > for RTL8188SU. The r8712u driver from staging handles this ID. > > I think this ID comes from the original rtl8192du driver from Realtek. > I don't know if they added it by mistake, or it was actually used for > two different chips. > > RTL8188SU with this ID exists in the wild. RTL8192DU with this ID > probably doesn't. > > Fixes: b5dc8873b6ff ("wifi: rtlwifi: Add rtl8192du/sw.c") > Cc: stable@vger.kernel.org # v6.11 > Closes: https://github.com/lwfinger/rtl8192du/issues/105 > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless.git, thanks. a95d28a8a2f7 wifi: rtlwifi: rtl8192du: Don't claim USB ID 0bda:8171
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192du/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/sw.c index d069a81ac617..cc699efa9c79 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192du/sw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/sw.c @@ -352,7 +352,6 @@ static const struct usb_device_id rtl8192d_usb_ids[] = { {RTL_USB_DEVICE(USB_VENDOR_ID_REALTEK, 0x8194, rtl92du_hal_cfg)}, {RTL_USB_DEVICE(USB_VENDOR_ID_REALTEK, 0x8111, rtl92du_hal_cfg)}, {RTL_USB_DEVICE(USB_VENDOR_ID_REALTEK, 0x0193, rtl92du_hal_cfg)}, - {RTL_USB_DEVICE(USB_VENDOR_ID_REALTEK, 0x8171, rtl92du_hal_cfg)}, {RTL_USB_DEVICE(USB_VENDOR_ID_REALTEK, 0xe194, rtl92du_hal_cfg)}, {RTL_USB_DEVICE(0x2019, 0xab2c, rtl92du_hal_cfg)}, {RTL_USB_DEVICE(0x2019, 0xab2d, rtl92du_hal_cfg)},
This ID appears to be RTL8188SU, not RTL8192DU. This is the wrong driver for RTL8188SU. The r8712u driver from staging handles this ID. I think this ID comes from the original rtl8192du driver from Realtek. I don't know if they added it by mistake, or it was actually used for two different chips. RTL8188SU with this ID exists in the wild. RTL8192DU with this ID probably doesn't. Cc: stable@vger.kernel.org # v6.11 Link: https://github.com/lwfinger/rtl8192du/issues/105 Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8192du/sw.c | 1 - 1 file changed, 1 deletion(-)