[v2,21/22] wifi: rtw88: Add rtw8821au.c and rtw8812au.c

Commit Message

Bitterblue Smith Oct. 11, 2024, 8:57 p.m. UTC

These are the entry points for the new modules rtw88_8821au
(RTL8821AU/RTL8811AU) and rtw88_8812au (RTL8812AU).

Signed-off-by: Bitterblue Smith <[e-mail]>
---
v2:
 - Fix copyright year.
 - Include the correct header rtw8812a.h in rtw8812au.c.
---
 .../net/wireless/realtek/rtw88/rtw8812au.c    | 28 +++++++++++++++++++
 .../net/wireless/realtek/rtw88/rtw8821au.c    | 28 +++++++++++++++++++
 2 files changed, 56 insertions(+)
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8812au.c
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8821au.c

Comments

Ping-Ke Shih Oct. 18, 2024, 7:36 a.m. UTC | #1

Bitterblue Smith <[e-mail]> wrote:
> +
> +static const struct usb_device_id rtw_8821au_id_table[] = {
> +       { USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x011e, 0xff, 0xff, 0xff),
> +         .driver_info = (kernel_ulong_t)&(rtw8821a_hw_spec) },

Module description says "8821au/8811au", but only one device ID. Do they
share the same ID?

> +       {},
> +};
> +MODULE_DEVICE_TABLE(usb, rtw_8821au_id_table);
> +
> +static struct usb_driver rtw_8821au_driver = {
> +       .name = "rtw_8821au",
> +       .id_table = rtw_8821au_id_table,
> +       .probe = rtw_usb_probe,
> +       .disconnect = rtw_usb_disconnect,
> +};
> +module_usb_driver(rtw_8821au_driver);
> +
> +MODULE_AUTHOR("Bitterblue Smith <[e-mail]>");
> +MODULE_DESCRIPTION("Realtek 802.11ac wireless 8821au/8811au driver");
> +MODULE_LICENSE("Dual BSD/GPL");
> --
> 2.46.0

Bitterblue Smith Oct. 18, 2024, 4:42 p.m. UTC | #2

On 18/10/2024 10:36, Ping-Ke Shih wrote:
> Bitterblue Smith <[e-mail]> wrote:
>> +
>> +static const struct usb_device_id rtw_8821au_id_table[] = {
>> +       { USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x011e, 0xff, 0xff, 0xff),
>> +         .driver_info = (kernel_ulong_t)&(rtw8821a_hw_spec) },
> 
> Module description says "8821au/8811au", but only one device ID. Do they
> share the same ID?
> 

This one and 2604:0012 (RTL8812AU) were the devices I had when
I started this work. Then I pushed the code to Larry Finger's
github, where Larry and Nick Morrow added many other device IDs.
I will send their patches after this series.

>> +       {},
>> +};
>> +MODULE_DEVICE_TABLE(usb, rtw_8821au_id_table);
>> +
>> +static struct usb_driver rtw_8821au_driver = {
>> +       .name = "rtw_8821au",
>> +       .id_table = rtw_8821au_id_table,
>> +       .probe = rtw_usb_probe,
>> +       .disconnect = rtw_usb_disconnect,
>> +};
>> +module_usb_driver(rtw_8821au_driver);
>> +
>> +MODULE_AUTHOR("Bitterblue Smith <[e-mail]>");
>> +MODULE_DESCRIPTION("Realtek 802.11ac wireless 8821au/8811au driver");
>> +MODULE_LICENSE("Dual BSD/GPL");
>> --
>> 2.46.0
>

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/rtw8812au.c b/drivers/net/wireless/realtek/rtw88/rtw8812au.c
new file mode 100644
index 000000000000..4da69590a423
--- /dev/null
+++ b/drivers/net/wireless/realtek/rtw88/rtw8812au.c
@@ -0,0 +1,28 @@ 
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+/* Copyright(c) 2024  Realtek Corporation
+ */
+
+#include <linux/module.h>
+#include <linux/usb.h>
+#include "main.h"
+#include "rtw8812a.h"
+#include "usb.h"
+
+static const struct usb_device_id rtw_8812au_id_table[] = {
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x2604, 0x0012, 0xff, 0xff, 0xff),
+	  .driver_info = (kernel_ulong_t)&(rtw8812a_hw_spec) },
+	{},
+};
+MODULE_DEVICE_TABLE(usb, rtw_8812au_id_table);
+
+static struct usb_driver rtw_8812au_driver = {
+	.name = "rtw_8812au",
+	.id_table = rtw_8812au_id_table,
+	.probe = rtw_usb_probe,
+	.disconnect = rtw_usb_disconnect,
+};
+module_usb_driver(rtw_8812au_driver);
+
+MODULE_AUTHOR("Bitterblue Smith <[e-mail]>");
+MODULE_DESCRIPTION("Realtek 802.11ac wireless 8812au driver");
+MODULE_LICENSE("Dual BSD/GPL");
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821au.c b/drivers/net/wireless/realtek/rtw88/rtw8821au.c
new file mode 100644
index 000000000000..730018773e1c
--- /dev/null
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821au.c
@@ -0,0 +1,28 @@ 
+// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+/* Copyright(c) 2024  Realtek Corporation
+ */
+
+#include <linux/module.h>
+#include <linux/usb.h>
+#include "main.h"
+#include "rtw8821a.h"
+#include "usb.h"
+
+static const struct usb_device_id rtw_8821au_id_table[] = {
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x2357, 0x011e, 0xff, 0xff, 0xff),
+	  .driver_info = (kernel_ulong_t)&(rtw8821a_hw_spec) },
+	{},
+};
+MODULE_DEVICE_TABLE(usb, rtw_8821au_id_table);
+
+static struct usb_driver rtw_8821au_driver = {
+	.name = "rtw_8821au",
+	.id_table = rtw_8821au_id_table,
+	.probe = rtw_usb_probe,
+	.disconnect = rtw_usb_disconnect,
+};
+module_usb_driver(rtw_8821au_driver);
+
+MODULE_AUTHOR("Bitterblue Smith <[e-mail]>");
+MODULE_DESCRIPTION("Realtek 802.11ac wireless 8821au/8811au driver");
+MODULE_LICENSE("Dual BSD/GPL");