diff mbox series

riscv: dts: Replace deprecated snps,nr-gpios property for snps,dw-apb-gpio-port devices

Message ID 20241022091428.477697-8-u.kleine-koenig@baylibre.com (mailing list archive)
State Handled Elsewhere
Headers show
Series riscv: dts: Replace deprecated snps,nr-gpios property for snps,dw-apb-gpio-port devices | expand

Checks

Context Check Description
conchuod/vmtest-for-next-PR success PR summary
conchuod/patch-1-test-1 success .github/scripts/patches/tests/build_rv32_defconfig.sh took 142.14s
conchuod/patch-1-test-2 success .github/scripts/patches/tests/build_rv64_clang_allmodconfig.sh took 1250.24s
conchuod/patch-1-test-3 success .github/scripts/patches/tests/build_rv64_gcc_allmodconfig.sh took 1444.60s
conchuod/patch-1-test-4 success .github/scripts/patches/tests/build_rv64_nommu_k210_defconfig.sh took 21.01s
conchuod/patch-1-test-5 success .github/scripts/patches/tests/build_rv64_nommu_virt_defconfig.sh took 23.19s
conchuod/patch-1-test-6 success .github/scripts/patches/tests/checkpatch.sh took 0.41s
conchuod/patch-1-test-7 success .github/scripts/patches/tests/dtb_warn_rv64.sh took 43.77s
conchuod/patch-1-test-8 success .github/scripts/patches/tests/header_inline.sh took 0.00s
conchuod/patch-1-test-9 success .github/scripts/patches/tests/kdoc.sh took 0.59s
conchuod/patch-1-test-10 success .github/scripts/patches/tests/module_param.sh took 0.01s
conchuod/patch-1-test-11 success .github/scripts/patches/tests/verify_fixes.sh took 0.00s
conchuod/patch-1-test-12 success .github/scripts/patches/tests/verify_signedoff.sh took 0.03s

Commit Message

Uwe Kleine-König Oct. 22, 2024, 9:14 a.m. UTC 
snps,dw-apb-gpio-port is deprecated since commit ef42a8da3cf3
("dt-bindings: gpio: dwapb: Add ngpios property support"). The
respective driver supports this since commit 7569486d79ae ("gpio: dwapb:
Add ngpios DT-property support") which is included in Linux v5.10-rc1.

This change was created using

	git grep -l snps,nr-gpios arch/riscv/boot/dts | xargs perl -p -i -e 's/\bsnps,nr-gpios\b/ngpios/

.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
 arch/riscv/boot/dts/sophgo/sg2042.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


base-commit: 7436324ebd147598f940dde1335b7979dbccc339

Comments

Inochi Amaoto Oct. 22, 2024, 10:04 a.m. UTC | #1 
On Tue, Oct 22, 2024 at 11:14:30AM +0200, Uwe Kleine-König wrote:
> snps,dw-apb-gpio-port is deprecated since commit ef42a8da3cf3
> ("dt-bindings: gpio: dwapb: Add ngpios property support"). The
> respective driver supports this since commit 7569486d79ae ("gpio: dwapb:
> Add ngpios DT-property support") which is included in Linux v5.10-rc1.
> 
> This change was created using
> 
> 	git grep -l snps,nr-gpios arch/riscv/boot/dts | xargs perl -p -i -e 's/\bsnps,nr-gpios\b/ngpios/
> 
> .
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Please add Fixes tag.

Others LGTM.

Reviewed-by: Inochi Amaoto <inochiama@gmail.com>
Chen Wang Oct. 22, 2024, 1:05 p.m. UTC | #2 
On 2024/10/22 17:14, Uwe Kleine-König wrote:
> snps,dw-apb-gpio-port is deprecated since commit ef42a8da3cf3
> ("dt-bindings: gpio: dwapb: Add ngpios property support"). The
> respective driver supports this since commit 7569486d79ae ("gpio: dwapb:
> Add ngpios DT-property support") which is included in Linux v5.10-rc1.
>
> This change was created using
>
> 	git grep -l snps,nr-gpios arch/riscv/boot/dts | xargs perl -p -i -e 's/\bsnps,nr-gpios\b/ngpios/
>
> .
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Reviewed-by: Chen Wang <unicorn_wang@outlook.com>

Thanks.

> ---
>   arch/riscv/boot/dts/sophgo/sg2042.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> index 4e5fa6591623..e62ac51ac55a 100644
> --- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
> @@ -112,7 +112,7 @@ port0a: gpio-controller@0 {
>   				compatible = "snps,dw-apb-gpio-port";
>   				gpio-controller;
>   				#gpio-cells = <2>;
> -				snps,nr-gpios = <32>;
> +				ngpios = <32>;
>   				reg = <0>;
>   				interrupt-controller;
>   				#interrupt-cells = <2>;
> @@ -134,7 +134,7 @@ port1a: gpio-controller@0 {
>   				compatible = "snps,dw-apb-gpio-port";
>   				gpio-controller;
>   				#gpio-cells = <2>;
> -				snps,nr-gpios = <32>;
> +				ngpios = <32>;
>   				reg = <0>;
>   				interrupt-controller;
>   				#interrupt-cells = <2>;
> @@ -156,7 +156,7 @@ port2a: gpio-controller@0 {
>   				compatible = "snps,dw-apb-gpio-port";
>   				gpio-controller;
>   				#gpio-cells = <2>;
> -				snps,nr-gpios = <32>;
> +				ngpios = <32>;
>   				reg = <0>;
>   				interrupt-controller;
>   				#interrupt-cells = <2>;
>
> base-commit: 7436324ebd147598f940dde1335b7979dbccc339
Uwe Kleine-König Oct. 22, 2024, 2:08 p.m. UTC | #3 
On Tue, Oct 22, 2024 at 06:04:17PM +0800, Inochi Amaoto wrote:
> On Tue, Oct 22, 2024 at 11:14:30AM +0200, Uwe Kleine-König wrote:
> > snps,dw-apb-gpio-port is deprecated since commit ef42a8da3cf3
> > ("dt-bindings: gpio: dwapb: Add ngpios property support"). The
> > respective driver supports this since commit 7569486d79ae ("gpio: dwapb:
> > Add ngpios DT-property support") which is included in Linux v5.10-rc1.
> 
> Please add Fixes tag.

Ah, I expected that the usage of snps,nr-gpios in the dts files predates
the deprecation. So we could add:

Fixes: a508d794f86e ("riscv: sophgo: dts: add gpio controllers for SG2042 SoC")

. That's a commit that just entered mainline in v6.12-rc1. But I'm not
entirely sure backporting to stable is sensible.

Best regards
Uwe
Conor Dooley Oct. 22, 2024, 4:36 p.m. UTC | #4 
On Tue, Oct 22, 2024 at 04:08:37PM +0200, Uwe Kleine-König wrote:
> On Tue, Oct 22, 2024 at 06:04:17PM +0800, Inochi Amaoto wrote:
> > On Tue, Oct 22, 2024 at 11:14:30AM +0200, Uwe Kleine-König wrote:
> > > snps,dw-apb-gpio-port is deprecated since commit ef42a8da3cf3
> > > ("dt-bindings: gpio: dwapb: Add ngpios property support"). The
> > > respective driver supports this since commit 7569486d79ae ("gpio: dwapb:
> > > Add ngpios DT-property support") which is included in Linux v5.10-rc1.
> > 
> > Please add Fixes tag.
> 
> Ah, I expected that the usage of snps,nr-gpios in the dts files predates
> the deprecation. So we could add:
> 
> Fixes: a508d794f86e ("riscv: sophgo: dts: add gpio controllers for SG2042 SoC")
> 
> . That's a commit that just entered mainline in v6.12-rc1. But I'm not
> entirely sure backporting to stable is sensible.

Ye, I don't think I'd bother with a fixes tag even, since it'll probably
get backported automagically if you add one.
Inochi Amaoto Oct. 25, 2024, 11:33 a.m. UTC | #5 
On Tue, 22 Oct 2024 11:14:30 +0200, Uwe Kleine-König wrote:
> snps,dw-apb-gpio-port is deprecated since commit ef42a8da3cf3
> ("dt-bindings: gpio: dwapb: Add ngpios property support"). The
> respective driver supports this since commit 7569486d79ae ("gpio: dwapb:
> Add ngpios DT-property support") which is included in Linux v5.10-rc1.
> 
> This change was created using
> 
> [...]

Applied to sophgo/fixes, thanks!

[1/1] riscv: dts: Replace deprecated snps,nr-gpios property for snps,dw-apb-gpio-port devices
      https://github.com/sophgo/linux/commit/d99913e1b80b51a058020835e7ea1a44397cb4d7

Thanks,
Inochi
diff mbox series

Patch

diff --git a/arch/riscv/boot/dts/sophgo/sg2042.dtsi b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
index 4e5fa6591623..e62ac51ac55a 100644
--- a/arch/riscv/boot/dts/sophgo/sg2042.dtsi
+++ b/arch/riscv/boot/dts/sophgo/sg2042.dtsi
@@ -112,7 +112,7 @@  port0a: gpio-controller@0 {
 				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
-				snps,nr-gpios = <32>;
+				ngpios = <32>;
 				reg = <0>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
@@ -134,7 +134,7 @@  port1a: gpio-controller@0 {
 				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
-				snps,nr-gpios = <32>;
+				ngpios = <32>;
 				reg = <0>;
 				interrupt-controller;
 				#interrupt-cells = <2>;
@@ -156,7 +156,7 @@  port2a: gpio-controller@0 {
 				compatible = "snps,dw-apb-gpio-port";
 				gpio-controller;
 				#gpio-cells = <2>;
-				snps,nr-gpios = <32>;
+				ngpios = <32>;
 				reg = <0>;
 				interrupt-controller;
 				#interrupt-cells = <2>;