| Message ID | 20241024124000.2931869-4-huangjunxian6@hisilicon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | RDMA/hns: Bugfixes | expand |
On Thu, Oct 24, 2024 at 08:39:58PM +0800, Junxian Huang wrote: > From: Yuyu Li <liyuyu6@huawei.com> > > The sub-directory of hns_roce debugfs is named after the device's > kernel name currently, but it will be inconvenient to use when > the device is renamed. > > Modify the name to pci name as users can always easily find the > correspondence between an RDMA device and its pci name. > > Fixes: eb7854d63db5 ("RDMA/hns: Support SW stats with debugfs") > Signed-off-by: Yuyu Li <liyuyu6@huawei.com> > Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com> > --- > drivers/infiniband/hw/hns/hns_roce_debugfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/hns/hns_roce_debugfs.c b/drivers/infiniband/hw/hns/hns_roce_debugfs.c > index e8febb40f645..b869cdc54118 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_debugfs.c > +++ b/drivers/infiniband/hw/hns/hns_roce_debugfs.c > @@ -5,6 +5,7 @@ > > #include <linux/debugfs.h> > #include <linux/device.h> > +#include <linux/pci.h> > > #include "hns_roce_device.h" > > @@ -86,7 +87,7 @@ void hns_roce_register_debugfs(struct hns_roce_dev *hr_dev) > { > struct hns_roce_dev_debugfs *dbgfs = &hr_dev->dbgfs; > > - dbgfs->root = debugfs_create_dir(dev_name(&hr_dev->ib_dev.dev), > + dbgfs->root = debugfs_create_dir(pci_name(hr_dev->pci_dev), > hns_roce_dbgfs_root); Let's take this change, but the more correct way is to add .rename() callback to ib_device ops in similar way to what we do in ib_client and call to debugfs_rename() from there. See ib_device_rename() implementation for "lient->rename(ibdev, client_data);" call. Thanks
On 2024/10/30 20:12, Leon Romanovsky wrote: > On Thu, Oct 24, 2024 at 08:39:58PM +0800, Junxian Huang wrote: >> From: Yuyu Li <liyuyu6@huawei.com> >> >> The sub-directory of hns_roce debugfs is named after the device's >> kernel name currently, but it will be inconvenient to use when >> the device is renamed. >> >> Modify the name to pci name as users can always easily find the >> correspondence between an RDMA device and its pci name. >> >> Fixes: eb7854d63db5 ("RDMA/hns: Support SW stats with debugfs") >> Signed-off-by: Yuyu Li <liyuyu6@huawei.com> >> Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com> >> --- >> drivers/infiniband/hw/hns/hns_roce_debugfs.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/infiniband/hw/hns/hns_roce_debugfs.c b/drivers/infiniband/hw/hns/hns_roce_debugfs.c >> index e8febb40f645..b869cdc54118 100644 >> --- a/drivers/infiniband/hw/hns/hns_roce_debugfs.c >> +++ b/drivers/infiniband/hw/hns/hns_roce_debugfs.c >> @@ -5,6 +5,7 @@ >> >> #include <linux/debugfs.h> >> #include <linux/device.h> >> +#include <linux/pci.h> >> >> #include "hns_roce_device.h" >> >> @@ -86,7 +87,7 @@ void hns_roce_register_debugfs(struct hns_roce_dev *hr_dev) >> { >> struct hns_roce_dev_debugfs *dbgfs = &hr_dev->dbgfs; >> >> - dbgfs->root = debugfs_create_dir(dev_name(&hr_dev->ib_dev.dev), >> + dbgfs->root = debugfs_create_dir(pci_name(hr_dev->pci_dev), >> hns_roce_dbgfs_root); > > Let's take this change, but the more correct way is to add .rename() > callback to ib_device ops in similar way to what we do in ib_client > and call to debugfs_rename() from there. > > See ib_device_rename() implementation for "lient->rename(ibdev, client_data);" call. > Thanks for applying and the guidance. I'll have a look at it. Junxian > Thanks
diff --git a/drivers/infiniband/hw/hns/hns_roce_debugfs.c b/drivers/infiniband/hw/hns/hns_roce_debugfs.c index e8febb40f645..b869cdc54118 100644 --- a/drivers/infiniband/hw/hns/hns_roce_debugfs.c +++ b/drivers/infiniband/hw/hns/hns_roce_debugfs.c @@ -5,6 +5,7 @@ #include <linux/debugfs.h> #include <linux/device.h> +#include <linux/pci.h> #include "hns_roce_device.h" @@ -86,7 +87,7 @@ void hns_roce_register_debugfs(struct hns_roce_dev *hr_dev) { struct hns_roce_dev_debugfs *dbgfs = &hr_dev->dbgfs; - dbgfs->root = debugfs_create_dir(dev_name(&hr_dev->ib_dev.dev), + dbgfs->root = debugfs_create_dir(pci_name(hr_dev->pci_dev), hns_roce_dbgfs_root); create_sw_stat_debugfs(hr_dev, dbgfs->root);