[v7,0/5] Add DeepComputing FML13V01 board dts

Message

Guodong Xu Oct. 28, 2024, 8:25 a.m. UTC

This series updates Device Tree related files to introduce the
FML13V10 board from DeepComputing, which incorporates a StarFive
JH7110 SoC.  This board is designed for use on the Framework Laptop 13
Chassis, which has (Framework) SKU FRANHQ0001.

The original three versions of this series were posted by Sandie Cao
from DeepComputing.  Her mailer configuration caused mail threading
errors, which led to some confusion.  After some discussion, we have
agreed to take over moving this series toward acceptance.

In the original series (v1 to v5), the FML13V10 board DTS file
disabled some nodes that had been enabled in a common included DTSI
file.  We proposed fixing this in a follow-on series.  However there
was some disagreement about the right way to do this.  In the end,
Emil requested that we resolve this by adding two changes to the next
version of the patch series:
- Do not enable any nodes in the common DTSI file that would need
  to be disabled in a board DTS (or DTSI) file.  (Note that there
  still might be nodes enabled in the common file.)
- Because it will differ dependent on board, do not define the
  "dr_mode" (dual-role mode) property in the common DTSI file,
  defining it in the board files instead.

To address this, starting from v6 of the series, two new patches had
been added to the beginning of the patchset.  The first patch no
longer enables nodes that would need to be disabled for the new
FML13V01 board, and enables them instead in the existing boardas
that need them enabled.  The second patch moves the definition of
the "dr_mode" property for the usb0 node out of the common file and
into the board files.

The remaining three patches are roughly the same as the three
patches in the previous version of this series.  The final
patch has been modified, because it no longer needs to disable
certain nodes that had previously been enabled.

Below is a version history, including direct links to all of the
patches (note: in v1, v2 and v3, a single link to each series
doesn't work).

Best regards,
Guodong, Alex

v7:
- Add Emil's reviewed-by on patch 1, 2 and 5
- Corrected commit description typo in patch 1

v6:
- Updated to apply to the latest version of riscv/for-next
- Move nodes enablement from jh7110-common.dtsi into board dts/dtsi
- Do not specify the USB "dr_mode" property in the common file
- Add Emil's reviewed-by on patch 4 (previously patch 2)

https://lore.kernel.org/all/[e-mail]/

v5:
- Remove the extra "From:" line in commit messages of patch 1 and 2

https://lore.kernel.org/all/[e-mail]/

v4:
- Board name was changed from FM7110 to FML13V10
- Descriptions for all patches in this series were updated slightly
- Add Rob's ack on patch 2
- In patch 3, device nodes were updated to reflect their proper status

https://lore.kernel.org/all/[e-mail]/

v3:
- Update board features into description
- Add Krzysztof's ack on patch 1

https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/

v2:
- Add deepcomputing into vendor list.
- Add deepcomputing,fm7110 into model compatible list.
- Framework Config will be included in later a patch.

https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/

v1:
- Add framework dts and config.

https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/

Guodong Xu (3):
  riscv: dts: starfive: jh7110-common: revised device node
  riscv: dts: starfive: jh7110-common: move usb0 config to board dts
  riscv: dts: starfive: add DeepComputing FML13V01 board device tree

Sandie Cao (2):
  dt-bindings: vendor: add deepcomputing
  dt-bindings: riscv: starfive: add deepcomputing,fml13v01

 .../devicetree/bindings/riscv/starfive.yaml   |  1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
 arch/riscv/boot/dts/starfive/Makefile         |  1 +
 .../boot/dts/starfive/jh7110-common.dtsi      | 10 --------
 .../jh7110-deepcomputing-fml13v01.dts         | 17 +++++++++++++
 .../boot/dts/starfive/jh7110-milkv-mars.dts   | 22 ++++++++++++++++
 .../dts/starfive/jh7110-pine64-star64.dts     | 22 ++++++++++++++++
 .../jh7110-starfive-visionfive-2.dtsi         | 25 +++++++++++++++++++
 8 files changed, 90 insertions(+), 10 deletions(-)
 create mode 100644 arch/riscv/boot/dts/starfive/jh7110-deepcomputing-fml13v01.dts

Comments

Conor Dooley Oct. 31, 2024, 12:26 p.m. UTC | #1

From: Conor Dooley <[e-mail]>

On Mon, 28 Oct 2024 16:25:48 +0800, Guodong Xu wrote:
> This series updates Device Tree related files to introduce the
> FML13V10 board from DeepComputing, which incorporates a StarFive
> JH7110 SoC.  This board is designed for use on the Framework Laptop 13
> Chassis, which has (Framework) SKU FRANHQ0001.
> 
> The original three versions of this series were posted by Sandie Cao
> from DeepComputing.  Her mailer configuration caused mail threading
> errors, which led to some confusion.  After some discussion, we have
> agreed to take over moving this series toward acceptance.
> 
> [...]

Applied to riscv-dt-for-next, thanks!

[1/5] riscv: dts: starfive: jh7110-common: revised device node
      https://git.kernel.org/conor/c/5a5001d27065
[2/5] riscv: dts: starfive: jh7110-common: move usb0 config to board dts
      https://git.kernel.org/conor/c/817eac165ed4
[3/5] dt-bindings: vendor: add deepcomputing
      https://git.kernel.org/conor/c/e9b4ceedb5ae
[4/5] dt-bindings: riscv: starfive: add deepcomputing,fml13v01
      https://git.kernel.org/conor/c/e87fa39dbcb4
[5/5] riscv: dts: starfive: add DeepComputing FML13V01 board device tree
      https://git.kernel.org/conor/c/c8b72c301dbe

Thanks,
Conor.