[v2] PCI: endpoint: Remove surplus return statement from pci_epf_test_clean_dma_chan()

Commit Message

[e-mail] Nov. 5, 2024, 2:55 a.m. UTC

From: Wang Jiang <[e-mail]>

Remove a surplus return statement from the void function that has been
added in the commit commit 8353813c88ef ("PCI: endpoint: Enable DMA
tests for endpoints with DMA capabilities").

Especially, as an empty return statements at the end of a void functions
serve little purpose.

Otherwise, a warning will be issued when building the kernel with W=1:

  296: FILE: ./drivers/pci/endpoint/functions/pci-epf-test.c:296:
  return;

Signed-off-by: Wang Jiang <[e-mail]>
---
 drivers/pci/endpoint/functions/pci-epf-test.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Krzysztof Wilczyński Nov. 5, 2024, 9:19 a.m. UTC | #1

Hello,

> Remove a surplus return statement from the void function that has been
> added in the commit commit 8353813c88ef ("PCI: endpoint: Enable DMA
> tests for endpoints with DMA capabilities").
> 
> Especially, as an empty return statements at the end of a void functions
> serve little purpose.
> 
> Otherwise, a warning will be issued when building the kernel with W=1:
> 
>   296: FILE: ./drivers/pci/endpoint/functions/pci-epf-test.c:296:
>   return;

Applied to endpoint, thank you!

[01/01] PCI: endpoint: Remove surplus return statement from pci_epf_test_clean_dma_chan()
        https://git.kernel.org/pci/pci/c/06f893055382

        Krzysztof

Patch

diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index 7c2ed6eae53a..cfdb38cd8cd7 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -291,8 +291,6 @@  static void pci_epf_test_clean_dma_chan(struct pci_epf_test *epf_test)
 
 	dma_release_channel(epf_test->dma_chan_rx);
 	epf_test->dma_chan_rx = NULL;
-
-	return;
 }
 
 static void pci_epf_test_print_rate(struct pci_epf_test *epf_test,