| Message ID | 20241118035722.1755373-1-quic_rdevanat@quicinc.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Jeff Johnson |
| Headers | show |
| Series | wifi: ath12k: Fix inappropriate use of print_array_to_buf_index() | expand |
On 11/17/2024 7:57 PM, Roopni Devanathan wrote: > Currently in ath12k_htt_print_tx_pdev_mumimo_grp_stats_tlv() the > htt_stats_buf->ul_mumimo_grp_best_usrs array is printed using > print_array_to_buf_index() with a stats_index of 1. This is meant > to convey the semantic that first entry in ul_mumimo_grp_best_usrs > is associated with user 1. However, unlike some of the other "usr" > arrays which have that semantic, ul_mumimo_grp_best_usrs does not > have that semantic. Instead the first entry corresponds to user 0. > > Fix the issue by calling the API - print_array_to_buf(), instead of > print_array_to_buf_index(). > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Roopni Devanathan <quic_rdevanat@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Roopni Devanathan <quic_rdevanat@quicinc.com> writes: > Currently in ath12k_htt_print_tx_pdev_mumimo_grp_stats_tlv() the > htt_stats_buf->ul_mumimo_grp_best_usrs array is printed using > print_array_to_buf_index() with a stats_index of 1. This is meant > to convey the semantic that first entry in ul_mumimo_grp_best_usrs > is associated with user 1. However, unlike some of the other "usr" > arrays which have that semantic, ul_mumimo_grp_best_usrs does not > have that semantic. Instead the first entry corresponds to user 0. > > Fix the issue by calling the API - print_array_to_buf(), instead of > print_array_to_buf_index(). > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Roopni Devanathan <quic_rdevanat@quicinc.com> Acked-by: Kalle Valo <kvalo@kernel.org>
diff --git a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c index 43ea87e981f4..e0ee014ac79e 100644 --- a/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c +++ b/drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c @@ -2277,9 +2277,9 @@ ath12k_htt_print_tx_pdev_mumimo_grp_stats_tlv(const void *tag_buf, u16 tag_len, len += print_array_to_buf(buf, len, "ul_mumimo_grp_best_grp_size", htt_stats_buf->ul_mumimo_grp_best_grp_size, ATH12K_HTT_STATS_NUM_MAX_MUMIMO_SZ, "\n"); - len += print_array_to_buf_index(buf, len, "ul_mumimo_grp_best_num_usrs = ", 1, - htt_stats_buf->ul_mumimo_grp_best_usrs, - ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS, "\n"); + len += print_array_to_buf(buf, len, "ul_mumimo_grp_best_num_usrs = ", + htt_stats_buf->ul_mumimo_grp_best_usrs, + ATH12K_HTT_TX_NUM_AX_MUMIMO_USER_STATS, "\n"); len += print_array_to_buf(buf, len, "ul_mumimo_grp_tputs_observed (per bin = 300 mbps)", htt_stats_buf->ul_mumimo_grp_tputs,
Currently in ath12k_htt_print_tx_pdev_mumimo_grp_stats_tlv() the htt_stats_buf->ul_mumimo_grp_best_usrs array is printed using print_array_to_buf_index() with a stats_index of 1. This is meant to convey the semantic that first entry in ul_mumimo_grp_best_usrs is associated with user 1. However, unlike some of the other "usr" arrays which have that semantic, ul_mumimo_grp_best_usrs does not have that semantic. Instead the first entry corresponds to user 0. Fix the issue by calling the API - print_array_to_buf(), instead of print_array_to_buf_index(). Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Signed-off-by: Roopni Devanathan <quic_rdevanat@quicinc.com> --- drivers/net/wireless/ath/ath12k/debugfs_htt_stats.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: 0ea161de5e5afa1323e982adc8f59bf4af99a84b