| Message ID | 20241210014903.154551-1-e@freeshell.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | riscv: dts: starfive: jh7110-pinfunc.h | expand |
> On 10.12.24 09:49, E Shattow wrote: > [PATCH] riscv: dts: starfive: jh7110-pinfunc.h Describe something in the commit title? > > Fix a typo in StarFive JH7110 pin function definitions > > Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function > definitions") > Signed-off-by: E Shattow <e@freeshell.de> Acked-by: Hal Feng <hal.feng@starfivetech.com> Best regards, Hal > --- > arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h > b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h > index 256de17f5261..ae49c908e7fb 100644 > --- a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h > +++ b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h > @@ -89,7 +89,7 @@ > #define GPOUT_SYS_SDIO1_DATA1 59 > #define GPOUT_SYS_SDIO1_DATA2 60 > #define GPOUT_SYS_SDIO1_DATA3 61 > -#define GPOUT_SYS_SDIO1_DATA4 63 > +#define GPOUT_SYS_SDIO1_DATA4 62 > #define GPOUT_SYS_SDIO1_DATA5 63 > #define GPOUT_SYS_SDIO1_DATA6 64 > #define GPOUT_SYS_SDIO1_DATA7 65 > > base-commit: 708d55db3edbe2ccf88d94b5f2e2b404bc0ba37c > -- > 2.45.2
On 12/9/24 18:14, Hal Feng wrote: >> On 10.12.24 09:49, E Shattow wrote: >> [PATCH] riscv: dts: starfive: jh7110-pinfunc.h > > Describe something in the commit title? > >> >> Fix a typo in StarFive JH7110 pin function definitions >> >> Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function >> definitions") >> Signed-off-by: E Shattow <e@freeshell.de> > > Acked-by: Hal Feng <hal.feng@starfivetech.com> > > Best regards, > Hal > >> --- >> arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h >> b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h >> index 256de17f5261..ae49c908e7fb 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h >> +++ b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h >> @@ -89,7 +89,7 @@ >> #define GPOUT_SYS_SDIO1_DATA1 59 >> #define GPOUT_SYS_SDIO1_DATA2 60 >> #define GPOUT_SYS_SDIO1_DATA3 61 >> -#define GPOUT_SYS_SDIO1_DATA4 63 >> +#define GPOUT_SYS_SDIO1_DATA4 62 >> #define GPOUT_SYS_SDIO1_DATA5 63 >> #define GPOUT_SYS_SDIO1_DATA6 64 >> #define GPOUT_SYS_SDIO1_DATA7 65 >> >> base-commit: 708d55db3edbe2ccf88d94b5f2e2b404bc0ba37c >> -- >> 2.45.2 > Ah... yes I forgot the commit title. Will re-send. Thanks! -E
On Mon, Dec 09, 2024 at 05:48:57PM -0800, E Shattow wrote:
> Fix a typo in StarFive JH7110 pin function definitions
That's not a "typo", but entire wrong value with actual impact.
Best regards,
Krzysztof
diff --git a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h index 256de17f5261..ae49c908e7fb 100644 --- a/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h +++ b/arch/riscv/boot/dts/starfive/jh7110-pinfunc.h @@ -89,7 +89,7 @@ #define GPOUT_SYS_SDIO1_DATA1 59 #define GPOUT_SYS_SDIO1_DATA2 60 #define GPOUT_SYS_SDIO1_DATA3 61 -#define GPOUT_SYS_SDIO1_DATA4 63 +#define GPOUT_SYS_SDIO1_DATA4 62 #define GPOUT_SYS_SDIO1_DATA5 63 #define GPOUT_SYS_SDIO1_DATA6 64 #define GPOUT_SYS_SDIO1_DATA7 65
Fix a typo in StarFive JH7110 pin function definitions Fixes: e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions") Signed-off-by: E Shattow <e@freeshell.de> --- arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 708d55db3edbe2ccf88d94b5f2e2b404bc0ba37c